All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper
@ 2017-11-22 15:24 ` Vasyl Gomonovych
  0 siblings, 0 replies; 5+ messages in thread
From: Vasyl Gomonovych @ 2017-11-22 15:24 UTC (permalink / raw)
  To: mark.yao, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip
  Cc: linux-kernel, gomonovych

Use vma_pages function on vma object instead of explicit computation.
./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
Generated by: scripts/coccinelle/api/vma_pages.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index 1869c8bb76c8..1d9655576b6e 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
 {
 	struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
 	unsigned int i, count = obj->size >> PAGE_SHIFT;
-	unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+	unsigned long user_count = vma_pages(vma);
 	unsigned long uaddr = vma->vm_start;
 	unsigned long offset = vma->vm_pgoff;
 	unsigned long end = user_count + offset;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper
@ 2017-11-22 15:24 ` Vasyl Gomonovych
  0 siblings, 0 replies; 5+ messages in thread
From: Vasyl Gomonovych @ 2017-11-22 15:24 UTC (permalink / raw)
  To: linux-arm-kernel

Use vma_pages function on vma object instead of explicit computation.
./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
Generated by: scripts/coccinelle/api/vma_pages.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index 1869c8bb76c8..1d9655576b6e 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
 {
 	struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
 	unsigned int i, count = obj->size >> PAGE_SHIFT;
-	unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+	unsigned long user_count = vma_pages(vma);
 	unsigned long uaddr = vma->vm_start;
 	unsigned long offset = vma->vm_pgoff;
 	unsigned long end = user_count + offset;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper
  2017-11-22 15:24 ` Vasyl Gomonovych
  (?)
@ 2017-11-27  2:20   ` Sandy Huang
  -1 siblings, 0 replies; 5+ messages in thread
From: Sandy Huang @ 2017-11-27  2:20 UTC (permalink / raw)
  To: Vasyl Gomonovych
  Cc: linux-kernel, airlied, heiko, dri-devel, linux-arm-kernel,
	linux-rockchip

Thanks, this update has merged to drm-misc-next months ago:

https://patchwork.freedesktop.org/patch/178255/


在 2017/11/22 23:24, Vasyl Gomonovych 写道:
> Use vma_pages function on vma object instead of explicit computation.
> ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1869c8bb76c8..1d9655576b6e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
>   {
>       struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
>       unsigned int i, count = obj->size >> PAGE_SHIFT;
> -    unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +    unsigned long user_count = vma_pages(vma);
>       unsigned long uaddr = vma->vm_start;
>       unsigned long offset = vma->vm_pgoff;
>       unsigned long end = user_count + offset;
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper
@ 2017-11-27  2:20   ` Sandy Huang
  0 siblings, 0 replies; 5+ messages in thread
From: Sandy Huang @ 2017-11-27  2:20 UTC (permalink / raw)
  To: Vasyl Gomonovych
  Cc: airlied, linux-kernel, dri-devel, linux-rockchip, linux-arm-kernel

Thanks, this update has merged to drm-misc-next months ago:

https://patchwork.freedesktop.org/patch/178255/


在 2017/11/22 23:24, Vasyl Gomonovych 写道:
> Use vma_pages function on vma object instead of explicit computation.
> ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1869c8bb76c8..1d9655576b6e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
>   {
>       struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
>       unsigned int i, count = obj->size >> PAGE_SHIFT;
> -    unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +    unsigned long user_count = vma_pages(vma);
>       unsigned long uaddr = vma->vm_start;
>       unsigned long offset = vma->vm_pgoff;
>       unsigned long end = user_count + offset;
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper
@ 2017-11-27  2:20   ` Sandy Huang
  0 siblings, 0 replies; 5+ messages in thread
From: Sandy Huang @ 2017-11-27  2:20 UTC (permalink / raw)
  To: linux-arm-kernel

Thanks, this update has merged to drm-misc-next months ago:

https://patchwork.freedesktop.org/patch/178255/


? 2017/11/22 23:24, Vasyl Gomonovych ??:
> Use vma_pages function on vma object instead of explicit computation.
> ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> ? drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
> ? 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1869c8bb76c8..1d9655576b6e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
> ? {
> ? ?? ?struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
> ? ?? ?unsigned int i, count = obj->size >> PAGE_SHIFT;
> -?? ?unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +?? ?unsigned long user_count = vma_pages(vma);
> ? ?? ?unsigned long uaddr = vma->vm_start;
> ? ?? ?unsigned long offset = vma->vm_pgoff;
> ? ?? ?unsigned long end = user_count + offset;
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-27  2:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-22 15:24 [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper Vasyl Gomonovych
2017-11-22 15:24 ` Vasyl Gomonovych
2017-11-27  2:20 ` Sandy Huang
2017-11-27  2:20   ` Sandy Huang
2017-11-27  2:20   ` Sandy Huang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.