Re: [PATCH v2 6/6] iommu/vt-d: Add debugfs support for Intel IOMMU Interrupt remapping

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Ashok Raj <ashok.raj@intel.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Gayatri Kammela <gayatri.kammela@intel.com>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v2 6/6] iommu/vt-d: Add debugfs support for Intel IOMMU Interrupt remapping
Date: Wed, 22 Nov 2017 23:18:06 +0200	[thread overview]
Message-ID: <1511385486.25007.412.camel@linux.intel.com> (raw)
In-Reply-To: <1511378746-109275-7-git-send-email-sohil.mehta@intel.com>

On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote:
> Debugfs extension for Intel IOMMU to dump Interrupt remapping table
> entries for Interrupt remapping and Interrupt posting.

> +static int intel_iommu_ir_open(struct inode *inode, struct file
> *file)
> +{
> +	return single_open(file, intel_iommu_ir_show, inode-
> >i_private);
> +}
> +
> +static const struct file_operations intel_iommu_ir_fops = {
> +	.open		= intel_iommu_ir_open,
> +	.read		= seq_read,
> +	.llseek		= seq_lseek,
> +	.release	= single_release,
> +	.owner		= THIS_MODULE,
> +};
> 

Same comments as per patch 4.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy