All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Vivien Didelot <vivien.didelot@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next v3] net: bridge: add STP xstats
Date: Thu, 12 Dec 2019 08:55:30 +0200	[thread overview]
Message-ID: <15115a6a-b95f-8de0-12ac-c3c98301ae25@cumulusnetworks.com> (raw)
In-Reply-To: <20191212010711.1664000-1-vivien.didelot@gmail.com>

On 12/12/2019 03:07, Vivien Didelot wrote:
> This adds rx_bpdu, tx_bpdu, rx_tcn, tx_tcn, transition_blk,
> transition_fwd xstats counters to the bridge ports copied over via
> netlink, providing useful information for STP.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
> ---
>  include/uapi/linux/if_bridge.h | 10 ++++++++++
>  net/bridge/br_netlink.c        | 13 +++++++++++++
>  net/bridge/br_private.h        |  2 ++
>  net/bridge/br_stp.c            | 15 +++++++++++++++
>  net/bridge/br_stp_bpdu.c       |  4 ++++
>  5 files changed, 44 insertions(+)
> 

Looks good to me, thanks!

Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>



WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Vivien Didelot <vivien.didelot@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>,
	bridge@lists.linux-foundation.org,
	David Ahern <dsahern@gmail.com>
Subject: Re: [Bridge] [PATCH net-next v3] net: bridge: add STP xstats
Date: Thu, 12 Dec 2019 08:55:30 +0200	[thread overview]
Message-ID: <15115a6a-b95f-8de0-12ac-c3c98301ae25@cumulusnetworks.com> (raw)
In-Reply-To: <20191212010711.1664000-1-vivien.didelot@gmail.com>

On 12/12/2019 03:07, Vivien Didelot wrote:
> This adds rx_bpdu, tx_bpdu, rx_tcn, tx_tcn, transition_blk,
> transition_fwd xstats counters to the bridge ports copied over via
> netlink, providing useful information for STP.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
> ---
>  include/uapi/linux/if_bridge.h | 10 ++++++++++
>  net/bridge/br_netlink.c        | 13 +++++++++++++
>  net/bridge/br_private.h        |  2 ++
>  net/bridge/br_stp.c            | 15 +++++++++++++++
>  net/bridge/br_stp_bpdu.c       |  4 ++++
>  5 files changed, 44 insertions(+)
> 

Looks good to me, thanks!

Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>



  parent reply	other threads:[~2019-12-12  6:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  1:07 [PATCH net-next v3] net: bridge: add STP xstats Vivien Didelot
2019-12-12  1:07 ` [Bridge] " Vivien Didelot
2019-12-12  1:07 ` [PATCH iproute2 v4] iplink: add support for " Vivien Didelot
2019-12-12  1:07   ` [Bridge] " Vivien Didelot
2019-12-17  4:45   ` Stephen Hemminger
2019-12-17  4:45     ` [Bridge] " Stephen Hemminger
2019-12-17 16:35   ` David Ahern
2019-12-17 16:35     ` [Bridge] " David Ahern
2019-12-12  6:55 ` Nikolay Aleksandrov [this message]
2019-12-12  6:55   ` [Bridge] [PATCH net-next v3] net: bridge: add " Nikolay Aleksandrov
2019-12-15  4:03 ` Jakub Kicinski
2019-12-15  4:03   ` [Bridge] " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15115a6a-b95f-8de0-12ac-c3c98301ae25@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.