* [PATCH] drm/i915: Enable hotplug polling after registering the outputs
@ 2017-11-27 9:45 Chris Wilson
2017-11-27 10:10 ` ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Chris Wilson @ 2017-11-27 9:45 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Previously we would enable hotplug polling on the outputs immediately
upon construction. This would allow a very early hotplug event to
trigger before we had finishing setting up the driver to handle it.
Instead, move the output polling to the last step of registration, after
we have set up all handlers, including the fbdev configuration.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 0793a27e2b95..c178cbfdb4c2 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -693,8 +693,6 @@ static int i915_load_modeset_init(struct drm_device *dev)
/* Only enable hotplug handling once the fbdev is fully set up. */
intel_hpd_init(dev_priv);
- drm_kms_helper_poll_init(dev);
-
return 0;
cleanup_gem:
@@ -1255,6 +1253,9 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
* cannot run before the connectors are registered.
*/
intel_fbdev_initial_config_async(dev);
+
+ if (INTEL_INFO(dev_priv)->num_pipes)
+ drm_kms_helper_poll_init(dev);
}
/**
--
2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Enable hotplug polling after registering the outputs
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
@ 2017-11-27 10:10 ` Patchwork
2017-11-27 10:18 ` [PATCH] " Maarten Lankhorst
` (4 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2017-11-27 10:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Enable hotplug polling after registering the outputs
URL : https://patchwork.freedesktop.org/series/34445/
State : success
== Summary ==
Series 34445v1 drm/i915: Enable hotplug polling after registering the outputs
https://patchwork.freedesktop.org/api/1.0/series/34445/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test drv_module_reload:
Subgroup basic-reload-inject:
pass -> DMESG-WARN (fi-bwr-2160) fdo#103923
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103923 https://bugs.freedesktop.org/show_bug.cgi?id=103923
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:441s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:461s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:381s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:529s
fi-bwr-2160 total:289 pass:182 dwarn:1 dfail:0 fail:0 skip:106 time:318s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:503s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:503s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:489s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:484s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:419s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:266s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:540s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:424s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:431s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:425s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:458s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:480s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:523s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:482s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:528s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:568s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:444s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:537s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:565s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:505s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:496s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:452s
fi-snb-2520m total:246 pass:212 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:418s
Blacklisted hosts:
fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:607s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:547s
fi-glk-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:487s
2ac27dcb0eb2b64104e890031705714051be9ef8 drm-tip: 2017y-11m-26d-19h-47m-14s UTC integration manifest
0edaf8681399 drm/i915: Enable hotplug polling after registering the outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7300/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Enable hotplug polling after registering the outputs
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
2017-11-27 10:10 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-11-27 10:18 ` Maarten Lankhorst
2017-11-27 10:34 ` Chris Wilson
2017-11-27 11:14 ` ✓ Fi.CI.IGT: success for " Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Maarten Lankhorst @ 2017-11-27 10:18 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter
Op 27-11-17 om 10:45 schreef Chris Wilson:
> Previously we would enable hotplug polling on the outputs immediately
> upon construction. This would allow a very early hotplug event to
> trigger before we had finishing setting up the driver to handle it.
> Instead, move the output polling to the last step of registration, after
> we have set up all handlers, including the fbdev configuration.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 0793a27e2b95..c178cbfdb4c2 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -693,8 +693,6 @@ static int i915_load_modeset_init(struct drm_device *dev)
> /* Only enable hotplug handling once the fbdev is fully set up. */
> intel_hpd_init(dev_priv);
>
> - drm_kms_helper_poll_init(dev);
> -
> return 0;
>
> cleanup_gem:
> @@ -1255,6 +1253,9 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
> * cannot run before the connectors are registered.
> */
> intel_fbdev_initial_config_async(dev);
> +
> + if (INTEL_INFO(dev_priv)->num_pipes)
> + drm_kms_helper_poll_init(dev);
> }
>
> /**
This commit would look better with relevent kernel output pasted in. :)
Could this be done before fbdev initial config? Since it's run async, this makes it more clear it is run first.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Enable hotplug polling after registering the outputs
2017-11-27 10:18 ` [PATCH] " Maarten Lankhorst
@ 2017-11-27 10:34 ` Chris Wilson
2017-11-28 10:33 ` Maarten Lankhorst
0 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2017-11-27 10:34 UTC (permalink / raw)
To: Maarten Lankhorst, intel-gfx; +Cc: Daniel Vetter
Quoting Maarten Lankhorst (2017-11-27 10:18:46)
> Op 27-11-17 om 10:45 schreef Chris Wilson:
> > Previously we would enable hotplug polling on the outputs immediately
> > upon construction. This would allow a very early hotplug event to
> > trigger before we had finishing setting up the driver to handle it.
> > Instead, move the output polling to the last step of registration, after
> > we have set up all handlers, including the fbdev configuration.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 0793a27e2b95..c178cbfdb4c2 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -693,8 +693,6 @@ static int i915_load_modeset_init(struct drm_device *dev)
> > /* Only enable hotplug handling once the fbdev is fully set up. */
> > intel_hpd_init(dev_priv);
> >
> > - drm_kms_helper_poll_init(dev);
> > -
> > return 0;
> >
> > cleanup_gem:
> > @@ -1255,6 +1253,9 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
> > * cannot run before the connectors are registered.
> > */
> > intel_fbdev_initial_config_async(dev);
> > +
> > + if (INTEL_INFO(dev_priv)->num_pipes)
> > + drm_kms_helper_poll_init(dev);
> > }
> >
> > /**
>
> This commit would look better with relevent kernel output pasted in. :)
>
> Could this be done before fbdev initial config? Since it's run async, this makes it more clear it is run first.
No. Because the kms_helper depends upon the async cookie to serialise
its hotplug event with the async fbdev config. It is an unholy mess,
with shutdown just as uncoordinated.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
2017-11-27 10:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-27 10:18 ` [PATCH] " Maarten Lankhorst
@ 2017-11-27 11:14 ` Patchwork
2017-11-28 11:01 ` [PATCH v2] " Chris Wilson
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2017-11-27 11:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Enable hotplug polling after registering the outputs
URL : https://patchwork.freedesktop.org/series/34445/
State : success
== Summary ==
Test kms_flip:
Subgroup flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623
Subgroup fbc-1p-primscrn-pri-shrfb-draw-blt:
pass -> FAIL (shard-snb) fdo#103167
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2662 pass:1535 dwarn:1 dfail:0 fail:10 skip:1116 time:9468s
shard-snb total:2662 pass:1305 dwarn:3 dfail:0 fail:12 skip:1342 time:8043s
Blacklisted hosts:
shard-apl total:2640 pass:1665 dwarn:1 dfail:0 fail:24 skip:949 time:13184s
shard-kbl total:2662 pass:1796 dwarn:9 dfail:0 fail:25 skip:832 time:11219s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7300/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/i915: Enable hotplug polling after registering the outputs
2017-11-27 10:34 ` Chris Wilson
@ 2017-11-28 10:33 ` Maarten Lankhorst
0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2017-11-28 10:33 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Daniel Vetter
Op 27-11-17 om 11:34 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2017-11-27 10:18:46)
>> Op 27-11-17 om 10:45 schreef Chris Wilson:
>>> Previously we would enable hotplug polling on the outputs immediately
>>> upon construction. This would allow a very early hotplug event to
>>> trigger before we had finishing setting up the driver to handle it.
>>> Instead, move the output polling to the last step of registration, after
>>> we have set up all handlers, including the fbdev configuration.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_drv.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>>> index 0793a27e2b95..c178cbfdb4c2 100644
>>> --- a/drivers/gpu/drm/i915/i915_drv.c
>>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>>> @@ -693,8 +693,6 @@ static int i915_load_modeset_init(struct drm_device *dev)
>>> /* Only enable hotplug handling once the fbdev is fully set up. */
>>> intel_hpd_init(dev_priv);
>>>
>>> - drm_kms_helper_poll_init(dev);
>>> -
>>> return 0;
>>>
>>> cleanup_gem:
>>> @@ -1255,6 +1253,9 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
>>> * cannot run before the connectors are registered.
>>> */
>>> intel_fbdev_initial_config_async(dev);
>>> +
>>> + if (INTEL_INFO(dev_priv)->num_pipes)
>>> + drm_kms_helper_poll_init(dev);
>>> }
>>>
>>> /**
>> This commit would look better with relevent kernel output pasted in. :)
>>
>> Could this be done before fbdev initial config? Since it's run async, this makes it more clear it is run first.
> No. Because the kms_helper depends upon the async cookie to serialise
> its hotplug event with the async fbdev config. It is an unholy mess,
> with shutdown just as uncoordinated.
> -Chris
Well that explains the placement, if you can mention the cookie in the commit.
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
` (2 preceding siblings ...)
2017-11-27 11:14 ` ✓ Fi.CI.IGT: success for " Patchwork
@ 2017-11-28 11:01 ` Chris Wilson
2017-11-28 13:02 ` Chris Wilson
2017-11-28 11:33 ` ✓ Fi.CI.BAT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2) Patchwork
2017-11-28 13:08 ` ✓ Fi.CI.IGT: " Patchwork
5 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2017-11-28 11:01 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Previously we would enable hotplug polling on the outputs immediately
upon construction. This would allow a very early hotplug event to
trigger before we had finishing setting up the driver to handle it.
Instead, move the output polling to the last step of registration, after
we have set up all handlers, including the fbdev configuration.
v2: Symmetrically turnoff the hotplug helper in unregister after the
fbdev is first synchronised then finalized. This stops a late hotplug
event being processed after the interrupts are disabled.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> #v1
---
drivers/gpu/drm/i915/i915_drv.c | 16 ++++++++++++++--
drivers/gpu/drm/i915/intel_display.c | 5 +----
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c63fe9b1da1f..cda67dfb0a50 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -693,8 +693,6 @@ static int i915_load_modeset_init(struct drm_device *dev)
/* Only enable hotplug handling once the fbdev is fully set up. */
intel_hpd_init(dev_priv);
- drm_kms_helper_poll_init(dev);
-
return 0;
cleanup_gem:
@@ -1255,6 +1253,13 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
* cannot run before the connectors are registered.
*/
intel_fbdev_initial_config_async(dev);
+
+ /*
+ * We need to coordinate the hotplugs with the asynchronous fbdev
+ * configuration, for which we use the fbdev->async_cookie.
+ */
+ if (INTEL_INFO(dev_priv)->num_pipes)
+ drm_kms_helper_poll_init(dev);
}
/**
@@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
intel_fbdev_unregister(dev_priv);
intel_audio_deinit(dev_priv);
+ /*
+ * After flushing the fbdev (incl. a late async config which will
+ * have delayed queuing of a hotplug event), then flush the hotplug
+ * events.
+ */
+ drm_kms_helper_poll_fini(&dev_priv->drm);
+
intel_gpu_ips_teardown();
acpi_video_unregister();
intel_opregion_unregister(dev_priv);
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d67c7c498b34..f7dc7b7fed80 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -15278,10 +15278,7 @@ static void intel_hpd_poll_fini(struct drm_device *dev)
struct intel_connector *connector;
struct drm_connector_list_iter conn_iter;
- /* First disable polling... */
- drm_kms_helper_poll_fini(dev);
-
- /* Then kill the work that may have been queued by hpd. */
+ /* Kill all the work that may have been queued by hpd. */
drm_connector_list_iter_begin(dev, &conn_iter);
for_each_intel_connector_iter(connector, &conn_iter) {
if (connector->modeset_retry_work.func)
--
2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
` (3 preceding siblings ...)
2017-11-28 11:01 ` [PATCH v2] " Chris Wilson
@ 2017-11-28 11:33 ` Patchwork
2017-11-28 13:08 ` ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2017-11-28 11:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Enable hotplug polling after registering the outputs (rev2)
URL : https://patchwork.freedesktop.org/series/34445/
State : success
== Summary ==
Series 34445v2 drm/i915: Enable hotplug polling after registering the outputs
https://patchwork.freedesktop.org/api/1.0/series/34445/revisions/2/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
Test drv_module_reload:
Subgroup basic-reload-inject:
dmesg-warn -> PASS (fi-bdw-gvtdvm) fdo#103923 +1
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103923 https://bugs.freedesktop.org/show_bug.cgi?id=103923
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:442s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:450s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:383s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:543s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:281s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:503s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:511s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:490s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:484s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:427s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:485s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:488s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:531s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:478s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:528s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:582s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:448s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:544s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:568s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:516s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:453s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:566s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:416s
Blacklisted hosts:
fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:602s
fi-glk-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:495s
9cf8a68eee7db5e7ded75187aac4222c07a808dd drm-tip: 2017y-11m-28d-09h-02m-29s UTC integration manifest
b420261cf83a drm/i915: Enable hotplug polling after registering the outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7321/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs
2017-11-28 11:01 ` [PATCH v2] " Chris Wilson
@ 2017-11-28 13:02 ` Chris Wilson
2017-11-28 13:27 ` Chris Wilson
0 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2017-11-28 13:02 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Quoting Chris Wilson (2017-11-28 11:01:47)
> @@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
> intel_fbdev_unregister(dev_priv);
> intel_audio_deinit(dev_priv);
>
> + /*
> + * After flushing the fbdev (incl. a late async config which will
> + * have delayed queuing of a hotplug event), then flush the hotplug
> + * events.
> + */
> + drm_kms_helper_poll_fini(&dev_priv->drm);
As discussed on irc, I'm unsure as to whether it should be fbdev
followed by kms_helper, or the other way around. In general, I think we
lack some serialisation to control the async hotplug event generation
here... But I think this is sufficiently to make CI happy for the
time being, we will see.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
` (4 preceding siblings ...)
2017-11-28 11:33 ` ✓ Fi.CI.BAT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2) Patchwork
@ 2017-11-28 13:08 ` Patchwork
2017-11-28 14:37 ` Chris Wilson
5 siblings, 1 reply; 12+ messages in thread
From: Patchwork @ 2017-11-28 13:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Enable hotplug polling after registering the outputs (rev2)
URL : https://patchwork.freedesktop.org/series/34445/
State : success
== Summary ==
Blacklisted hosts:
shard-apl total:2509 pass:1582 dwarn:15 dfail:11 fail:13 skip:883 time:11204s
shard-hsw total:2643 pass:1521 dwarn:8 dfail:2 fail:8 skip:1103 time:8969s
shard-snb total:2488 pass:1213 dwarn:14 dfail:5 fail:8 skip:1244 time:7395s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7321/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs
2017-11-28 13:02 ` Chris Wilson
@ 2017-11-28 13:27 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2017-11-28 13:27 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
Quoting Chris Wilson (2017-11-28 13:02:09)
> Quoting Chris Wilson (2017-11-28 11:01:47)
> > @@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
> > intel_fbdev_unregister(dev_priv);
> > intel_audio_deinit(dev_priv);
> >
> > + /*
> > + * After flushing the fbdev (incl. a late async config which will
> > + * have delayed queuing of a hotplug event), then flush the hotplug
> > + * events.
> > + */
> > + drm_kms_helper_poll_fini(&dev_priv->drm);
>
> As discussed on irc, I'm unsure as to whether it should be fbdev
> followed by kms_helper, or the other way around. In general, I think we
> lack some serialisation to control the async hotplug event generation
> here... But I think this is sufficiently to make CI happy for the
> time being, we will see.
Fwiw, this did clear all the WARN_ON(!intel_irq_enabled()) for one CI
run. It may not be perfect, it may be "good enough".
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)
2017-11-28 13:08 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-11-28 14:37 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2017-11-28 14:37 UTC (permalink / raw)
To: Patchwork; +Cc: intel-gfx
Quoting Patchwork (2017-11-28 13:08:29)
> == Series Details ==
>
> Series: drm/i915: Enable hotplug polling after registering the outputs (rev2)
> URL : https://patchwork.freedesktop.org/series/34445/
> State : success
Maarten acked v2, so applied. At the worst it's an improvement which
we'll have to improve upon again. For now, it makes CI quieter.
Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-11-28 14:37 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 9:45 [PATCH] drm/i915: Enable hotplug polling after registering the outputs Chris Wilson
2017-11-27 10:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-27 10:18 ` [PATCH] " Maarten Lankhorst
2017-11-27 10:34 ` Chris Wilson
2017-11-28 10:33 ` Maarten Lankhorst
2017-11-27 11:14 ` ✓ Fi.CI.IGT: success for " Patchwork
2017-11-28 11:01 ` [PATCH v2] " Chris Wilson
2017-11-28 13:02 ` Chris Wilson
2017-11-28 13:27 ` Chris Wilson
2017-11-28 11:33 ` ✓ Fi.CI.BAT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2) Patchwork
2017-11-28 13:08 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-28 14:37 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.