* [PATCH] net: phy-micrel: check return code in flp center function
@ 2017-11-30 10:08 Max Uvarov
2017-12-01 20:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Max Uvarov @ 2017-11-30 10:08 UTC (permalink / raw)
To: netdev; +Cc: andrew, f.fainelli, Max Uvarov
Fix obvious typo that first return value is set but not checked.
Signed-off-by: Max Uvarov <muvarov@gmail.com>
---
drivers/net/phy/micrel.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index fdb43dd..ab46141 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -496,16 +496,18 @@ static int ksz9031_of_load_skew_values(struct phy_device *phydev,
return ksz9031_extended_write(phydev, OP_DATA, 2, reg, newval);
}
+/* Center KSZ9031RNX FLP timing at 16ms. */
static int ksz9031_center_flp_timing(struct phy_device *phydev)
{
int result;
- /* Center KSZ9031RNX FLP timing at 16ms. */
result = ksz9031_extended_write(phydev, OP_DATA, 0,
MII_KSZ9031RN_FLP_BURST_TX_HI, 0x0006);
+ if (result)
+ return result;
+
result = ksz9031_extended_write(phydev, OP_DATA, 0,
MII_KSZ9031RN_FLP_BURST_TX_LO, 0x1A80);
-
if (result)
return result;
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy-micrel: check return code in flp center function
2017-11-30 10:08 [PATCH] net: phy-micrel: check return code in flp center function Max Uvarov
@ 2017-12-01 20:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-12-01 20:17 UTC (permalink / raw)
To: muvarov; +Cc: netdev, andrew, f.fainelli
From: Max Uvarov <muvarov@gmail.com>
Date: Thu, 30 Nov 2017 13:08:29 +0300
> Fix obvious typo that first return value is set but not checked.
>
> Signed-off-by: Max Uvarov <muvarov@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-01 20:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 10:08 [PATCH] net: phy-micrel: check return code in flp center function Max Uvarov
2017-12-01 20:17 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.