* [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
@ 2017-12-01 10:10 wexu
0 siblings, 0 replies; 10+ messages in thread
From: wexu @ 2017-12-01 10:10 UTC (permalink / raw)
To: virtualization, netdev, linux-kernel; +Cc: mjrosato, wexu, mst
From: Wei Xu <wexu@redhat.com>
Matthew found a roughly 40% tcp throughput regression with commit
c67df11f(vhost_net: try batch dequing from skb array) as discussed
in the following thread:
https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
v4:
- fix zero iov iterator count in tap/tap_do_read()(Jason)
- don't put tun in case of EBADFD(Jason)
- Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
v3:
- move freeing skb from vhost to tun/tap recvmsg() to not
confuse the callers.
v2:
- add Matthew as the reporter, thanks matthew.
- moving zero headcount check ahead instead of defer consuming skb
due to jason and mst's comment.
- add freeing skb in favor of recvmsg() fails.
Wei Xu (3):
vhost: fix skb leak in handle_rx()
tun: free skb in early errors
tap: free skb if flags error
drivers/net/tap.c | 14 ++++++++++----
drivers/net/tun.c | 24 ++++++++++++++++++------
drivers/vhost/net.c | 20 ++++++++++----------
3 files changed, 38 insertions(+), 20 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
2017-12-01 10:10 wexu
@ 2017-12-03 2:32 ` David Miller
2017-12-03 2:32 ` David Miller
1 sibling, 0 replies; 10+ messages in thread
From: David Miller @ 2017-12-03 2:32 UTC (permalink / raw)
To: wexu; +Cc: virtualization, netdev, linux-kernel, jasowang, mst, mjrosato
From: wexu@redhat.com
Date: Fri, 1 Dec 2017 05:10:35 -0500
> Matthew found a roughly 40% tcp throughput regression with commit
> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> in the following thread:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
Series applied and queued up for -stable.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
@ 2017-12-03 2:32 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2017-12-03 2:32 UTC (permalink / raw)
To: wexu; +Cc: mjrosato, mst, netdev, linux-kernel, virtualization
From: wexu@redhat.com
Date: Fri, 1 Dec 2017 05:10:35 -0500
> Matthew found a roughly 40% tcp throughput regression with commit
> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> in the following thread:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
Series applied and queued up for -stable.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
2017-12-01 14:54 ` Matthew Rosato
@ 2017-12-01 14:58 ` Michael S. Tsirkin
2017-12-01 14:58 ` Michael S. Tsirkin
1 sibling, 0 replies; 10+ messages in thread
From: Michael S. Tsirkin @ 2017-12-01 14:58 UTC (permalink / raw)
To: Matthew Rosato
Cc: wexu, virtualization, netdev, linux-kernel, jasowang, David Miller
On Fri, Dec 01, 2017 at 09:54:02AM -0500, Matthew Rosato wrote:
> On 12/01/2017 09:47 AM, Michael S. Tsirkin wrote:
> > On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
> >> From: Wei Xu <wexu@redhat.com>
> >>
> >> Matthew found a roughly 40% tcp throughput regression with commit
> >> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> >> in the following thread:
> >> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
> >
> > Series
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> Tested this series on a z13 (s390x) on top of net-next using 4GB/4vcpu
> guests. Verified that both the reported TCP throughput regression and
> memory leak are resolved.
>
> net-next: 19.83 Gb/s
> net-next+: 35.02 Gb/s
>
> Thanks all!
>
> Matt
So we can also add
Tested-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
Dave, pls take this through the net tree as most changes are
in tun/tap.
Thanks!
> >
> >
> >> v4:
> >> - fix zero iov iterator count in tap/tap_do_read()(Jason)
> >> - don't put tun in case of EBADFD(Jason)
> >> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
> >>
> >> v3:
> >> - move freeing skb from vhost to tun/tap recvmsg() to not
> >> confuse the callers.
> >>
> >> v2:
> >> - add Matthew as the reporter, thanks matthew.
> >> - moving zero headcount check ahead instead of defer consuming skb
> >> due to jason and mst's comment.
> >> - add freeing skb in favor of recvmsg() fails.
> >>
> >> Wei Xu (3):
> >> vhost: fix skb leak in handle_rx()
> >> tun: free skb in early errors
> >> tap: free skb if flags error
> >>
> >> drivers/net/tap.c | 14 ++++++++++----
> >> drivers/net/tun.c | 24 ++++++++++++++++++------
> >> drivers/vhost/net.c | 20 ++++++++++----------
> >> 3 files changed, 38 insertions(+), 20 deletions(-)
> >>
> >> --
> >> 1.8.3.1
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
2017-12-01 14:54 ` Matthew Rosato
2017-12-01 14:58 ` Michael S. Tsirkin
@ 2017-12-01 14:58 ` Michael S. Tsirkin
1 sibling, 0 replies; 10+ messages in thread
From: Michael S. Tsirkin @ 2017-12-01 14:58 UTC (permalink / raw)
To: Matthew Rosato; +Cc: netdev, linux-kernel, virtualization, wexu, David Miller
On Fri, Dec 01, 2017 at 09:54:02AM -0500, Matthew Rosato wrote:
> On 12/01/2017 09:47 AM, Michael S. Tsirkin wrote:
> > On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
> >> From: Wei Xu <wexu@redhat.com>
> >>
> >> Matthew found a roughly 40% tcp throughput regression with commit
> >> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> >> in the following thread:
> >> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
> >
> > Series
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> Tested this series on a z13 (s390x) on top of net-next using 4GB/4vcpu
> guests. Verified that both the reported TCP throughput regression and
> memory leak are resolved.
>
> net-next: 19.83 Gb/s
> net-next+: 35.02 Gb/s
>
> Thanks all!
>
> Matt
So we can also add
Tested-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
Dave, pls take this through the net tree as most changes are
in tun/tap.
Thanks!
> >
> >
> >> v4:
> >> - fix zero iov iterator count in tap/tap_do_read()(Jason)
> >> - don't put tun in case of EBADFD(Jason)
> >> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
> >>
> >> v3:
> >> - move freeing skb from vhost to tun/tap recvmsg() to not
> >> confuse the callers.
> >>
> >> v2:
> >> - add Matthew as the reporter, thanks matthew.
> >> - moving zero headcount check ahead instead of defer consuming skb
> >> due to jason and mst's comment.
> >> - add freeing skb in favor of recvmsg() fails.
> >>
> >> Wei Xu (3):
> >> vhost: fix skb leak in handle_rx()
> >> tun: free skb in early errors
> >> tap: free skb if flags error
> >>
> >> drivers/net/tap.c | 14 ++++++++++----
> >> drivers/net/tun.c | 24 ++++++++++++++++++------
> >> drivers/vhost/net.c | 20 ++++++++++----------
> >> 3 files changed, 38 insertions(+), 20 deletions(-)
> >>
> >> --
> >> 1.8.3.1
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
2017-12-01 14:47 ` Michael S. Tsirkin
(?)
@ 2017-12-01 14:54 ` Matthew Rosato
2017-12-01 14:58 ` Michael S. Tsirkin
2017-12-01 14:58 ` Michael S. Tsirkin
-1 siblings, 2 replies; 10+ messages in thread
From: Matthew Rosato @ 2017-12-01 14:54 UTC (permalink / raw)
To: Michael S. Tsirkin, wexu; +Cc: virtualization, netdev, linux-kernel, jasowang
On 12/01/2017 09:47 AM, Michael S. Tsirkin wrote:
> On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
>> From: Wei Xu <wexu@redhat.com>
>>
>> Matthew found a roughly 40% tcp throughput regression with commit
>> c67df11f(vhost_net: try batch dequing from skb array) as discussed
>> in the following thread:
>> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
>
> Series
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested this series on a z13 (s390x) on top of net-next using 4GB/4vcpu
guests. Verified that both the reported TCP throughput regression and
memory leak are resolved.
net-next: 19.83 Gb/s
net-next+: 35.02 Gb/s
Thanks all!
Matt
>
>
>> v4:
>> - fix zero iov iterator count in tap/tap_do_read()(Jason)
>> - don't put tun in case of EBADFD(Jason)
>> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
>>
>> v3:
>> - move freeing skb from vhost to tun/tap recvmsg() to not
>> confuse the callers.
>>
>> v2:
>> - add Matthew as the reporter, thanks matthew.
>> - moving zero headcount check ahead instead of defer consuming skb
>> due to jason and mst's comment.
>> - add freeing skb in favor of recvmsg() fails.
>>
>> Wei Xu (3):
>> vhost: fix skb leak in handle_rx()
>> tun: free skb in early errors
>> tap: free skb if flags error
>>
>> drivers/net/tap.c | 14 ++++++++++----
>> drivers/net/tun.c | 24 ++++++++++++++++++------
>> drivers/vhost/net.c | 20 ++++++++++----------
>> 3 files changed, 38 insertions(+), 20 deletions(-)
>>
>> --
>> 1.8.3.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
2017-12-01 14:47 ` Michael S. Tsirkin
(?)
(?)
@ 2017-12-01 14:54 ` Matthew Rosato
-1 siblings, 0 replies; 10+ messages in thread
From: Matthew Rosato @ 2017-12-01 14:54 UTC (permalink / raw)
To: Michael S. Tsirkin, wexu; +Cc: netdev, linux-kernel, virtualization
On 12/01/2017 09:47 AM, Michael S. Tsirkin wrote:
> On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
>> From: Wei Xu <wexu@redhat.com>
>>
>> Matthew found a roughly 40% tcp throughput regression with commit
>> c67df11f(vhost_net: try batch dequing from skb array) as discussed
>> in the following thread:
>> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
>
> Series
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested this series on a z13 (s390x) on top of net-next using 4GB/4vcpu
guests. Verified that both the reported TCP throughput regression and
memory leak are resolved.
net-next: 19.83 Gb/s
net-next+: 35.02 Gb/s
Thanks all!
Matt
>
>
>> v4:
>> - fix zero iov iterator count in tap/tap_do_read()(Jason)
>> - don't put tun in case of EBADFD(Jason)
>> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
>>
>> v3:
>> - move freeing skb from vhost to tun/tap recvmsg() to not
>> confuse the callers.
>>
>> v2:
>> - add Matthew as the reporter, thanks matthew.
>> - moving zero headcount check ahead instead of defer consuming skb
>> due to jason and mst's comment.
>> - add freeing skb in favor of recvmsg() fails.
>>
>> Wei Xu (3):
>> vhost: fix skb leak in handle_rx()
>> tun: free skb in early errors
>> tap: free skb if flags error
>>
>> drivers/net/tap.c | 14 ++++++++++----
>> drivers/net/tun.c | 24 ++++++++++++++++++------
>> drivers/vhost/net.c | 20 ++++++++++----------
>> 3 files changed, 38 insertions(+), 20 deletions(-)
>>
>> --
>> 1.8.3.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
2017-12-01 10:10 wexu
@ 2017-12-01 14:47 ` Michael S. Tsirkin
2017-12-03 2:32 ` David Miller
1 sibling, 0 replies; 10+ messages in thread
From: Michael S. Tsirkin @ 2017-12-01 14:47 UTC (permalink / raw)
To: wexu; +Cc: virtualization, netdev, linux-kernel, jasowang, mjrosato
On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
> From: Wei Xu <wexu@redhat.com>
>
> Matthew found a roughly 40% tcp throughput regression with commit
> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> in the following thread:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
Series
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> v4:
> - fix zero iov iterator count in tap/tap_do_read()(Jason)
> - don't put tun in case of EBADFD(Jason)
> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
>
> v3:
> - move freeing skb from vhost to tun/tap recvmsg() to not
> confuse the callers.
>
> v2:
> - add Matthew as the reporter, thanks matthew.
> - moving zero headcount check ahead instead of defer consuming skb
> due to jason and mst's comment.
> - add freeing skb in favor of recvmsg() fails.
>
> Wei Xu (3):
> vhost: fix skb leak in handle_rx()
> tun: free skb in early errors
> tap: free skb if flags error
>
> drivers/net/tap.c | 14 ++++++++++----
> drivers/net/tun.c | 24 ++++++++++++++++++------
> drivers/vhost/net.c | 20 ++++++++++----------
> 3 files changed, 38 insertions(+), 20 deletions(-)
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
@ 2017-12-01 14:47 ` Michael S. Tsirkin
0 siblings, 0 replies; 10+ messages in thread
From: Michael S. Tsirkin @ 2017-12-01 14:47 UTC (permalink / raw)
To: wexu; +Cc: mjrosato, netdev, linux-kernel, virtualization
On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
> From: Wei Xu <wexu@redhat.com>
>
> Matthew found a roughly 40% tcp throughput regression with commit
> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> in the following thread:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
Series
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> v4:
> - fix zero iov iterator count in tap/tap_do_read()(Jason)
> - don't put tun in case of EBADFD(Jason)
> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
>
> v3:
> - move freeing skb from vhost to tun/tap recvmsg() to not
> confuse the callers.
>
> v2:
> - add Matthew as the reporter, thanks matthew.
> - moving zero headcount check ahead instead of defer consuming skb
> due to jason and mst's comment.
> - add freeing skb in favor of recvmsg() fails.
>
> Wei Xu (3):
> vhost: fix skb leak in handle_rx()
> tun: free skb in early errors
> tap: free skb if flags error
>
> drivers/net/tap.c | 14 ++++++++++----
> drivers/net/tun.c | 24 ++++++++++++++++++------
> drivers/vhost/net.c | 20 ++++++++++----------
> 3 files changed, 38 insertions(+), 20 deletions(-)
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
@ 2017-12-01 10:10 wexu
2017-12-01 14:47 ` Michael S. Tsirkin
2017-12-03 2:32 ` David Miller
0 siblings, 2 replies; 10+ messages in thread
From: wexu @ 2017-12-01 10:10 UTC (permalink / raw)
To: virtualization, netdev, linux-kernel; +Cc: jasowang, mst, mjrosato, wexu
From: Wei Xu <wexu@redhat.com>
Matthew found a roughly 40% tcp throughput regression with commit
c67df11f(vhost_net: try batch dequing from skb array) as discussed
in the following thread:
https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
v4:
- fix zero iov iterator count in tap/tap_do_read()(Jason)
- don't put tun in case of EBADFD(Jason)
- Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
v3:
- move freeing skb from vhost to tun/tap recvmsg() to not
confuse the callers.
v2:
- add Matthew as the reporter, thanks matthew.
- moving zero headcount check ahead instead of defer consuming skb
due to jason and mst's comment.
- add freeing skb in favor of recvmsg() fails.
Wei Xu (3):
vhost: fix skb leak in handle_rx()
tun: free skb in early errors
tap: free skb if flags error
drivers/net/tap.c | 14 ++++++++++----
drivers/net/tun.c | 24 ++++++++++++++++++------
drivers/vhost/net.c | 20 ++++++++++----------
3 files changed, 38 insertions(+), 20 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-12-03 2:32 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 10:10 [PATCH net,stable v4 0/3] vhost: fix a few skb leaks wexu
2017-12-01 10:10 wexu
2017-12-01 14:47 ` Michael S. Tsirkin
2017-12-01 14:47 ` Michael S. Tsirkin
2017-12-01 14:54 ` Matthew Rosato
2017-12-01 14:58 ` Michael S. Tsirkin
2017-12-01 14:58 ` Michael S. Tsirkin
2017-12-01 14:54 ` Matthew Rosato
2017-12-03 2:32 ` David Miller
2017-12-03 2:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.