* FAILED: patch "[PATCH] usbip: fix usbip attach to find a port that matches the" failed to apply to 4.9-stable tree
@ 2017-12-06 7:46 gregkh
2017-12-06 15:12 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: gregkh @ 2017-12-06 7:46 UTC (permalink / raw)
To: shuahkh, gregkh, juan.zea, stable; +Cc: stable
The patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
>From 1ac7c8a78be85f84b019d3d2742d1a9f07255cc5 Mon Sep 17 00:00:00 2001
From: Shuah Khan <shuahkh@osg.samsung.com>
Date: Wed, 29 Nov 2017 15:24:22 -0700
Subject: [PATCH] usbip: fix usbip attach to find a port that matches the
requested speed
usbip attach fails to find a free port when the device on the first port
is a USB_SPEED_SUPER device and non-super speed device is being attached.
It keeps checking the first port and returns without a match getting stuck
in a loop.
Fix it check to find the first port with matching speed.
Reported-by: Juan Zea <juan.zea@qindel.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/tools/usb/usbip/libsrc/vhci_driver.c b/tools/usb/usbip/libsrc/vhci_driver.c
index 5727dfb15a83..8a1cd1616de4 100644
--- a/tools/usb/usbip/libsrc/vhci_driver.c
+++ b/tools/usb/usbip/libsrc/vhci_driver.c
@@ -329,9 +329,17 @@ int usbip_vhci_refresh_device_list(void)
int usbip_vhci_get_free_port(uint32_t speed)
{
for (int i = 0; i < vhci_driver->nports; i++) {
- if (speed == USB_SPEED_SUPER &&
- vhci_driver->idev[i].hub != HUB_SPEED_SUPER)
- continue;
+
+ switch (speed) {
+ case USB_SPEED_SUPER:
+ if (vhci_driver->idev[i].hub != HUB_SPEED_SUPER)
+ continue;
+ break;
+ default:
+ if (vhci_driver->idev[i].hub != HUB_SPEED_HIGH)
+ continue;
+ break;
+ }
if (vhci_driver->idev[i].status == VDEV_ST_NULL)
return vhci_driver->idev[i].port;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: FAILED: patch "[PATCH] usbip: fix usbip attach to find a port that matches the" failed to apply to 4.9-stable tree
2017-12-06 7:46 FAILED: patch "[PATCH] usbip: fix usbip attach to find a port that matches the" failed to apply to 4.9-stable tree gregkh
@ 2017-12-06 15:12 ` Shuah Khan
2017-12-06 15:29 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2017-12-06 15:12 UTC (permalink / raw)
To: gregkh, juan.zea, stable, Shuah Khan
On 12/06/2017 12:46 AM, gregkh@linuxfoundation.org wrote:
>
> The patch below does not apply to the 4.9-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
>
This patch isn't necessary on 4.9, we are okay here. This fixes a bug
that was introduced in 4.13 release.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: FAILED: patch "[PATCH] usbip: fix usbip attach to find a port that matches the" failed to apply to 4.9-stable tree
2017-12-06 15:12 ` Shuah Khan
@ 2017-12-06 15:29 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-12-06 15:29 UTC (permalink / raw)
To: Shuah Khan; +Cc: juan.zea, stable
On Wed, Dec 06, 2017 at 08:12:25AM -0700, Shuah Khan wrote:
> On 12/06/2017 12:46 AM, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 4.9-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
>
> This patch isn't necessary on 4.9, we are okay here. This fixes a bug
> that was introduced in 4.13 release.
Ok, thanks for looking and letting me know.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 15:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 7:46 FAILED: patch "[PATCH] usbip: fix usbip attach to find a port that matches the" failed to apply to 4.9-stable tree gregkh
2017-12-06 15:12 ` Shuah Khan
2017-12-06 15:29 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.