All of lore.kernel.org
 help / color / mirror / Atom feed
From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: [Qemu-devel] [PATCH 5/8] ipmi: disable IRQ and ATN on an external disconnect
Date: Thu,  7 Dec 2017 15:30:10 -0600	[thread overview]
Message-ID: <1512682213-4354-6-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1512682213-4354-1-git-send-email-minyard@acm.org>

From: Corey Minyard <cminyard@mvista.com>

Otherwise there's no way to clear them without an external command,
and it could lock the OS in the VM if they were stuck.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
 hw/ipmi/ipmi_bmc_extern.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index abab3bb..58ade79 100644
--- a/hw/ipmi/ipmi_bmc_extern.c
+++ b/hw/ipmi/ipmi_bmc_extern.c
@@ -424,6 +424,11 @@ static void chr_event(void *opaque, int event)
             return;
         }
         ibe->connected = false;
+        /*
+         * Don't hang the OS trying to handle the ATN bit, other end will
+         * resend on a reconnect.
+         */
+        k->set_atn(s, 0, 0);
         if (ibe->waiting_rsp) {
             ibe->waiting_rsp = false;
             ibe->inbuf[1] = ibe->outbuf[1] | 0x04;
-- 
2.7.4

  parent reply	other threads:[~2017-12-07 21:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 21:30 [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 1/8] ipmi: Fix SEL get/set time commands minyard
2018-01-12 16:50   ` Marc-André Lureau
2017-12-07 21:30 ` [Qemu-devel] [PATCH 2/8] ipmi: Don't set the timestamp on add events that don't have it minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 3/8] ipmi: Add the platform event message command minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 4/8] ipmi: Fix macro issues minyard
2017-12-07 21:30 ` minyard [this message]
2018-01-12 17:00   ` [Qemu-devel] [PATCH 5/8] ipmi: disable IRQ and ATN on an external disconnect Marc-André Lureau
2017-12-07 21:30 ` [Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/ minyard
2018-01-12 17:06   ` Marc-André Lureau
2018-01-13 14:38     ` Corey Minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 7/8] ipmi: Allow BMC device properties to be set minyard
2018-01-12 17:10   ` Marc-André Lureau
2017-12-07 21:30 ` [Qemu-devel] [PATCH 8/8] Add maintainer for the IPMI code minyard
2018-01-12 17:11   ` Marc-André Lureau
2017-12-21 22:56 ` [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes Corey Minyard
2017-12-21 23:10 ` no-reply
2017-12-23 14:36   ` Corey Minyard
2017-12-25  2:43     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512682213-4354-6-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=cminyard@mvista.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.