All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Corey Minyard <minyard@acm.org>
Cc: QEMU <qemu-devel@nongnu.org>, Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH 7/8] ipmi: Allow BMC device properties to be set
Date: Fri, 12 Jan 2018 18:10:38 +0100	[thread overview]
Message-ID: <CAJ+F1CLkAfjkQZPBugjf+um1QLrpTE+-kmUTnv-b7tEv0kcsYg@mail.gmail.com> (raw)
In-Reply-To: <1512682213-4354-8-git-send-email-minyard@acm.org>

On Thu, Dec 7, 2017 at 10:30 PM,  <minyard@acm.org> wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  hw/ipmi/ipmi_bmc_sim.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index e84d710..9b509f8 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -214,8 +214,8 @@ struct IPMIBmcSim {
>      uint8_t device_rev;
>      uint8_t fwrev1;
>      uint8_t fwrev2;
> -    uint8_t mfg_id[3];
> -    uint8_t product_id[2];
> +    uint32_t mfg_id;
> +    uint16_t product_id;
>
>      uint8_t restart_cause;
>
> @@ -867,11 +867,11 @@ static void get_device_id(IPMIBmcSim *ibs,
>      rsp_buffer_push(rsp, ibs->fwrev2);
>      rsp_buffer_push(rsp, ibs->ipmi_version);
>      rsp_buffer_push(rsp, 0x07); /* sensor, SDR, and SEL. */
> -    rsp_buffer_push(rsp, ibs->mfg_id[0]);
> -    rsp_buffer_push(rsp, ibs->mfg_id[1]);
> -    rsp_buffer_push(rsp, ibs->mfg_id[2]);
> -    rsp_buffer_push(rsp, ibs->product_id[0]);
> -    rsp_buffer_push(rsp, ibs->product_id[1]);
> +    rsp_buffer_push(rsp, ibs->mfg_id & 0xff);
> +    rsp_buffer_push(rsp, (ibs->mfg_id >> 8) & 0xff);
> +    rsp_buffer_push(rsp, (ibs->mfg_id >> 16) & 0xff);
> +    rsp_buffer_push(rsp, ibs->product_id & 0xff);
> +    rsp_buffer_push(rsp, (ibs->product_id >> 8) & 0xff);
>  }
>
>  static void set_global_enables(IPMIBmcSim *ibs, uint8_t val)
> @@ -1997,6 +1997,13 @@ static Property ipmi_sim_properties[] = {
>      DEFINE_PROP_UINT16("fruareasize", IPMIBmcSim, fru.areasize, 1024),
>      DEFINE_PROP_STRING("frudatafile", IPMIBmcSim, fru.filename),
>      DEFINE_PROP_STRING("sdrfile", IPMIBmcSim, sdr_filename),
> +    DEFINE_PROP_UINT8("device_id", IPMIBmcSim, device_id, 0x20),
> +    DEFINE_PROP_UINT8("ipmi_version", IPMIBmcSim, ipmi_version, 0x02),
> +    DEFINE_PROP_UINT8("device_rev", IPMIBmcSim, device_rev, 0),
> +    DEFINE_PROP_UINT8("fwrev1", IPMIBmcSim, fwrev1, 0),
> +    DEFINE_PROP_UINT8("fwrev2", IPMIBmcSim, fwrev2, 0),
> +    DEFINE_PROP_UINT32("mfg_id", IPMIBmcSim, mfg_id, 0),
> +    DEFINE_PROP_UINT16("product_id", IPMIBmcSim, product_id, 0),
>      DEFINE_PROP_END_OF_LIST(),
>  };
>
> --
> 2.7.4
>
>



-- 
Marc-André Lureau

  reply	other threads:[~2018-01-12 17:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 21:30 [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 1/8] ipmi: Fix SEL get/set time commands minyard
2018-01-12 16:50   ` Marc-André Lureau
2017-12-07 21:30 ` [Qemu-devel] [PATCH 2/8] ipmi: Don't set the timestamp on add events that don't have it minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 3/8] ipmi: Add the platform event message command minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 4/8] ipmi: Fix macro issues minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 5/8] ipmi: disable IRQ and ATN on an external disconnect minyard
2018-01-12 17:00   ` Marc-André Lureau
2017-12-07 21:30 ` [Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/ minyard
2018-01-12 17:06   ` Marc-André Lureau
2018-01-13 14:38     ` Corey Minyard
2017-12-07 21:30 ` [Qemu-devel] [PATCH 7/8] ipmi: Allow BMC device properties to be set minyard
2018-01-12 17:10   ` Marc-André Lureau [this message]
2017-12-07 21:30 ` [Qemu-devel] [PATCH 8/8] Add maintainer for the IPMI code minyard
2018-01-12 17:11   ` Marc-André Lureau
2017-12-21 22:56 ` [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes Corey Minyard
2017-12-21 23:10 ` no-reply
2017-12-23 14:36   ` Corey Minyard
2017-12-25  2:43     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+F1CLkAfjkQZPBugjf+um1QLrpTE+-kmUTnv-b7tEv0kcsYg@mail.gmail.com \
    --to=marcandre.lureau@gmail.com \
    --cc=cminyard@mvista.com \
    --cc=minyard@acm.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.