[PATCH] mmc: block: apply NO_CMD32 quirk to an ATP card

[PATCH] mmc: block: apply NO_CMD32 quirk to an ATP card

[Christoph Fritz]

To get an ATP card work reliable on a high speed bus, CMD32 needs
to be disabled.

Without this patch:

 $ dd if=/dev/urandom of=/mnt/test bs=1M count=10

    <mmc0: starting CMD23 arg 00000400 flags 00000015>
    mmc0: starting CMD25 arg 00a71f00 flags 000000b5
    mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
    mmc0:     CMD12 arg 00000000 flags 0000049d
    sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
    mmc0: Timeout waiting for hardware interrupt.

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
 drivers/mmc/core/card.h   | 1 +
 drivers/mmc/core/quirks.h | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
index f06cd91..af9c48c 100644
--- a/drivers/mmc/core/card.h
+++ b/drivers/mmc/core/card.h
@@ -75,6 +75,7 @@ struct mmc_fixup {
 #define EXT_CSD_REV_ANY (-1u)
 
 #define CID_MANFID_SANDISK      0x2
+#define CID_MANFID_ATP          0x9
 #define CID_MANFID_TOSHIBA      0x11
 #define CID_MANFID_MICRON       0x13
 #define CID_MANFID_SAMSUNG      0x15
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index fb72593..3205f0e 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
 		  MMC_QUIRK_BLK_NO_CMD23),
 
 	/*
+	 * Some SD cards lockup while using CMD23 multiblock transfers.
+	 */
+	MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
+		  MMC_QUIRK_BLK_NO_CMD23),
+
+	/*
 	 * Some MMC cards need longer data read timeout than indicated in CSD.
 	 */
 	MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
-- 
2.1.4

[PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Christoph Fritz]

To get an ATP card work reliable on a high speed bus, CMD23 needs
to be disabled.

Without this patch:

 $ dd if=/dev/urandom of=/mnt/test bs=1M count=10

    <mmc0: starting CMD23 arg 00000400 flags 00000015>
    mmc0: starting CMD25 arg 00a71f00 flags 000000b5
    mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
    mmc0:     CMD12 arg 00000000 flags 0000049d
    sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
    mmc0: Timeout waiting for hardware interrupt.

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
Changes since v1:
 - s/CMD32/CMD23

 drivers/mmc/core/card.h   | 1 +
 drivers/mmc/core/quirks.h | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
index f06cd91..af9c48c 100644
--- a/drivers/mmc/core/card.h
+++ b/drivers/mmc/core/card.h
@@ -75,6 +75,7 @@ struct mmc_fixup {
 #define EXT_CSD_REV_ANY (-1u)
 
 #define CID_MANFID_SANDISK      0x2
+#define CID_MANFID_ATP          0x9
 #define CID_MANFID_TOSHIBA      0x11
 #define CID_MANFID_MICRON       0x13
 #define CID_MANFID_SAMSUNG      0x15
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index fb72593..3205f0e 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
 		  MMC_QUIRK_BLK_NO_CMD23),
 
 	/*
+	 * Some SD cards lockup while using CMD23 multiblock transfers.
+	 */
+	MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
+		  MMC_QUIRK_BLK_NO_CMD23),
+
+	/*
 	 * Some MMC cards need longer data read timeout than indicated in CSD.
 	 */
 	MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
-- 
2.1.4

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Ulf Hansson]

On 10 September 2017 at 01:44, Christoph Fritz <chf.fritz@googlemail.com> wrote:
> To get an ATP card work reliable on a high speed bus, CMD23 needs
> to be disabled.
>
> Without this patch:
>
>  $ dd if=/dev/urandom of=/mnt/test bs=1M count=10
>
>     <mmc0: starting CMD23 arg 00000400 flags 00000015>
>     mmc0: starting CMD25 arg 00a71f00 flags 000000b5
>     mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
>     mmc0:     CMD12 arg 00000000 flags 0000049d
>     sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
>     mmc0: Timeout waiting for hardware interrupt.

Seems like you are using some sdhci variant. Would it be possible for
you to test this card on another platform? That to make sure it's not
a driver thing.

>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
> Changes since v1:
>  - s/CMD32/CMD23
>
>  drivers/mmc/core/card.h   | 1 +
>  drivers/mmc/core/quirks.h | 6 ++++++
>  2 files changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
> index f06cd91..af9c48c 100644
> --- a/drivers/mmc/core/card.h
> +++ b/drivers/mmc/core/card.h
> @@ -75,6 +75,7 @@ struct mmc_fixup {
>  #define EXT_CSD_REV_ANY (-1u)
>
>  #define CID_MANFID_SANDISK      0x2
> +#define CID_MANFID_ATP          0x9
>  #define CID_MANFID_TOSHIBA      0x11
>  #define CID_MANFID_MICRON       0x13
>  #define CID_MANFID_SAMSUNG      0x15
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> index fb72593..3205f0e 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
>                   MMC_QUIRK_BLK_NO_CMD23),
>
>         /*
> +        * Some SD cards lockup while using CMD23 multiblock transfers.
> +        */
> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
> +                 MMC_QUIRK_BLK_NO_CMD23),

Is really all ATP cards having this problem? Perhaps we should
consider making this a bit more fine grained?

On the other hand, this may be the safest way to do it...

> +
> +       /*
>          * Some MMC cards need longer data read timeout than indicated in CSD.
>          */
>         MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
> --
> 2.1.4
>

Kind regards
Uffe

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Shawn Lin]

Hi

On 2017/9/22 16:42, Ulf Hansson wrote:
> On 10 September 2017 at 01:44, Christoph Fritz <chf.fritz@googlemail.com> wrote:
>> To get an ATP card work reliable on a high speed bus, CMD23 needs
>> to be disabled.
>>
>> Without this patch:
>>
>>   $ dd if=/dev/urandom of=/mnt/test bs=1M count=10
>>
>>      <mmc0: starting CMD23 arg 00000400 flags 00000015>
>>      mmc0: starting CMD25 arg 00a71f00 flags 000000b5
>>      mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
>>      mmc0:     CMD12 arg 00000000 flags 0000049d
>>      sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
>>      mmc0: Timeout waiting for hardware interrupt.
> 
> Seems like you are using some sdhci variant. Would it be possible for
> you to test this card on another platform? That to make sure it's not
> a driver thing.
> 

I'm just curious about if these ATP cards could work for ACMD23?

Could you kindly try this patch?

|https://patchwork.kernel.org/patch/9887651/


>>
>> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
>> ---
>> Changes since v1:
>>   - s/CMD32/CMD23
>>
>>   drivers/mmc/core/card.h   | 1 +
>>   drivers/mmc/core/quirks.h | 6 ++++++
>>   2 files changed, 7 insertions(+)
>>
>> diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
>> index f06cd91..af9c48c 100644
>> --- a/drivers/mmc/core/card.h
>> +++ b/drivers/mmc/core/card.h
>> @@ -75,6 +75,7 @@ struct mmc_fixup {
>>   #define EXT_CSD_REV_ANY (-1u)
>>
>>   #define CID_MANFID_SANDISK      0x2
>> +#define CID_MANFID_ATP          0x9
>>   #define CID_MANFID_TOSHIBA      0x11
>>   #define CID_MANFID_MICRON       0x13
>>   #define CID_MANFID_SAMSUNG      0x15
>> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
>> index fb72593..3205f0e 100644
>> --- a/drivers/mmc/core/quirks.h
>> +++ b/drivers/mmc/core/quirks.h
>> @@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
>>                    MMC_QUIRK_BLK_NO_CMD23),
>>
>>          /*
>> +        * Some SD cards lockup while using CMD23 multiblock transfers.
>> +        */
>> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
>> +                 MMC_QUIRK_BLK_NO_CMD23),
> 
> Is really all ATP cards having this problem? Perhaps we should
> consider making this a bit more fine grained?
> 
> On the other hand, this may be the safest way to do it...
> 
>> +
>> +       /*
>>           * Some MMC cards need longer data read timeout than indicated in CSD.
>>           */
>>          MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
>> --
>> 2.1.4
>>
> 
> Kind regards
> Uffe
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Christoph Fritz]

Hi Ulf and Shawn,

 thanks for your input, I'm replying to both of you by this mail, please
see comments below.

On Fri, 2017-09-22 at 17:26 +0800, Shawn Lin wrote:
> Hi
> 
> On 2017/9/22 16:42, Ulf Hansson wrote:
> > On 10 September 2017 at 01:44, Christoph Fritz <chf.fritz@googlemail.com> wrote:
> >> To get an ATP card work reliable on a high speed bus, CMD23 needs
> >> to be disabled.
> >>
> >> Without this patch:
> >>
> >>   $ dd if=/dev/urandom of=/mnt/test bs=1M count=10
> >>
> >>      <mmc0: starting CMD23 arg 00000400 flags 00000015>
> >>      mmc0: starting CMD25 arg 00a71f00 flags 000000b5
> >>      mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
> >>      mmc0:     CMD12 arg 00000000 flags 0000049d
> >>      sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
> >>      mmc0: Timeout waiting for hardware interrupt.
> > 
> > Seems like you are using some sdhci variant. Would it be possible for
> > you to test this card on another platform? That to make sure it's not
> > a driver thing.

SoC am335x (omap_hsmmc) works fine because it lacks CMD23 host support.
My RK3288 board supports only micro-SD cards. If you want me to, I could
get an adapter (micro-SD -> SD) but the shipping takes ~40 days.

> > 
> 
> I'm just curious about if these ATP cards could work for ACMD23?
> 
> Could you kindly try this patch?
> 
> |https://patchwork.kernel.org/patch/9887651/

By looking at your patch I can see that bool variable 'need_acmd23' is
only set when card does not support CMD23. But here this card (falsely)
claims to support CMD23, which is the whole point of the NO_CMD23 quirk.

So testing your patch would not make any difference, because its
functionality would be disabled, or do I miss something?

> 
> 
> >>
> >> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> >> ---
> >> Changes since v1:
> >>   - s/CMD32/CMD23
> >>
> >>   drivers/mmc/core/card.h   | 1 +
> >>   drivers/mmc/core/quirks.h | 6 ++++++
> >>   2 files changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
> >> index f06cd91..af9c48c 100644
> >> --- a/drivers/mmc/core/card.h
> >> +++ b/drivers/mmc/core/card.h
> >> @@ -75,6 +75,7 @@ struct mmc_fixup {
> >>   #define EXT_CSD_REV_ANY (-1u)
> >>
> >>   #define CID_MANFID_SANDISK      0x2
> >> +#define CID_MANFID_ATP          0x9
> >>   #define CID_MANFID_TOSHIBA      0x11
> >>   #define CID_MANFID_MICRON       0x13
> >>   #define CID_MANFID_SAMSUNG      0x15
> >> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> >> index fb72593..3205f0e 100644
> >> --- a/drivers/mmc/core/quirks.h
> >> +++ b/drivers/mmc/core/quirks.h
> >> @@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
> >>                    MMC_QUIRK_BLK_NO_CMD23),
> >>
> >>          /*
> >> +        * Some SD cards lockup while using CMD23 multiblock transfers.
> >> +        */
> >> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
> >> +                 MMC_QUIRK_BLK_NO_CMD23),
> > 
> > Is really all ATP cards having this problem? Perhaps we should
> > consider making this a bit more fine grained?
> > 
> > On the other hand, this may be the safest way to do it...

I also thought about this and set CID_OEMID_ANY because I wanted to be
on the safe side. Maybe ATP can comment on this (in CC)?

Thanks
 -- Christoph

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Shawn Lin]

Hi，

On 2017/9/24 3:51, Christoph Fritz wrote:
> Hi Ulf and Shawn,
> 
>   thanks for your input, I'm replying to both of you by this mail, please
> see comments below.
> 
> On Fri, 2017-09-22 at 17:26 +0800, Shawn Lin wrote:
>> Hi
>>
>> On 2017/9/22 16:42, Ulf Hansson wrote:
>>> On 10 September 2017 at 01:44, Christoph Fritz <chf.fritz@googlemail.com> wrote:
>>>> To get an ATP card work reliable on a high speed bus, CMD23 needs
>>>> to be disabled.
>>>>
>>>> Without this patch:
>>>>
>>>>    $ dd if=/dev/urandom of=/mnt/test bs=1M count=10
>>>>
>>>>       <mmc0: starting CMD23 arg 00000400 flags 00000015>
>>>>       mmc0: starting CMD25 arg 00a71f00 flags 000000b5
>>>>       mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
>>>>       mmc0:     CMD12 arg 00000000 flags 0000049d
>>>>       sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
>>>>       mmc0: Timeout waiting for hardware interrupt.
>>>
>>> Seems like you are using some sdhci variant. Would it be possible for
>>> you to test this card on another platform? That to make sure it's not
>>> a driver thing.
> 
> SoC am335x (omap_hsmmc) works fine because it lacks CMD23 host support.
> My RK3288 board supports only micro-SD cards. If you want me to, I could
> get an adapter (micro-SD -> SD) but the shipping takes ~40 days.
> 
>>>
>>
>> I'm just curious about if these ATP cards could work for ACMD23?
>>
>> Could you kindly try this patch?
>>
>> |https://patchwork.kernel.org/patch/9887651/
> 
> By looking at your patch I can see that bool variable 'need_acmd23' is
> only set when card does not support CMD23. But here this card (falsely)
> claims to support CMD23, which is the whole point of the NO_CMD23 quirk.
> 
> So testing your patch would not make any difference, because its

yup, sorry fot that. I mean you could hack it a little to mask
CMD23 support and let ACMD23 take effect, and see how it would
go?

> functionality would be disabled, or do I miss something?
> 
>>
>>
>>>>
>>>> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
>>>> ---
>>>> Changes since v1:
>>>>    - s/CMD32/CMD23
>>>>
>>>>    drivers/mmc/core/card.h   | 1 +
>>>>    drivers/mmc/core/quirks.h | 6 ++++++
>>>>    2 files changed, 7 insertions(+)
>>>>
>>>> diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
>>>> index f06cd91..af9c48c 100644
>>>> --- a/drivers/mmc/core/card.h
>>>> +++ b/drivers/mmc/core/card.h
>>>> @@ -75,6 +75,7 @@ struct mmc_fixup {
>>>>    #define EXT_CSD_REV_ANY (-1u)
>>>>
>>>>    #define CID_MANFID_SANDISK      0x2
>>>> +#define CID_MANFID_ATP          0x9
>>>>    #define CID_MANFID_TOSHIBA      0x11
>>>>    #define CID_MANFID_MICRON       0x13
>>>>    #define CID_MANFID_SAMSUNG      0x15
>>>> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
>>>> index fb72593..3205f0e 100644
>>>> --- a/drivers/mmc/core/quirks.h
>>>> +++ b/drivers/mmc/core/quirks.h
>>>> @@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
>>>>                     MMC_QUIRK_BLK_NO_CMD23),
>>>>
>>>>           /*
>>>> +        * Some SD cards lockup while using CMD23 multiblock transfers.
>>>> +        */
>>>> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
>>>> +                 MMC_QUIRK_BLK_NO_CMD23),
>>>
>>> Is really all ATP cards having this problem? Perhaps we should
>>> consider making this a bit more fine grained?
>>>
>>> On the other hand, this may be the safest way to do it...
> 
> I also thought about this and set CID_OEMID_ANY because I wanted to be
> on the safe side. Maybe ATP can comment on this (in CC)?
> 
> Thanks
>   -- Christoph
> 
> 
> 
> 

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Christoph Fritz]

On Mon, 2017-09-25 at 11:33 +0800, Shawn Lin wrote:
> >> I'm just curious about if these ATP cards could work for ACMD23?
> >>
> >> Could you kindly try this patch?
> >>
> >> |https://patchwork.kernel.org/patch/9887651/
> > 
> > By looking at your patch I can see that bool variable 'need_acmd23' is
> > only set when card does not support CMD23. But here this card (falsely)
> > claims to support CMD23, which is the whole point of the NO_CMD23 quirk.
> > 
> > So testing your patch would not make any difference, because its
> 
> yup, sorry fot that. I mean you could hack it a little to mask
> CMD23 support and let ACMD23 take effect, and see how it would
> go?

forcing ACMD23 instead of CMD23 works fine:

dd if=/dev/urandom of=/mnt/test bs=1M count=100 conv=fsync
100+0 records in
100+0 records out
104857600 bytes (105 MB) copied, 9.9496 s, 10.5 MB/s

It's as fast as using my NO_CMD23 quirk.

> >>>>           /*
> >>>> +        * Some SD cards lockup while using CMD23 multiblock transfers.
> >>>> +        */
> >>>> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
> >>>> +                 MMC_QUIRK_BLK_NO_CMD23),
> >>>
> >>> Is really all ATP cards having this problem? Perhaps we should
> >>> consider making this a bit more fine grained?
> >>>
> >>> On the other hand, this may be the safest way to do it...
> > 
> > I also thought about this and set CID_OEMID_ANY because I wanted to be
> > on the safe side. Maybe ATP can comment on this (in CC)?

Thanks
 -- Christoph

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Shawn Lin]

On 2017/9/25 19:23, Christoph Fritz wrote:
> On Mon, 2017-09-25 at 11:33 +0800, Shawn Lin wrote:
>>>> I'm just curious about if these ATP cards could work for ACMD23?
>>>>
>>>> Could you kindly try this patch?
>>>>
>>>> |https://patchwork.kernel.org/patch/9887651/
>>>
>>> By looking at your patch I can see that bool variable 'need_acmd23' is
>>> only set when card does not support CMD23. But here this card (falsely)
>>> claims to support CMD23, which is the whole point of the NO_CMD23 quirk.
>>>
>>> So testing your patch would not make any difference, because its
>>
>> yup, sorry fot that. I mean you could hack it a little to mask
>> CMD23 support and let ACMD23 take effect, and see how it would
>> go?
> 
> forcing ACMD23 instead of CMD23 works fine:
> 
> dd if=/dev/urandom of=/mnt/test bs=1M count=100 conv=fsync
> 100+0 records in
> 100+0 records out
> 104857600 bytes (105 MB) copied, 9.9496 s, 10.5 MB/s
> 
> It's as fast as using my NO_CMD23 quirk.

Thanks for the test. Given that ACMD23 is mandatory but very few sd
cards claim to support CMD23, maybe force ACMD23 support is better than
current CMD23/open-ending combo.

Back to $subject patch, It still need to verify this conclusion on other
platforms or get acknowledgement from the vendor.




> 
>>>>>>            /*
>>>>>> +        * Some SD cards lockup while using CMD23 multiblock transfers.
>>>>>> +        */
>>>>>> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
>>>>>> +                 MMC_QUIRK_BLK_NO_CMD23),
>>>>>
>>>>> Is really all ATP cards having this problem? Perhaps we should
>>>>> consider making this a bit more fine grained?
>>>>>
>>>>> On the other hand, this may be the safest way to do it...
>>>
>>> I also thought about this and set CID_OEMID_ANY because I wanted to be
>>> on the safe side. Maybe ATP can comment on this (in CC)?
> 
> Thanks
>   -- Christoph
> 
> 
> 
> 

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Christoph Fritz]

Hi Shawn and Ulf

On Tue, 2017-09-26 at 08:56 +0800, Shawn Lin wrote:
> Back to $subject patch, It still need to verify this conclusion on other
> platforms or get acknowledgement from the vendor.

to quote myself:

On Sat, 2017-09-23 at 21:51 +0200, Christoph Fritz wrote:
> > SoC am335x (omap_hsmmc) works fine because it lacks CMD23 host support.
> > My RK3288 board supports only micro-SD cards. If you want me to, I could
> > get an adapter (micro-SD -> SD) but the shipping takes ~40 days.

Finally I got this microSD to SD adapter to test the ATP card on RK3288
platform too. As expected, card fails without the patch:

 $ dd if=/dev/urandom of=./test bs=1M count=10

does freeze system without any response

So I can verify failing CMD23 behaviour on imx6 and rk3288 running
kernel 4.14. Applying the patch does fix the issue on both platforms.

Could you queue up this patch now?

Thanks
  -- Christoph

Re: [PATCH v2] mmc: core: apply NO_CMD23 quirk to an ATP card

[Christoph Fritz]

On Mon, 2017-12-04 at 14:38 +0100, Christoph Fritz wrote:
> Finally I got this microSD to SD adapter to test the ATP card on RK3288
> platform too. As expected, card fails without the patch:
> 
>  $ dd if=/dev/urandom of=./test bs=1M count=10
> 
> does freeze system without any response
> 
> So I can verify failing CMD23 behaviour on imx6 and rk3288 running
> kernel 4.14. Applying the patch does fix the issue on both platforms.
> 
> Could you queue up this patch now?

*ping*

Meanwhile I found another card which fails CMD23 by testing it on rk3288
and i.MX6.

I'll send a patch for both cards as v3 of this Patch.

best regards
 -- Christoph

[PATCH v3] mmc: core: apply NO_CMD23 quirk to some specific cards

[Christoph Fritz]

To get an usdhc Apacer and some ATP SD cards work reliable, CMD23 needs
to be disabled.  This has been tested on i.MX6 (sdhci-esdhc) and rk3288
(dw_mmc-rockchip).

Without this patch on i.MX6 (sdhci-esdhc):

 $ dd if=/dev/urandom of=/mnt/test bs=1M count=10 conv=fsync

    | <mmc0: starting CMD23 arg 00000400 flags 00000015>
    | mmc0: starting CMD25 arg 00a71f00 flags 000000b5
    | mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
    | mmc0:     CMD12 arg 00000000 flags 0000049d
    | sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
    | mmc0: Timeout waiting for hardware interrupt.

Without this patch on rk3288 (dw_mmc-rockchip):

    | mmc1: Card stuck in programming state! mmcblk1 card_busy_detect
    | dwmmc_rockchip ff0c0000.dwmmc: Busy; trying anyway
    | mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz,
    | actual 400000HZ div = 0)
    | mmc1: card never left busy state
    | mmc1: tried to reset card, got error -110
    | blk_update_request: I/O error, dev mmcblk1, sector 139778
    | Buffer I/O error on dev mmcblk1p1, logical block 131586, lost async
    | page write

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
Changes since v1:
 - s/CMD32/CMD23
Changes since v2:
 - add an Apacer card
 - adapt comment

 drivers/mmc/core/card.h   | 2 ++
 drivers/mmc/core/quirks.h | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
index f06cd91..79a5b98 100644
--- a/drivers/mmc/core/card.h
+++ b/drivers/mmc/core/card.h
@@ -75,9 +75,11 @@ struct mmc_fixup {
 #define EXT_CSD_REV_ANY (-1u)
 
 #define CID_MANFID_SANDISK      0x2
+#define CID_MANFID_ATP          0x9
 #define CID_MANFID_TOSHIBA      0x11
 #define CID_MANFID_MICRON       0x13
 #define CID_MANFID_SAMSUNG      0x15
+#define CID_MANFID_APACER       0x27
 #define CID_MANFID_KINGSTON     0x70
 #define CID_MANFID_HYNIX	0x90
 
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index 9107f0b..d4ff9d8 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc/core/quirks.h
@@ -53,6 +53,14 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
 		  MMC_QUIRK_BLK_NO_CMD23),
 
 	/*
+	 * Some SD cards lockup while using CMD23 multiblock transfers.
+	 */
+	MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
+		  MMC_QUIRK_BLK_NO_CMD23),
+	MMC_FIXUP("APUSD", CID_MANFID_APACER, 0x5048, add_quirk_sd,
+		  MMC_QUIRK_BLK_NO_CMD23),
+
+	/*
 	 * Some MMC cards need longer data read timeout than indicated in CSD.
 	 */
 	MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
-- 
2.1.4

Re: [PATCH v3] mmc: core: apply NO_CMD23 quirk to some specific cards

[Ulf Hansson]

On 9 December 2017 at 23:47, Christoph Fritz <chf.fritz@googlemail.com> wrote:
> To get an usdhc Apacer and some ATP SD cards work reliable, CMD23 needs
> to be disabled.  This has been tested on i.MX6 (sdhci-esdhc) and rk3288
> (dw_mmc-rockchip).
>
> Without this patch on i.MX6 (sdhci-esdhc):
>
>  $ dd if=/dev/urandom of=/mnt/test bs=1M count=10 conv=fsync
>
>     | <mmc0: starting CMD23 arg 00000400 flags 00000015>
>     | mmc0: starting CMD25 arg 00a71f00 flags 000000b5
>     | mmc0:     blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0
>     | mmc0:     CMD12 arg 00000000 flags 0000049d
>     | sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001
>     | mmc0: Timeout waiting for hardware interrupt.
>
> Without this patch on rk3288 (dw_mmc-rockchip):
>
>     | mmc1: Card stuck in programming state! mmcblk1 card_busy_detect
>     | dwmmc_rockchip ff0c0000.dwmmc: Busy; trying anyway
>     | mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz,
>     | actual 400000HZ div = 0)
>     | mmc1: card never left busy state
>     | mmc1: tried to reset card, got error -110
>     | blk_update_request: I/O error, dev mmcblk1, sector 139778
>     | Buffer I/O error on dev mmcblk1p1, logical block 131586, lost async
>     | page write
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>

Thanks, applied for fixes and added a stable tag (4.14+, since the
patch didn't apply to earlier versions).

If/when Shawn find some time to re-spin his series, adding support for
ACMD23 [1], we may be able to revert this change. Let's see.

However, using the quirks as a fix for stable is certainly a good approach.

Kind regards
Uffe

> ---
> Changes since v1:
>  - s/CMD32/CMD23
> Changes since v2:
>  - add an Apacer card
>  - adapt comment
>
>  drivers/mmc/core/card.h   | 2 ++
>  drivers/mmc/core/quirks.h | 8 ++++++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h
> index f06cd91..79a5b98 100644
> --- a/drivers/mmc/core/card.h
> +++ b/drivers/mmc/core/card.h
> @@ -75,9 +75,11 @@ struct mmc_fixup {
>  #define EXT_CSD_REV_ANY (-1u)
>
>  #define CID_MANFID_SANDISK      0x2
> +#define CID_MANFID_ATP          0x9
>  #define CID_MANFID_TOSHIBA      0x11
>  #define CID_MANFID_MICRON       0x13
>  #define CID_MANFID_SAMSUNG      0x15
> +#define CID_MANFID_APACER       0x27
>  #define CID_MANFID_KINGSTON     0x70
>  #define CID_MANFID_HYNIX       0x90
>
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> index 9107f0b..d4ff9d8 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -53,6 +53,14 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
>                   MMC_QUIRK_BLK_NO_CMD23),
>
>         /*
> +        * Some SD cards lockup while using CMD23 multiblock transfers.
> +        */
> +       MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd,
> +                 MMC_QUIRK_BLK_NO_CMD23),
> +       MMC_FIXUP("APUSD", CID_MANFID_APACER, 0x5048, add_quirk_sd,
> +                 MMC_QUIRK_BLK_NO_CMD23),
> +
> +       /*
>          * Some MMC cards need longer data read timeout than indicated in CSD.
>          */
>         MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc,
> --
> 2.1.4
>

Re: [PATCH v3] mmc: core: apply NO_CMD23 quirk to some specific cards

[Christoph Fritz]

On Mon, 2017-12-11 at 14:00 +0100, Ulf Hansson wrote:
> If/when Shawn find some time to re-spin his series, adding support for
> ACMD23 [1], we may be able to revert this change. Let's see.

If you or Shawn want me to test then again, please give me a head up.

> However, using the quirks as a fix for stable is certainly a good approach.

Thanks
 -- Christoph