All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Sriram Periyasamy <sriramx.periyasamy@intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
	Senthilnathan Veppur <senthilnathanx.veppur@intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: Skylake: Re-order some code to silence a warning
Date: Mon, 11 Dec 2017 11:54:03 +0000	[thread overview]
Message-ID: <1512993243.25007.592.camel@linux.intel.com> (raw)
In-Reply-To: <20171211113345.ubl7rj7ftt62ox5s@mwanda>

On Mon, 2017-12-11 at 14:33 +0300, Dan Carpenter wrote:
> On Mon, Dec 11, 2017 at 01:20:23PM +0200, Andy Shevchenko wrote:
> > On Fri, 2017-12-08 at 14:54 +0300, Dan Carpenter wrote:
> > > 
> 


> I didn't like the way the code was written either but it's impossible
> to know how much change people are going to accept.  Even though I
> think
> that extra parenthesis shouldn't have been there, the original author
> felt they helped, so I try to be accomodating...
> 
> Anyway, I can resend.

Since Vinod ACKed this change, I'm fine with it.
Consider my comment as JFYI.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Sriram Periyasamy <sriramx.periyasamy@intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Guneshwor Singh <guneshwor.o.singh@intel.com>,
	Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
	Senthilnathan Veppur <senthilnathanx.veppur@intel.com>,
	Vinod Koul <vinod.koul@intel.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: Skylake: Re-order some code to silence a warning
Date: Mon, 11 Dec 2017 13:54:03 +0200	[thread overview]
Message-ID: <1512993243.25007.592.camel@linux.intel.com> (raw)
In-Reply-To: <20171211113345.ubl7rj7ftt62ox5s@mwanda>

On Mon, 2017-12-11 at 14:33 +0300, Dan Carpenter wrote:
> On Mon, Dec 11, 2017 at 01:20:23PM +0200, Andy Shevchenko wrote:
> > On Fri, 2017-12-08 at 14:54 +0300, Dan Carpenter wrote:
> > > 
> 


> I didn't like the way the code was written either but it's impossible
> to know how much change people are going to accept.  Even though I
> think
> that extra parenthesis shouldn't have been there, the original author
> felt they helped, so I try to be accomodating...
> 
> Anyway, I can resend.

Since Vinod ACKed this change, I'm fine with it.
Consider my comment as JFYI.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-12-11 11:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 11:54 [PATCH] ASoC: Intel: Skylake: Re-order some code to silence a warning Dan Carpenter
2017-12-08 11:54 ` Dan Carpenter
2017-12-11 10:39 ` Vinod Koul
2017-12-11 10:51   ` Vinod Koul
2017-12-11 10:33   ` Sriram Periyasamy
2017-12-11 10:45     ` Sriram Periyasamy
2017-12-11 11:20 ` Andy Shevchenko
2017-12-11 11:20   ` Andy Shevchenko
2017-12-11 11:33   ` Dan Carpenter
2017-12-11 11:33     ` Dan Carpenter
2017-12-11 11:54     ` Andy Shevchenko [this message]
2017-12-11 11:54       ` Andy Shevchenko
2017-12-11 12:13 ` Applied "ASoC: Intel: Skylake: Re-order some code to silence a warning" to the asoc tree Mark Brown
2017-12-11 12:13   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512993243.25007.592.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=guneshwor.o.singh@intel.com \
    --cc=jani.nikula@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=pankaj.laxminarayan.bharadiya@intel.com \
    --cc=perex@perex.cz \
    --cc=senthilnathanx.veppur@intel.com \
    --cc=sriramx.periyasamy@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=tiwai@suse.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.