All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuval Mintz <yuvalm@mellanox.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: mlxsw@mellanox.com, Yuval Mintz <yuvalm@mellanox.com>
Subject: [PATCH net 0/3] net: sched: Make qdisc offload uapi uniform
Date: Thu, 14 Dec 2017 15:54:28 +0200	[thread overview]
Message-ID: <1513259671-1183-1-git-send-email-yuvalm@mellanox.com> (raw)

Several qdiscs can already be offloaded to hardware, but there's an
inconsistecy in regard to the uapi through which they indicate such
an offload is taking place - indication is passed to the user via
TCA_OPTIONS where each qdisc retains private logic for setting it.

The recent addition of offloading to RED in
602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc") caused
the addition of yet another uapi field for this purpose -
TC_RED_OFFLOADED.

For clarity and prevention of bloat in the uapi we want to eliminate
said added uapi, replacing it with a common mechanism that can be used
to reflect offload status of the various qdiscs.

The first patch introduces TCA_HW_OFFLOAD as the generic message meant
for this purpose. The second changes the current RED implementation into
setting the internal bits necessary for passing it, and the third removes
TC_RED_OFFLOADED as its no longer needed.

Dave,

A bit unorthodox as it's not a fix per-se, but it's the last chance
for killing the unneeded uapi and replacing it with something better
before getting stuck with it forever.

Cheers,
Yuval

Yuval Mintz (3):
  net: sched: Add TCA_HW_OFFLOAD
  net: sched: Move to new offload indication in RED
  pkt_sched: Remove TC_RED_OFFLOADED from uapi

 include/net/sch_generic.h      |  1 +
 include/uapi/linux/pkt_sched.h |  1 -
 include/uapi/linux/rtnetlink.h |  1 +
 net/sched/sch_api.c            |  2 ++
 net/sched/sch_red.c            | 31 +++++++++++++++----------------
 5 files changed, 19 insertions(+), 17 deletions(-)

-- 
2.4.3

             reply	other threads:[~2017-12-14 13:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 13:54 Yuval Mintz [this message]
2017-12-14 13:54 ` [PATCH net 1/3] net: sched: Add TCA_HW_OFFLOAD Yuval Mintz
2017-12-14 14:04   ` Jiri Pirko
2017-12-14 13:54 ` [PATCH net 2/3] net: sched: Move to new offload indication in RED Yuval Mintz
2017-12-14 14:07   ` Jiri Pirko
2017-12-14 13:54 ` [PATCH net 3/3] pkt_sched: Remove TC_RED_OFFLOADED from uapi Yuval Mintz
2017-12-14 14:07   ` Jiri Pirko
2017-12-15 18:36 ` [PATCH net 0/3] net: sched: Make qdisc offload uapi uniform David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513259671-1183-1-git-send-email-yuvalm@mellanox.com \
    --to=yuvalm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.