All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yuvalm@mellanox.com
Cc: netdev@vger.kernel.org, mlxsw@mellanox.com
Subject: Re: [PATCH net 0/3] net: sched: Make qdisc offload uapi uniform
Date: Fri, 15 Dec 2017 13:36:24 -0500 (EST)	[thread overview]
Message-ID: <20171215.133624.909968538603448658.davem@davemloft.net> (raw)
In-Reply-To: <1513259671-1183-1-git-send-email-yuvalm@mellanox.com>

From: Yuval Mintz <yuvalm@mellanox.com>
Date: Thu, 14 Dec 2017 15:54:28 +0200

> Several qdiscs can already be offloaded to hardware, but there's an
> inconsistecy in regard to the uapi through which they indicate such
> an offload is taking place - indication is passed to the user via
> TCA_OPTIONS where each qdisc retains private logic for setting it.
> 
> The recent addition of offloading to RED in
> 602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc") caused
> the addition of yet another uapi field for this purpose -
> TC_RED_OFFLOADED.
> 
> For clarity and prevention of bloat in the uapi we want to eliminate
> said added uapi, replacing it with a common mechanism that can be used
> to reflect offload status of the various qdiscs.
> 
> The first patch introduces TCA_HW_OFFLOAD as the generic message meant
> for this purpose. The second changes the current RED implementation into
> setting the internal bits necessary for passing it, and the third removes
> TC_RED_OFFLOADED as its no longer needed.
> 
> Dave,
> 
> A bit unorthodox as it's not a fix per-se, but it's the last chance
> for killing the unneeded uapi and replacing it with something better
> before getting stuck with it forever.

I agree, let's take care of this now while we can.

Series applied, thanks.

      parent reply	other threads:[~2017-12-15 18:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 13:54 [PATCH net 0/3] net: sched: Make qdisc offload uapi uniform Yuval Mintz
2017-12-14 13:54 ` [PATCH net 1/3] net: sched: Add TCA_HW_OFFLOAD Yuval Mintz
2017-12-14 14:04   ` Jiri Pirko
2017-12-14 13:54 ` [PATCH net 2/3] net: sched: Move to new offload indication in RED Yuval Mintz
2017-12-14 14:07   ` Jiri Pirko
2017-12-14 13:54 ` [PATCH net 3/3] pkt_sched: Remove TC_RED_OFFLOADED from uapi Yuval Mintz
2017-12-14 14:07   ` Jiri Pirko
2017-12-15 18:36 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215.133624.909968538603448658.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=yuvalm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.