* [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check
@ 2017-12-18 13:02 Fabio Estevam
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
` (6 more replies)
0 siblings, 7 replies; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index d9cca4f..5db4cbb 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -860,9 +860,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
if (!plat_data->base) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return ERR_PTR(-ENODEV);
-
dsi->base = devm_ioremap_resource(dev, res);
if (IS_ERR(dsi->base))
return ERR_PTR(-ENODEV);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/7] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
@ 2017-12-18 13:02 ` Fabio Estevam
2017-12-18 13:28 ` Andrzej Hajda
2017-12-18 23:44 ` Inki Dae
2017-12-18 13:02 ` [PATCH 3/7] drm/rockchip: dsi: " Fabio Estevam
` (5 subsequent siblings)
6 siblings, 2 replies; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 6be5b53..1d509a8 100644
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -744,11 +744,6 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(dev, "cannot find IO resource\n");
- return -ENXIO;
- }
-
ctx->addr = devm_ioremap_resource(dev, res);
if (IS_ERR(ctx->addr)) {
dev_err(dev, "ioremap failed\n");
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/7] drm/rockchip: dsi: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
@ 2017-12-18 13:02 ` Fabio Estevam
2017-12-18 13:02 ` [PATCH 4/7] drm/rockchip: inno_hdmi: " Fabio Estevam
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Heiko Stübner <heiko@sntech.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index b1fe063..591953c 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -1202,9 +1202,6 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master,
return ret;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
-
dsi->base = devm_ioremap_resource(dev, res);
if (IS_ERR(dsi->base))
return PTR_ERR(dsi->base);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/7] drm/rockchip: inno_hdmi: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
2017-12-18 13:02 ` [PATCH 3/7] drm/rockchip: dsi: " Fabio Estevam
@ 2017-12-18 13:02 ` Fabio Estevam
2017-12-18 13:02 ` [PATCH 5/7] drm/stm: dsi: " Fabio Estevam
` (3 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Heiko Stübner <heiko@sntech.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index fab30927..f6ad487 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -831,9 +831,6 @@ static int inno_hdmi_bind(struct device *dev, struct device *master,
hdmi->drm_dev = drm;
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!iores)
- return -ENXIO;
-
hdmi->regs = devm_ioremap_resource(dev, iores);
if (IS_ERR(hdmi->regs))
return PTR_ERR(hdmi->regs);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 5/7] drm/stm: dsi: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
` (2 preceding siblings ...)
2017-12-18 13:02 ` [PATCH 4/7] drm/rockchip: inno_hdmi: " Fabio Estevam
@ 2017-12-18 13:02 ` Fabio Estevam
2017-12-19 14:14 ` Philippe CORNU
2017-12-18 13:02 ` [PATCH 6/7] drm/stm: ltdc: " Fabio Estevam
` (2 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, Philippe Cornu, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Philippe Cornu <philippe.cornu@st.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index 82dcb20..fd02506 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -290,11 +290,6 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- DRM_ERROR("Unable to get resource\n");
- return -ENODEV;
- }
-
dsi->base = devm_ioremap_resource(dev, res);
if (IS_ERR(dsi->base)) {
DRM_ERROR("Unable to get dsi registers\n");
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 6/7] drm/stm: ltdc: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
` (3 preceding siblings ...)
2017-12-18 13:02 ` [PATCH 5/7] drm/stm: dsi: " Fabio Estevam
@ 2017-12-18 13:02 ` Fabio Estevam
2017-12-19 14:15 ` Philippe CORNU
2017-12-18 13:02 ` [PATCH 7/7] drm/tegra: vic: " Fabio Estevam
2017-12-19 14:32 ` [PATCH 1/7] drm/bridge/synopsys: dsi: " Philippe CORNU
6 siblings, 1 reply; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, Philippe Cornu, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Philippe Cornu <philippe.cornu@st.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/stm/ltdc.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 394613b..6dc5d4e 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -901,12 +901,6 @@ int ltdc_load(struct drm_device *ddev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- DRM_ERROR("Unable to get resource\n");
- ret = -ENODEV;
- goto err;
- }
-
ldev->regs = devm_ioremap_resource(dev, res);
if (IS_ERR(ldev->regs)) {
DRM_ERROR("Unable to get ltdc registers\n");
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 7/7] drm/tegra: vic: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
` (4 preceding siblings ...)
2017-12-18 13:02 ` [PATCH 6/7] drm/stm: ltdc: " Fabio Estevam
@ 2017-12-18 13:02 ` Fabio Estevam
2017-12-19 14:32 ` [PATCH 1/7] drm/bridge/synopsys: dsi: " Philippe CORNU
6 siblings, 0 replies; 14+ messages in thread
From: Fabio Estevam @ 2017-12-18 13:02 UTC (permalink / raw)
To: gustavo; +Cc: Fabio Estevam, Thierry Reding, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_ioremap_resource() already checks if the resource is NULL, so
remove the unnecessary platform_get_resource() error check.
Cc: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/tegra/vic.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
index f5794dd..088a795 100644
--- a/drivers/gpu/drm/tegra/vic.c
+++ b/drivers/gpu/drm/tegra/vic.c
@@ -304,11 +304,6 @@ static int vic_probe(struct platform_device *pdev)
return -ENOMEM;
regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!regs) {
- dev_err(&pdev->dev, "failed to get registers\n");
- return -ENXIO;
- }
-
vic->regs = devm_ioremap_resource(dev, regs);
if (IS_ERR(vic->regs))
return PTR_ERR(vic->regs);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/7] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
@ 2017-12-18 13:28 ` Andrzej Hajda
2017-12-18 23:44 ` Inki Dae
1 sibling, 0 replies; 14+ messages in thread
From: Andrzej Hajda @ 2017-12-18 13:28 UTC (permalink / raw)
To: Fabio Estevam, gustavo; +Cc: Fabio Estevam, dri-devel
On 18.12.2017 14:02, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
>
> Cc: Inki Dae <inki.dae@samsung.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 6be5b53..1d509a8 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -744,11 +744,6 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "cannot find IO resource\n");
> - return -ENXIO;
> - }
> -
> ctx->addr = devm_ioremap_resource(dev, res);
> if (IS_ERR(ctx->addr)) {
> dev_err(dev, "ioremap failed\n");
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/7] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
2017-12-18 13:28 ` Andrzej Hajda
@ 2017-12-18 23:44 ` Inki Dae
1 sibling, 0 replies; 14+ messages in thread
From: Inki Dae @ 2017-12-18 23:44 UTC (permalink / raw)
To: Fabio Estevam, gustavo; +Cc: Fabio Estevam, dri-devel
2017년 12월 18일 22:02에 Fabio Estevam 이(가) 쓴 글:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
>
> Cc: Inki Dae <inki.dae@samsung.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 6be5b53..1d509a8 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -744,11 +744,6 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "cannot find IO resource\n");
> - return -ENXIO;
> - }
> -
Picked it up.
Thanks,
Inki Dae
> ctx->addr = devm_ioremap_resource(dev, res);
> if (IS_ERR(ctx->addr)) {
> dev_err(dev, "ioremap failed\n");
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 5/7] drm/stm: dsi: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 ` [PATCH 5/7] drm/stm: dsi: " Fabio Estevam
@ 2017-12-19 14:14 ` Philippe CORNU
2017-12-19 14:28 ` Benjamin Gaignard
0 siblings, 1 reply; 14+ messages in thread
From: Philippe CORNU @ 2017-12-19 14:14 UTC (permalink / raw)
To: Fabio Estevam, gustavo; +Cc: Fabio Estevam, dri-devel
Dear Fabio,
On 12/18/2017 02:02 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
>
> Cc: Philippe Cornu <philippe.cornu@st.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 82dcb20..fd02506 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -290,11 +290,6 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - DRM_ERROR("Unable to get resource\n");
> - return -ENODEV;
> - }
> -
Many thanks for this cleanup.
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
> dsi->base = devm_ioremap_resource(dev, res);
> if (IS_ERR(dsi->base)) {
> DRM_ERROR("Unable to get dsi registers\n");
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 6/7] drm/stm: ltdc: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 ` [PATCH 6/7] drm/stm: ltdc: " Fabio Estevam
@ 2017-12-19 14:15 ` Philippe CORNU
2017-12-19 14:28 ` Benjamin Gaignard
0 siblings, 1 reply; 14+ messages in thread
From: Philippe CORNU @ 2017-12-19 14:15 UTC (permalink / raw)
To: Fabio Estevam, gustavo; +Cc: Fabio Estevam, dri-devel
Hi Fabio,
On 12/18/2017 02:02 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
>
> Cc: Philippe Cornu <philippe.cornu@st.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 394613b..6dc5d4e 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -901,12 +901,6 @@ int ltdc_load(struct drm_device *ddev)
> }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - DRM_ERROR("Unable to get resource\n");
> - ret = -ENODEV;
> - goto err;
> - }
> -
Many thanks for this cleanup.
Acked-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
> ldev->regs = devm_ioremap_resource(dev, res);
> if (IS_ERR(ldev->regs)) {
> DRM_ERROR("Unable to get ltdc registers\n");
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 5/7] drm/stm: dsi: Remove unnecessary platform_get_resource() error check
2017-12-19 14:14 ` Philippe CORNU
@ 2017-12-19 14:28 ` Benjamin Gaignard
0 siblings, 0 replies; 14+ messages in thread
From: Benjamin Gaignard @ 2017-12-19 14:28 UTC (permalink / raw)
To: Philippe CORNU; +Cc: Fabio Estevam, dri-devel
2017-12-19 15:14 GMT+01:00 Philippe CORNU <philippe.cornu@st.com>:
> Dear Fabio,
>
> On 12/18/2017 02:02 PM, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> devm_ioremap_resource() already checks if the resource is NULL, so
>> remove the unnecessary platform_get_resource() error check.
>>
>> Cc: Philippe Cornu <philippe.cornu@st.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>> ---
>> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> index 82dcb20..fd02506 100644
>> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
>> @@ -290,11 +290,6 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
>> return -ENOMEM;
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - DRM_ERROR("Unable to get resource\n");
>> - return -ENODEV;
>> - }
>> -
>
> Many thanks for this cleanup.
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
Applied on drm-misc-next,
Thanks,
Benjamin
>
> Philippe :-)
>
>> dsi->base = devm_ioremap_resource(dev, res);
>> if (IS_ERR(dsi->base)) {
>> DRM_ERROR("Unable to get dsi registers\n");
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 6/7] drm/stm: ltdc: Remove unnecessary platform_get_resource() error check
2017-12-19 14:15 ` Philippe CORNU
@ 2017-12-19 14:28 ` Benjamin Gaignard
0 siblings, 0 replies; 14+ messages in thread
From: Benjamin Gaignard @ 2017-12-19 14:28 UTC (permalink / raw)
To: Philippe CORNU; +Cc: Fabio Estevam, dri-devel
2017-12-19 15:15 GMT+01:00 Philippe CORNU <philippe.cornu@st.com>:
> Hi Fabio,
>
>
> On 12/18/2017 02:02 PM, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> devm_ioremap_resource() already checks if the resource is NULL, so
>> remove the unnecessary platform_get_resource() error check.
>>
>> Cc: Philippe Cornu <philippe.cornu@st.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 394613b..6dc5d4e 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -901,12 +901,6 @@ int ltdc_load(struct drm_device *ddev)
>> }
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - DRM_ERROR("Unable to get resource\n");
>> - ret = -ENODEV;
>> - goto err;
>> - }
>> -
>
> Many thanks for this cleanup.
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
Applied on drm-misc-next,
Thanks,
Benjamin
> Philippe :-)
>
>> ldev->regs = devm_ioremap_resource(dev, res);
>> if (IS_ERR(ldev->regs)) {
>> DRM_ERROR("Unable to get ltdc registers\n");
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
` (5 preceding siblings ...)
2017-12-18 13:02 ` [PATCH 7/7] drm/tegra: vic: " Fabio Estevam
@ 2017-12-19 14:32 ` Philippe CORNU
6 siblings, 0 replies; 14+ messages in thread
From: Philippe CORNU @ 2017-12-19 14:32 UTC (permalink / raw)
To: Fabio Estevam, gustavo; +Cc: Fabio Estevam, dri-devel
Dear Fabio,
On 12/18/2017 02:02 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
>
> Cc: Archit Taneja <architt@codeaurora.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index d9cca4f..5db4cbb 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -860,9 +860,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
>
> if (!plat_data->base) {
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return ERR_PTR(-ENODEV);
> -
Many thanks for this cleanup.
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
> dsi->base = devm_ioremap_resource(dev, res);
> if (IS_ERR(dsi->base))
> return ERR_PTR(-ENODEV);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-12-19 14:32 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
2017-12-18 13:28 ` Andrzej Hajda
2017-12-18 23:44 ` Inki Dae
2017-12-18 13:02 ` [PATCH 3/7] drm/rockchip: dsi: " Fabio Estevam
2017-12-18 13:02 ` [PATCH 4/7] drm/rockchip: inno_hdmi: " Fabio Estevam
2017-12-18 13:02 ` [PATCH 5/7] drm/stm: dsi: " Fabio Estevam
2017-12-19 14:14 ` Philippe CORNU
2017-12-19 14:28 ` Benjamin Gaignard
2017-12-18 13:02 ` [PATCH 6/7] drm/stm: ltdc: " Fabio Estevam
2017-12-19 14:15 ` Philippe CORNU
2017-12-19 14:28 ` Benjamin Gaignard
2017-12-18 13:02 ` [PATCH 7/7] drm/tegra: vic: " Fabio Estevam
2017-12-19 14:32 ` [PATCH 1/7] drm/bridge/synopsys: dsi: " Philippe CORNU
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.