All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Ellerman <michael@concordia.ellerman.id.au>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jouni Malinen <j@w1.fi>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"
Date: Tue, 19 Dec 2017 17:15:06 +0100	[thread overview]
Message-ID: <1513700106.26145.16.camel@sipsolutions.net> (raw)
In-Reply-To: <87vah29a1m.fsf@concordia.ellerman.id.au>

Hi,

> This revert seems to have broken networking on one of my powerpc
> machines, according to git bisect.

Fun!

TBH, I only looked at the immediate problem we ran into, and reverted
what was causing it. I don't think we saw the follow-up problem you're
seeing.

> The symptom is DHCP fails and I don't get a link, I didn't dig any
> further than that. I can if it's helpful.
> 
> I think the problem is that 87c320e51519 ("net: core: dev_get_valid_name
> is now the same as dev_alloc_name_ns") only makes sense while
> d6f295e9def0 remains in the tree.
> 
> ie. before the entire series, dev_get_valid_name() would return EEXIST,
> and that was retained when 87c320e51519 was merged, but now that
> d6f295e9def0 has been reverted dev_get_valid_name() is returning ENFILE.
> 
> I can get the network up again if I also revert 87c320e51519 ("net:
> core: dev_get_valid_name is now the same as dev_alloc_name_ns"), or with
> the gross patch below.

Makes sense. I guess that should be reverted too then, or even your
"gross" patch applied.

johannes

  reply	other threads:[~2017-12-19 16:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-02  7:41 [PATCH net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name" Johannes Berg
2017-12-05 16:27 ` David Miller
2017-12-19 12:28 ` [net] " Michael Ellerman
2017-12-19 16:15   ` Johannes Berg [this message]
2017-12-19 16:15     ` Johannes Berg
2017-12-20 23:37   ` Rasmus Villemoes
2017-12-22  4:22     ` Michael Ellerman
2018-01-02 16:50       ` David Miller
2018-01-02 16:52         ` Johannes Berg
2018-01-08  3:26         ` Michael Ellerman
2018-01-08 17:36           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513700106.26145.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=j@w1.fi \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michael@concordia.ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.