* [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static
@ 2017-12-20 5:45 Wei Yongjun
2017-12-22 10:09 ` Andrea Adami
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2017-12-20 5:45 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, Andrea Adami,
Colin Ian King
Cc: Wei Yongjun, linux-mtd, linux-kernel
Fixes the following sparse warnings:
drivers/mtd/parsers/sharpslpart.c:222:6: warning:
symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mtd/parsers/sharpslpart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
index 0ddb79a..8893dc8 100644
--- a/drivers/mtd/parsers/sharpslpart.c
+++ b/drivers/mtd/parsers/sharpslpart.c
@@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
return ret;
}
-void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
+static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
{
kfree(ftl->log2phy);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static
2017-12-20 5:45 [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static Wei Yongjun
@ 2017-12-22 10:09 ` Andrea Adami
2018-01-06 20:44 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Adami @ 2017-12-22 10:09 UTC (permalink / raw)
To: Wei Yongjun
Cc: David Woodhouse, Brian Norris, Boris Brezillon, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, Colin Ian King, linux-mtd,
linux-kernel
On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warnings:
>
> drivers/mtd/parsers/sharpslpart.c:222:6: warning:
> symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mtd/parsers/sharpslpart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> index 0ddb79a..8893dc8 100644
> --- a/drivers/mtd/parsers/sharpslpart.c
> +++ b/drivers/mtd/parsers/sharpslpart.c
> @@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> return ret;
> }
>
> -void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> +static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> {
> kfree(ftl->log2phy);
> }
>
Thanks, this should be indeed static like the other functions.
Acked-by: Andrea Adami <andrea.adami@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static
2017-12-22 10:09 ` Andrea Adami
@ 2018-01-06 20:44 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-01-06 20:44 UTC (permalink / raw)
To: Andrea Adami
Cc: Wei Yongjun, Richard Weinberger, linux-kernel, Marek Vasut,
linux-mtd, Cyrille Pitchen, Colin Ian King, Brian Norris,
David Woodhouse
On Fri, 22 Dec 2017 11:09:15 +0100
Andrea Adami <andrea.adami@gmail.com> wrote:
> On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/mtd/parsers/sharpslpart.c:222:6: warning:
> > symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/mtd/parsers/sharpslpart.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> > index 0ddb79a..8893dc8 100644
> > --- a/drivers/mtd/parsers/sharpslpart.c
> > +++ b/drivers/mtd/parsers/sharpslpart.c
> > @@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> > return ret;
> > }
> >
> > -void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> > +static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> > {
> > kfree(ftl->log2phy);
> > }
> >
>
> Thanks, this should be indeed static like the other functions.
>
> Acked-by: Andrea Adami <andrea.adami@gmail.com>
>
Applied.
Thanks,
Boris
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-06 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-20 5:45 [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static Wei Yongjun
2017-12-22 10:09 ` Andrea Adami
2018-01-06 20:44 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.