* [PATCH] x86/mcheck: Drop unnecessary barriers
@ 2017-12-20 19:15 Andrew Cooper
2017-12-21 9:28 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2017-12-20 19:15 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Jan Beulich
spin_unlock() has full barrier semantics already.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
xen/arch/x86/cpu/mcheck/mctelem.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c b/xen/arch/x86/cpu/mcheck/mctelem.c
index 492e2af..35431df 100644
--- a/xen/arch/x86/cpu/mcheck/mctelem.c
+++ b/xen/arch/x86/cpu/mcheck/mctelem.c
@@ -520,7 +520,6 @@ mctelem_cookie_t mctelem_consume_oldest_begin(mctelem_class_t which)
}
mctelem_processing_hold(tep);
- wmb();
spin_unlock(&processing_lock);
return MCTE2COOKIE(tep);
}
@@ -531,7 +530,6 @@ void mctelem_consume_oldest_end(mctelem_cookie_t cookie)
spin_lock(&processing_lock);
mctelem_processing_release(tep);
- wmb();
spin_unlock(&processing_lock);
}
@@ -547,7 +545,6 @@ void mctelem_ack(mctelem_class_t which, mctelem_cookie_t cookie)
spin_lock(&processing_lock);
if (tep == mctctl.mctc_processing_head[target])
mctelem_processing_release(tep);
- wmb();
spin_unlock(&processing_lock);
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/mcheck: Drop unnecessary barriers
2017-12-20 19:15 [PATCH] x86/mcheck: Drop unnecessary barriers Andrew Cooper
@ 2017-12-21 9:28 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2017-12-21 9:28 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel
>>> On 20.12.17 at 20:15, <andrew.cooper3@citrix.com> wrote:
> spin_unlock() has full barrier semantics already.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-21 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-20 19:15 [PATCH] x86/mcheck: Drop unnecessary barriers Andrew Cooper
2017-12-21 9:28 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.