All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock
@ 2017-12-28  3:46 Wei Yongjun
  2018-01-02  8:35 ` Juergen Gross
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Wei Yongjun @ 2017-12-28  3:46 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: Wei Yongjun, xen-devel, linux-kernel

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/xen/pvcalls-front.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 0c1ec68..dfd00d9 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -807,7 +807,7 @@ int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags)
 		pvcalls_exit();
 		return ret;
 	}
-	map2 = kzalloc(sizeof(*map2), GFP_KERNEL);
+	map2 = kzalloc(sizeof(*map2), GFP_ATOMIC);
 	if (map2 == NULL) {
 		clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT,
 			  (void *)&map->passive.flags);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock
  2017-12-28  3:46 [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock Wei Yongjun
  2018-01-02  8:35 ` Juergen Gross
@ 2018-01-02  8:35 ` Juergen Gross
  2018-01-02 18:26 ` Boris Ostrovsky
  2018-01-02 18:26 ` Boris Ostrovsky
  3 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2018-01-02  8:35 UTC (permalink / raw)
  To: Wei Yongjun, Boris Ostrovsky, Stefano Stabellini; +Cc: xen-devel, linux-kernel

On 28/12/17 04:46, Wei Yongjun wrote:
> A spin lock is taken here so we should use GFP_ATOMIC.
> 
> Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock
  2017-12-28  3:46 [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock Wei Yongjun
@ 2018-01-02  8:35 ` Juergen Gross
  2018-01-02  8:35 ` Juergen Gross
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2018-01-02  8:35 UTC (permalink / raw)
  To: Wei Yongjun, Boris Ostrovsky, Stefano Stabellini; +Cc: xen-devel, linux-kernel

On 28/12/17 04:46, Wei Yongjun wrote:
> A spin lock is taken here so we should use GFP_ATOMIC.
> 
> Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock
  2017-12-28  3:46 [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock Wei Yongjun
  2018-01-02  8:35 ` Juergen Gross
  2018-01-02  8:35 ` Juergen Gross
@ 2018-01-02 18:26 ` Boris Ostrovsky
  2018-01-02 18:26 ` Boris Ostrovsky
  3 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2018-01-02 18:26 UTC (permalink / raw)
  To: Wei Yongjun, Juergen Gross, Stefano Stabellini; +Cc: xen-devel, linux-kernel

On 12/27/2017 10:46 PM, Wei Yongjun wrote:
> A spin lock is taken here so we should use GFP_ATOMIC.
>
> Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied to for-linus-4.15

-boris

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock
  2017-12-28  3:46 [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock Wei Yongjun
                   ` (2 preceding siblings ...)
  2018-01-02 18:26 ` Boris Ostrovsky
@ 2018-01-02 18:26 ` Boris Ostrovsky
  3 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2018-01-02 18:26 UTC (permalink / raw)
  To: Wei Yongjun, Juergen Gross, Stefano Stabellini; +Cc: xen-devel, linux-kernel

On 12/27/2017 10:46 PM, Wei Yongjun wrote:
> A spin lock is taken here so we should use GFP_ATOMIC.
>
> Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied to for-linus-4.15

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock
@ 2017-12-28  3:46 Wei Yongjun
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2017-12-28  3:46 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini
  Cc: xen-devel, Wei Yongjun, linux-kernel

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: 9774c6cca266 ("xen/pvcalls: implement accept command")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/xen/pvcalls-front.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 0c1ec68..dfd00d9 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -807,7 +807,7 @@ int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags)
 		pvcalls_exit();
 		return ret;
 	}
-	map2 = kzalloc(sizeof(*map2), GFP_KERNEL);
+	map2 = kzalloc(sizeof(*map2), GFP_ATOMIC);
 	if (map2 == NULL) {
 		clear_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT,
 			  (void *)&map->passive.flags);


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-02 18:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-28  3:46 [PATCH -next] xen/pvcalls: use GFP_ATOMIC under spin lock Wei Yongjun
2018-01-02  8:35 ` Juergen Gross
2018-01-02  8:35 ` Juergen Gross
2018-01-02 18:26 ` Boris Ostrovsky
2018-01-02 18:26 ` Boris Ostrovsky
2017-12-28  3:46 Wei Yongjun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.