All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
@ 2018-01-04 23:51 Anusha Srivatsa
  2018-01-05  0:13 ` ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Anusha Srivatsa @ 2018-01-04 23:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>

There is a new version of DMC available for CNL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled
even when disabled by driver causing data corruption

v2: Since the firmware is  merged to linux-firmware.git,
add MODULE_FIRMWARE.

v3: rebased. Correct commit message(Jani)

Cc: Jani Saarinen <jani.saarinen@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 7fe4aac0..41e6c75 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,8 +37,9 @@
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
-#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
-#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
+#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
+MODULE_FIRMWARE(I915_CSR_CNL);
+#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 
 #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5)
  2018-01-04 23:51 [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
@ 2018-01-05  0:13 ` Patchwork
  2018-01-05  0:30 ` [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Rodrigo Vivi
  2018-01-05  1:00 ` ✓ Fi.CI.IGT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
  2 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-01-05  0:13 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev5)
URL   : https://patchwork.freedesktop.org/series/35651/
State : success

== Summary ==

Series 35651v5 drm/i915/dmc: DMC 1.07 for Cannonlake
https://patchwork.freedesktop.org/api/1.0/series/35651/revisions/5/mbox/

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-warn -> PASS       (fi-elk-e7500) fdo#103989 +1
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-kbl-r) fdo#104172 +1
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                pass       -> DMESG-WARN (fi-skl-6700hq) fdo#104260

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#104260 https://bugs.freedesktop.org/show_bug.cgi?id=104260

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:419s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:431s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:369s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:479s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:274s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:479s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:482s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:462s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:450s
fi-elk-e7500     total:224  pass:168  dwarn:10  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:261s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:516s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:389s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:398s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:407s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:459s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:419s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:463s
fi-kbl-7560u     total:288  pass:268  dwarn:1   dfail:0   fail:0   skip:19  time:496s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:457s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:499s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:567s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:430s
fi-skl-6600u     total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:502s
fi-skl-6700hq    total:288  pass:261  dwarn:1   dfail:0   fail:0   skip:26  time:523s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:491s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:487s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:431s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:518s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:397s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:570s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:467s

3e7d28b655aefefe51f1d7ac6aba46d6ca03b658 drm-tip: 2018y-01m-04d-22h-45m-20s UTC integration manifest
c9059885aea8 drm/i915/dmc: DMC 1.07 for Cannonlake

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7612/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2018-01-04 23:51 [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
  2018-01-05  0:13 ` ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
@ 2018-01-05  0:30 ` Rodrigo Vivi
  2018-01-05  1:00 ` ✓ Fi.CI.IGT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
  2 siblings, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2018-01-05  0:30 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

On Thu, Jan 04, 2018 at 11:51:42PM +0000, Anusha Srivatsa wrote:
> From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
> 
> There is a new version of DMC available for CNL.
> 
> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled
> even when disabled by driver causing data corruption
> 
> v2: Since the firmware is  merged to linux-firmware.git,
> add MODULE_FIRMWARE.
> 
> v3: rebased. Correct commit message(Jani)
> 
> Cc: Jani Saarinen <jani.saarinen@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

merged, thanks!

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 7fe4aac0..41e6c75 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -37,8 +37,9 @@
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
>  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>  
> -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
> +MODULE_FIRMWARE(I915_CSR_CNL);
> +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>  
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> -- 
> 2.7.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5)
  2018-01-04 23:51 [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
  2018-01-05  0:13 ` ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
  2018-01-05  0:30 ` [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Rodrigo Vivi
@ 2018-01-05  1:00 ` Patchwork
  2 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-01-05  1:00 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev5)
URL   : https://patchwork.freedesktop.org/series/35651/
State : success

== Summary ==

Test kms_plane:
        Subgroup plane-panning-bottom-right-suspend-pipe-a-planes:
                incomplete -> PASS       (shard-hsw) fdo#103540 +1
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
                fail       -> PASS       (shard-snb) fdo#101623 +1
        Subgroup fbc-1p-primscrn-cur-indfb-onoff:
                skip       -> PASS       (shard-snb)
Test perf:
        Subgroup polling:
                fail       -> PASS       (shard-hsw) fdo#102252

fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-hsw        total:2679 pass:1513 dwarn:1   dfail:0   fail:10  skip:1154 time:8747s
shard-snb        total:2713 pass:1310 dwarn:1   dfail:0   fail:11  skip:1391 time:7871s
Blacklisted hosts:
shard-apl        total:2713 pass:1686 dwarn:1   dfail:0   fail:24  skip:1001 time:13357s
shard-kbl        total:2695 pass:1788 dwarn:1   dfail:0   fail:27  skip:878 time:10277s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7612/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2018-01-04  7:52 ` Saarinen, Jani
@ 2018-01-04 23:27   ` Srivatsa, Anusha
  0 siblings, 0 replies; 14+ messages in thread
From: Srivatsa, Anusha @ 2018-01-04 23:27 UTC (permalink / raw)
  To: Saarinen, Jani, intel-gfx; +Cc: Vivi, Rodrigo



>-----Original Message-----
>From: Saarinen, Jani
>Sent: Wednesday, January 3, 2018 11:52 PM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>gfx@lists.freedesktop.org
>Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Subject: RE: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
>
>HI,
>> -----Original Message-----
>> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
>> Behalf Of Anusha Srivatsa
>> Sent: keskiviikko 3. tammikuuta 2018 23.22
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>> Subject: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
>>
>> There is a new version of DMC available for CNL.
>>
>> The release notes mentions:
>> 1. Fix for the issue where DC_STATE was getting enabled even when
>> disabled by driver causing data corruption
>>
>> v2: Since the firmware is  merged to linux-firmware.git, add
>> MODUE_FIRMWARE.
>Minor typo s/MODUE_/MODULE_

Thanks for noticing Jani.

Anusha 
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c
>> b/drivers/gpu/drm/i915/intel_csr.c
>> index f417101..0d7b3b6 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -37,8 +37,9 @@
>>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
>>  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>>
>> -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>> -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>> +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
>> +MODULE_FIRMWARE(I915_CSR_CNL);
>> +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>>
>>  #define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
>>  MODULE_FIRMWARE(I915_CSR_KBL);
>> --
>> 2.7.4
>>
>
>Br,
>
>Jani Saarinen
>Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2018-01-03 21:22 Anusha Srivatsa
@ 2018-01-04  7:52 ` Saarinen, Jani
  2018-01-04 23:27   ` Srivatsa, Anusha
  0 siblings, 1 reply; 14+ messages in thread
From: Saarinen, Jani @ 2018-01-04  7:52 UTC (permalink / raw)
  To: Srivatsa, Anusha, intel-gfx; +Cc: Vivi, Rodrigo

HI,
> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
> Anusha Srivatsa
> Sent: keskiviikko 3. tammikuuta 2018 23.22
> To: intel-gfx@lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Subject: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
> 
> There is a new version of DMC available for CNL.
> 
> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled even when disabled by
> driver causing data corruption
> 
> v2: Since the firmware is  merged to linux-firmware.git, add
> MODUE_FIRMWARE.
Minor typo s/MODUE_/MODULE_ 
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_csr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index f417101..0d7b3b6 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -37,8 +37,9 @@
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
>  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> 
> -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
> +MODULE_FIRMWARE(I915_CSR_CNL);
> +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
> 
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> --
> 2.7.4
> 

Br,

Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
@ 2018-01-03 23:00 Anusha Srivatsa
  0 siblings, 0 replies; 14+ messages in thread
From: Anusha Srivatsa @ 2018-01-03 23:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

There is a new version of DMC available for CNL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled
even when disabled by driver causing data corruption

v2: Since the firmware is  merged to linux-firmware.git,
add MODUE_FIRMWARE.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index f417101..0d7b3b6 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,8 +37,9 @@
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
-#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
-#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
+#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
+MODULE_FIRMWARE(I915_CSR_CNL);
+#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 
 #define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
@ 2018-01-03 21:22 Anusha Srivatsa
  2018-01-04  7:52 ` Saarinen, Jani
  0 siblings, 1 reply; 14+ messages in thread
From: Anusha Srivatsa @ 2018-01-03 21:22 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

There is a new version of DMC available for CNL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled
even when disabled by driver causing data corruption

v2: Since the firmware is  merged to linux-firmware.git,
add MODUE_FIRMWARE.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index f417101..0d7b3b6 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,8 +37,9 @@
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
-#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
-#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
+#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
+MODULE_FIRMWARE(I915_CSR_CNL);
+#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 
 #define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2017-12-23  0:08 Anusha Srivatsa
@ 2017-12-28 16:16 ` Rodrigo Vivi
  0 siblings, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2017-12-28 16:16 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

On Sat, Dec 23, 2017 at 12:08:30AM +0000, Anusha Srivatsa wrote:
> There is a new version of DMC available for CNL.
> 
> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled
> even when disabled by driver causing data corruption
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Patch is ready to get merged when we get the pull request going
to linux-firmware.git.

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 7fe4aac0..ed256de 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -37,8 +37,8 @@
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
>  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>  
> -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
> +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>  
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> -- 
> 2.7.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
@ 2017-12-23  0:08 Anusha Srivatsa
  2017-12-28 16:16 ` Rodrigo Vivi
  0 siblings, 1 reply; 14+ messages in thread
From: Anusha Srivatsa @ 2017-12-23  0:08 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

There is a new version of DMC available for CNL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled
even when disabled by driver causing data corruption

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 7fe4aac0..ed256de 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,8 +37,8 @@
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
-#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
-#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
+#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
+#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 
 #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2017-12-21 19:26     ` Rodrigo Vivi
@ 2017-12-21 20:31       ` Saarinen, Jani
  0 siblings, 0 replies; 14+ messages in thread
From: Saarinen, Jani @ 2017-12-21 20:31 UTC (permalink / raw)
  To: Vivi, Rodrigo; +Cc: intel-gfx

HI, 
> -----Original Message-----
> From: Vivi, Rodrigo
> Sent: torstai 21. joulukuuta 2017 21.27
> To: Saarinen, Jani <jani.saarinen@intel.com>
> Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
> 
> On Thu, Dec 21, 2017 at 12:08:15PM +0000, Saarinen, Jani wrote:
> >
> >
> > > -----Original Message-----
> > > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> > > Behalf Of Anusha Srivatsa
> > > Sent: torstai 21. joulukuuta 2017 3.38
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > > Subject: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
> > >
> > > There is a new version of DMC available for KBL.
> > For CNL you mean?
> 
> With this fixed feel free to use:
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> Jani, these results we got from CI are already with fw applied?
I am afraid not see: 
<4>[  574.873592] i915 0000:00:02.0: Direct firmware load for i915/cnl_dmc_ver1_07.bin failed with error -2
<5>[  574.873638] i915 0000:00:02.0: Failed to load DMC firmware i915/cnl_dmc_ver1_07.bin. Disabling runtime power management.

We need to re-run because there was an issue because the CI server changes, but fixed now by Tomi
Re-test request sent as seen on queue now: https://intel-gfx-ci.01.org/queue/intel-gfx.html
With that there is already FW waiting on systems.

> Although CNL is on blacklist still right?! :(
Yes, but that do not matter for results altogether are still sent. 

> 
> > >
> > > The release notes mentions:
> > > 1. Fix for the issue where DC_STATE was getting enabled even when
> > > disabled by driver causing data corruption
> > >
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_csr.c
> > > b/drivers/gpu/drm/i915/intel_csr.c
> > > index 7fe4aac0..ed256de 100644
> > > --- a/drivers/gpu/drm/i915/intel_csr.c
> > > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > > @@ -37,8 +37,8 @@
> > >  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> > >  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> > >
> > > -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> > > -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> > > +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
> > > +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
> > >
> > >  #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
> > >  MODULE_FIRMWARE(I915_CSR_KBL);
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2017-12-21 12:08   ` Saarinen, Jani
@ 2017-12-21 19:26     ` Rodrigo Vivi
  2017-12-21 20:31       ` Saarinen, Jani
  0 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2017-12-21 19:26 UTC (permalink / raw)
  To: Saarinen, Jani; +Cc: intel-gfx

On Thu, Dec 21, 2017 at 12:08:15PM +0000, Saarinen, Jani wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
> > Anusha Srivatsa
> > Sent: torstai 21. joulukuuta 2017 3.38
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Subject: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
> > 
> > There is a new version of DMC available for KBL.
> For CNL you mean?

With this fixed feel free to use:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Jani, these results we got from CI are already with fw applied?
Although CNL is on blacklist still right?! :(

> > 
> > The release notes mentions:
> > 1. Fix for the issue where DC_STATE was getting enabled even when disabled by
> > driver causing data corruption
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index 7fe4aac0..ed256de 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -37,8 +37,8 @@
> >  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> >  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> > 
> > -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> > -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> > +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
> > +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
> > 
> >  #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
> >  MODULE_FIRMWARE(I915_CSR_KBL);
> > --
> > 2.7.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2017-12-21  1:37 ` [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
@ 2017-12-21 12:08   ` Saarinen, Jani
  2017-12-21 19:26     ` Rodrigo Vivi
  0 siblings, 1 reply; 14+ messages in thread
From: Saarinen, Jani @ 2017-12-21 12:08 UTC (permalink / raw)
  To: Srivatsa, Anusha, intel-gfx; +Cc: Vivi, Rodrigo



> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
> Anusha Srivatsa
> Sent: torstai 21. joulukuuta 2017 3.38
> To: intel-gfx@lists.freedesktop.org
> Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> Subject: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
> 
> There is a new version of DMC available for KBL.
For CNL you mean? 
> 
> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled even when disabled by
> driver causing data corruption
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 7fe4aac0..ed256de 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -37,8 +37,8 @@
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
>  #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> 
> -#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> -#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> +#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
> +#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
> 
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> --
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake
  2017-12-21  1:37 [PATCH] CNL DMC v1.07 Anusha Srivatsa
@ 2017-12-21  1:37 ` Anusha Srivatsa
  2017-12-21 12:08   ` Saarinen, Jani
  0 siblings, 1 reply; 14+ messages in thread
From: Anusha Srivatsa @ 2017-12-21  1:37 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

There is a new version of DMC available for KBL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled
even when disabled by driver causing data corruption

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 7fe4aac0..ed256de 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,8 +37,8 @@
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
-#define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
-#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
+#define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
+#define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 
 #define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-01-05  1:00 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-04 23:51 [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
2018-01-05  0:13 ` ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
2018-01-05  0:30 ` [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Rodrigo Vivi
2018-01-05  1:00 ` ✓ Fi.CI.IGT: success for drm/i915/dmc: DMC 1.07 for Cannonlake (rev5) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-01-03 23:00 [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
2018-01-03 21:22 Anusha Srivatsa
2018-01-04  7:52 ` Saarinen, Jani
2018-01-04 23:27   ` Srivatsa, Anusha
2017-12-23  0:08 Anusha Srivatsa
2017-12-28 16:16 ` Rodrigo Vivi
2017-12-21  1:37 [PATCH] CNL DMC v1.07 Anusha Srivatsa
2017-12-21  1:37 ` [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake Anusha Srivatsa
2017-12-21 12:08   ` Saarinen, Jani
2017-12-21 19:26     ` Rodrigo Vivi
2017-12-21 20:31       ` Saarinen, Jani

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.