All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Yixun Lan <yixun.lan@amlogic.com>,
	Kevin Hilman <khilman@baylibre.com>,
	devicetree@vger.kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Carlo Caione <carlo@caione.org>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: meson-axg: complete the pinctrl info for UART_AO_A
Date: Fri, 05 Jan 2018 11:27:40 +0100	[thread overview]
Message-ID: <1515148060.5048.21.camel@baylibre.com> (raw)
In-Reply-To: <20180105095621.196472-6-yixun.lan@amlogic.com>

On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
> Explictly request the pinctrl info for the UART_AO_A controller,
> otherwise we my rely on bootloader for the initialization.
  "we may" ? --^

> 
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>

Please be consistent in the title
s/arm64/ARM64

Otherwise looks good once patch #4 is fixed

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

> ---
>  arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 70eca1f8736a..2b79be356996 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -19,4 +19,6 @@
>  
>  &uart_AO {
>  	status = "okay";
> +	pinctrl-0 = <&uart_ao_a_pins>;
> +	pinctrl-names = "default";
>  };

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Neil Armstrong
	<narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/6] arm64: dts: meson-axg: complete the pinctrl info for UART_AO_A
Date: Fri, 05 Jan 2018 11:27:40 +0100	[thread overview]
Message-ID: <1515148060.5048.21.camel@baylibre.com> (raw)
In-Reply-To: <20180105095621.196472-6-yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>

On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
> Explictly request the pinctrl info for the UART_AO_A controller,
> otherwise we my rely on bootloader for the initialization.
  "we may" ? --^

> 
> Signed-off-by: Yixun Lan <yixun.lan-LpR1jeaWuhtBDgjK7y7TUQ@public.gmane.org>

Please be consistent in the title
s/arm64/ARM64

Otherwise looks good once patch #4 is fixed

Acked-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

> ---
>  arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 70eca1f8736a..2b79be356996 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -19,4 +19,6 @@
>  
>  &uart_AO {
>  	status = "okay";
> +	pinctrl-0 = <&uart_ao_a_pins>;
> +	pinctrl-names = "default";
>  };

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] arm64: dts: meson-axg: complete the pinctrl info for UART_AO_A
Date: Fri, 05 Jan 2018 11:27:40 +0100	[thread overview]
Message-ID: <1515148060.5048.21.camel@baylibre.com> (raw)
In-Reply-To: <20180105095621.196472-6-yixun.lan@amlogic.com>

On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
> Explictly request the pinctrl info for the UART_AO_A controller,
> otherwise we my rely on bootloader for the initialization.
  "we may" ? --^

> 
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>

Please be consistent in the title
s/arm64/ARM64

Otherwise looks good once patch #4 is fixed

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

> ---
>  arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 70eca1f8736a..2b79be356996 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -19,4 +19,6 @@
>  
>  &uart_AO {
>  	status = "okay";
> +	pinctrl-0 = <&uart_ao_a_pins>;
> +	pinctrl-names = "default";
>  };

WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 5/6] arm64: dts: meson-axg: complete the pinctrl info for UART_AO_A
Date: Fri, 05 Jan 2018 11:27:40 +0100	[thread overview]
Message-ID: <1515148060.5048.21.camel@baylibre.com> (raw)
In-Reply-To: <20180105095621.196472-6-yixun.lan@amlogic.com>

On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
> Explictly request the pinctrl info for the UART_AO_A controller,
> otherwise we my rely on bootloader for the initialization.
  "we may" ? --^

> 
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>

Please be consistent in the title
s/arm64/ARM64

Otherwise looks good once patch #4 is fixed

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

> ---
>  arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 70eca1f8736a..2b79be356996 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -19,4 +19,6 @@
>  
>  &uart_AO {
>  	status = "okay";
> +	pinctrl-0 = <&uart_ao_a_pins>;
> +	pinctrl-names = "default";
>  };

  reply	other threads:[~2018-01-05 10:27 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05  9:56 [PATCH 0/6] ARM64: dts: meson-axg: UART DT updates Yixun Lan
2018-01-05  9:56 ` Yixun Lan
2018-01-05  9:56 ` Yixun Lan
2018-01-05  9:56 ` Yixun Lan
2018-01-05  9:56 ` [PATCH 1/6] ARM64: dts: meson-axg: uart: drop legacy compatible name from EE UART Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05 10:30   ` Jerome Brunet
2018-01-05 10:30     ` Jerome Brunet
2018-01-05 10:30     ` Jerome Brunet
2018-01-05 10:30     ` Jerome Brunet
2018-01-05 13:11     ` Yixun Lan
2018-01-05 13:11       ` Yixun Lan
2018-01-05 13:11       ` Yixun Lan
2018-01-05 13:11       ` Yixun Lan
2018-01-05  9:56 ` [PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05 10:30   ` Jerome Brunet
2018-01-05 10:30     ` Jerome Brunet
2018-01-05 10:30     ` Jerome Brunet
2018-01-05 13:43     ` Yixun Lan
2018-01-05 13:43       ` Yixun Lan
2018-01-05 13:43       ` Yixun Lan
2018-01-05 13:43       ` Yixun Lan
2018-01-05  9:56 ` [PATCH 3/6] ARM64: dts: meson-axg: uart: Add the clock info description Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05 10:29   ` Jerome Brunet
2018-01-05 10:29     ` Jerome Brunet
2018-01-05 10:29     ` Jerome Brunet
2018-01-05  9:56 ` [PATCH 4/6] ARM64: dts: meson-axg: uart: Add the pinctrl " Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05 10:28   ` Jerome Brunet
2018-01-05 10:28     ` Jerome Brunet
2018-01-05 10:28     ` Jerome Brunet
2018-01-05 10:28     ` Jerome Brunet
2018-01-05 14:22     ` Yixun Lan
2018-01-05 14:22       ` Yixun Lan
2018-01-05 14:22       ` Yixun Lan
2018-01-05 14:22       ` Yixun Lan
2018-01-05  9:56 ` [PATCH 5/6] arm64: dts: meson-axg: complete the pinctrl info for UART_AO_A Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05 10:27   ` Jerome Brunet [this message]
2018-01-05 10:27     ` Jerome Brunet
2018-01-05 10:27     ` Jerome Brunet
2018-01-05 10:27     ` Jerome Brunet
2018-01-05  9:56 ` [PATCH 6/6] ARM64: dts: meson-axg: enable the UART_A controller Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05  9:56   ` Yixun Lan
2018-01-05 10:27   ` Jerome Brunet
2018-01-05 10:27     ` Jerome Brunet
2018-01-05 10:27     ` Jerome Brunet
2018-01-05 10:27     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515148060.5048.21.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=yixun.lan@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.