* [PATCH v2 1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path @ 2018-01-10 10:33 Sagar Arun Kamble 2018-01-10 11:03 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork 2018-01-10 12:16 ` ✓ Fi.CI.IGT: " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Sagar Arun Kamble @ 2018-01-10 10:33 UTC (permalink / raw) To: intel-gfx While moving code around for solving lockdep issue for GuC log relay, spotted that uc_fini_wq is not being called in failure path in gem_init. Missed in the below commit. Add it. v2: Removed GEM_BUG_ON(!HAS_GUC()) from intel_uc_fini_wq as init happens only based on enable_guc module parameter and does not consider has_guc capability. (Michal) Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> Fixes: 3176ff49bc3e ("drm/i915/guc: Move GuC workqueue allocations outside of the mutex") Cc: Michał Winiarski <michal.winiarski@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Michał Winiarski <michal.winiarski@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ drivers/gpu/drm/i915/intel_uc.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 8bc3283..1135a77 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -5283,6 +5283,8 @@ int i915_gem_init(struct drm_i915_private *dev_priv) intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL); mutex_unlock(&dev_priv->drm.struct_mutex); + intel_uc_fini_wq(dev_priv); + if (ret != -EIO) i915_gem_cleanup_userptr(dev_priv); diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index 907deac..d82ca0f 100644 --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -209,8 +209,6 @@ void intel_uc_fini_wq(struct drm_i915_private *dev_priv) if (!USES_GUC(dev_priv)) return; - GEM_BUG_ON(!HAS_GUC(dev_priv)); - intel_guc_fini_wq(&dev_priv->guc); } -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2,1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path 2018-01-10 10:33 [PATCH v2 1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path Sagar Arun Kamble @ 2018-01-10 11:03 ` Patchwork 2018-01-10 12:16 ` ✓ Fi.CI.IGT: " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-01-10 11:03 UTC (permalink / raw) To: Sagar Arun Kamble; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path URL : https://patchwork.freedesktop.org/series/36261/ State : success == Summary == Series 36261v1 series starting with [v2,1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path https://patchwork.freedesktop.org/api/1.0/series/36261/revisions/1/mbox/ Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 Test kms_flip: Subgroup basic-flip-vs-wf_vblank: pass -> FAIL (fi-hsw-4770r) fdo#100368 Test kms_frontbuffer_tracking: Subgroup basic: incomplete -> PASS (fi-bsw-n3050) fdo#104571 Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-a: dmesg-warn -> PASS (fi-kbl-r) fdo#104172 +1 fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989 fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#104571 https://bugs.freedesktop.org/show_bug.cgi?id=104571 fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172 fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:421s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:425s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:486s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:484s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:486s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:465s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:458s fi-elk-e7500 total:224 pass:168 dwarn:9 dfail:1 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:275s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:511s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:392s fi-hsw-4770r total:288 pass:260 dwarn:0 dfail:0 fail:1 skip:27 time:395s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:415s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:460s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:419s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:466s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:499s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:455s fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:499s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:432s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:509s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:531s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:495s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:476s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:529s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:402s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:574s fi-cnl-y2 total:288 pass:258 dwarn:3 dfail:0 fail:0 skip:27 time:542s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:474s fi-pnv-d510 failed to collect. IGT log at Patchwork_7639/fi-pnv-d510/igt.log 17fd16225c4df784ff06467c8bc528bee156a274 drm-tip: 2018y-01m-10d-09h-37m-51s UTC integration manifest c82c760d79fe drm/i915/guc: Add uc_fini_wq in gem_init unwind path == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7639/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [v2,1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path 2018-01-10 10:33 [PATCH v2 1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path Sagar Arun Kamble 2018-01-10 11:03 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork @ 2018-01-10 12:16 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-01-10 12:16 UTC (permalink / raw) To: Sagar Arun Kamble; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path URL : https://patchwork.freedesktop.org/series/36261/ State : success == Summary == Warning: bzip CI_DRM_3618/shard-glkb6/results30.json.bz2 wasn't in correct JSON format Test kms_cursor_legacy: Subgroup flip-vs-cursor-atomic: pass -> SKIP (shard-hsw) fdo#102670 Test perf: Subgroup blocking: pass -> FAIL (shard-hsw) fdo#102252 Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: pass -> FAIL (shard-snb) fdo#101623 Test drv_suspend: Subgroup fence-restore-tiled2untiled: pass -> SKIP (shard-snb) fdo#104218 +1 Test gem_softpin: Subgroup noreloc-s4: skip -> FAIL (shard-hsw) fdo#103375 +1 Test kms_flip: Subgroup flip-vs-blocking-wf-vblank: pass -> FAIL (shard-hsw) fdo#100368 fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670 fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252 fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623 fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218 fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 shard-hsw total:2640 pass:1497 dwarn:1 dfail:0 fail:12 skip:1129 time:8791s shard-snb total:2713 pass:1309 dwarn:1 dfail:0 fail:11 skip:1392 time:7915s Blacklisted hosts: shard-apl total:2713 pass:1685 dwarn:1 dfail:0 fail:26 skip:1001 time:13536s shard-kbl total:2713 pass:1800 dwarn:1 dfail:0 fail:32 skip:880 time:10473s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7639/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-10 12:16 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-10 10:33 [PATCH v2 1/1] drm/i915/guc: Add uc_fini_wq in gem_init unwind path Sagar Arun Kamble 2018-01-10 11:03 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork 2018-01-10 12:16 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.