dmaengine: dmatest: fix container_of member in dmatest_callback

dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang Shunyong]

The type of arg passed to dmatest_callback is struct dmatest_done.
It refers to test_done in struct dmatest_thread, not done_wait.

Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
---
 drivers/dma/dmatest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ec5f9d2bc820..906e85d6dedc 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
 {
 	struct dmatest_done *done = arg;
 	struct dmatest_thread *thread =
-		container_of(arg, struct dmatest_thread, done_wait);
+		container_of(arg, struct dmatest_thread, test_done);
 	if (!thread->done) {
 		done->done = true;
 		wake_up_all(done->wait);

[PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang Shunyong]

The type of arg passed to dmatest_callback is struct dmatest_done.
It refers to test_done in struct dmatest_thread, not done_wait.

Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
---
 drivers/dma/dmatest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ec5f9d2bc820..906e85d6dedc 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
 {
 	struct dmatest_done *done = arg;
 	struct dmatest_thread *thread =
-		container_of(arg, struct dmatest_thread, done_wait);
+		container_of(arg, struct dmatest_thread, test_done);
 	if (!thread->done) {
 		done->done = true;
 		wake_up_all(done->wait);
-- 
1.8.3.1

dmaengine: dmatest: fix container_of member in dmatest_callback

[Adam Wallis]

On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> The type of arg passed to dmatest_callback is struct dmatest_done.
> It refers to test_done in struct dmatest_thread, not done_wait.
> 
> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> ---
>  drivers/dma/dmatest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..906e85d6dedc 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>  	struct dmatest_done *done = arg;
>  	struct dmatest_thread *thread =
> -		container_of(arg, struct dmatest_thread, done_wait);
> +		container_of(arg, struct dmatest_thread, test_done);
>  	if (!thread->done) {
>  		done->done = true;
>  		wake_up_all(done->wait);
> 
Thanks for the catch

Acked-by: Adam Wallis <awallis@codeaurora.org>

Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Adam Wallis]

On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> The type of arg passed to dmatest_callback is struct dmatest_done.
> It refers to test_done in struct dmatest_thread, not done_wait.
> 
> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> ---
>  drivers/dma/dmatest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..906e85d6dedc 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>  	struct dmatest_done *done = arg;
>  	struct dmatest_thread *thread =
> -		container_of(arg, struct dmatest_thread, done_wait);
> +		container_of(arg, struct dmatest_thread, test_done);
>  	if (!thread->done) {
>  		done->done = true;
>  		wake_up_all(done->wait);
> 
Thanks for the catch

Acked-by: Adam Wallis <awallis@codeaurora.org>
-- 
Adam Wallis
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang Shunyong]

Hi, Adam

On Tue, 2018-01-23 at 09:32 -0500, Adam Wallis wrote:
> On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> > 
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> > 
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> >  drivers/dma/dmatest.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> >  {
> >  	struct dmatest_done *done = arg;
> >  	struct dmatest_thread *thread =
> > -		container_of(arg, struct dmatest_thread,
> > done_wait);
> > +		container_of(arg, struct dmatest_thread,
> > test_done);
> >  	if (!thread->done) {
> >  		done->done = true;
> >  		wake_up_all(done->wait);
> > 
> Thanks for the catch
> 
> Acked-by: Adam Wallis <awallis@codeaurora.org>

Thanks!

Shunyong--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang, Shunyong]

Hi, Adam

On Tue, 2018-01-23 at 09:32 -0500, Adam Wallis wrote:
> On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> > 
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> > 
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> >  drivers/dma/dmatest.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> >  {
> >  	struct dmatest_done *done = arg;
> >  	struct dmatest_thread *thread =
> > -		container_of(arg, struct dmatest_thread,
> > done_wait);
> > +		container_of(arg, struct dmatest_thread,
> > test_done);
> >  	if (!thread->done) {
> >  		done->done = true;
> >  		wake_up_all(done->wait);
> > 
> Thanks for the catch
> 
> Acked-by: Adam Wallis <awallis@codeaurora.org>

Thanks!

Shunyong

dmaengine: dmatest: fix container_of member in dmatest_callback

[Adam Wallis]

Vinod,

On 1/23/2018 8:47 PM, Yang, Shunyong wrote:
> Hi, Adam
> 
> On Tue, 2018-01-23 at 09:32 -0500, Adam Wallis wrote:
>> On 1/22/2018 2:28 AM, Yang Shunyong wrote:
>>>
>>> The type of arg passed to dmatest_callback is struct dmatest_done.
>>> It refers to test_done in struct dmatest_thread, not done_wait.
>>>
>>> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
>>> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
[..]
>>>
>> Thanks for the catch
>>
>> Acked-by: Adam Wallis <awallis@codeaurora.org>
> 
> Thanks!
> 
> Shunyong
> 

Can we get this fix into the 4.16 kernel? This is an important fix.

Thanks

Adam

Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Adam Wallis]

Vinod,

On 1/23/2018 8:47 PM, Yang, Shunyong wrote:
> Hi, Adam
> 
> On Tue, 2018-01-23 at 09:32 -0500, Adam Wallis wrote:
>> On 1/22/2018 2:28 AM, Yang Shunyong wrote:
>>>
>>> The type of arg passed to dmatest_callback is struct dmatest_done.
>>> It refers to test_done in struct dmatest_thread, not done_wait.
>>>
>>> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
>>> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
[..]
>>>
>> Thanks for the catch
>>
>> Acked-by: Adam Wallis <awallis@codeaurora.org>
> 
> Thanks!
> 
> Shunyong
> 

Can we get this fix into the 4.16 kernel? This is an important fix.

Thanks

Adam

-- 
Adam Wallis
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

dmaengine: dmatest: fix container_of member in dmatest_callback

[Vinod Koul]

On Mon, Jan 22, 2018 at 03:28:28PM +0800, Yang Shunyong wrote:
> The type of arg passed to dmatest_callback is struct dmatest_done.
> It refers to test_done in struct dmatest_thread, not done_wait.
> 
> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> ---
>  drivers/dma/dmatest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..906e85d6dedc 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>  	struct dmatest_done *done = arg;
>  	struct dmatest_thread *thread =
> -		container_of(arg, struct dmatest_thread, done_wait);
> +		container_of(arg, struct dmatest_thread, test_done);

This fixes it but one of the reason why compilers didn't catch this
was the void arg. I just tested and used 'done' as the argument here
rather than 'arg' and compiler was quick to point out the error.

So a better fix IMO would be:

-- >8 --

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ec5f9d2bc820..80cc2be6483c 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
 {
        struct dmatest_done *done = arg;
        struct dmatest_thread *thread =
-               container_of(arg, struct dmatest_thread, done_wait);
+               container_of(done, struct dmatest_thread, test_done);
        if (!thread->done) {
                done->done = true;
                wake_up_all(done->wait);

Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Vinod Koul]

On Mon, Jan 22, 2018 at 03:28:28PM +0800, Yang Shunyong wrote:
> The type of arg passed to dmatest_callback is struct dmatest_done.
> It refers to test_done in struct dmatest_thread, not done_wait.
> 
> Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> ---
>  drivers/dma/dmatest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..906e85d6dedc 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>  	struct dmatest_done *done = arg;
>  	struct dmatest_thread *thread =
> -		container_of(arg, struct dmatest_thread, done_wait);
> +		container_of(arg, struct dmatest_thread, test_done);

This fixes it but one of the reason why compilers didn't catch this
was the void arg. I just tested and used 'done' as the argument here
rather than 'arg' and compiler was quick to point out the error.

So a better fix IMO would be:

-- >8 --

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ec5f9d2bc820..80cc2be6483c 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
 {
        struct dmatest_done *done = arg;
        struct dmatest_thread *thread =
-               container_of(arg, struct dmatest_thread, done_wait);
+               container_of(done, struct dmatest_thread, test_done);
        if (!thread->done) {
                done->done = true;
                wake_up_all(done->wait);

-- 
~Vinod

dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang Shunyong]

Hi, Vinod,

On Mon, 2018-01-29 at 10:15 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 03:28:28PM +0800, Yang Shunyong wrote:
> > 
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> > 
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> >  drivers/dma/dmatest.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> >  {
> >  	struct dmatest_done *done = arg;
> >  	struct dmatest_thread *thread =
> > -		container_of(arg, struct dmatest_thread,
> > done_wait);
> > +		container_of(arg, struct dmatest_thread,
> > test_done);
> This fixes it but one of the reason why compilers didn't catch this
> was the void arg. I just tested and used 'done' as the argument here
> rather than 'arg' and compiler was quick to point out the error.
> 
> So a better fix IMO would be:
> 
> -- >8 --
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..80cc2be6483c 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>         struct dmatest_done *done = arg;
>         struct dmatest_thread *thread =
> -               container_of(arg, struct dmatest_thread, done_wait);
> +               container_of(done, struct dmatest_thread, test_done);
>         if (!thread->done) {
>                 done->done = true;
>                 wake_up_all(done->wait);
> 

Thanks. I will send out v2 patch soon.

Shunyong
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang, Shunyong]

Hi, Vinod,

On Mon, 2018-01-29 at 10:15 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 03:28:28PM +0800, Yang Shunyong wrote:
> > 
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> > 
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> >  drivers/dma/dmatest.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> >  {
> >  	struct dmatest_done *done = arg;
> >  	struct dmatest_thread *thread =
> > -		container_of(arg, struct dmatest_thread,
> > done_wait);
> > +		container_of(arg, struct dmatest_thread,
> > test_done);
> This fixes it but one of the reason why compilers didn't catch this
> was the void arg. I just tested and used 'done' as the argument here
> rather than 'arg' and compiler was quick to point out the error.
> 
> So a better fix IMO would be:
> 
> -- >8 --
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..80cc2be6483c 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
>  {
>         struct dmatest_done *done = arg;
>         struct dmatest_thread *thread =
> -               container_of(arg, struct dmatest_thread, done_wait);
> +               container_of(done, struct dmatest_thread, test_done);
>         if (!thread->done) {
>                 done->done = true;
>                 wake_up_all(done->wait);
> 

Thanks. I will send out v2 patch soon.

Shunyong

dmaengine: dmatest: fix container_of member in dmatest_callback

[Wen He]

DQpUaGFua3MgZm9yIHlvdSwgU2h1bnlvbmcuDQoNCkJlc3QgUmVnYXJkcywNCldlbiBIZQ0KDQo+
IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IGRtYWVuZ2luZS1vd25lckB2Z2Vy
Lmtlcm5lbC5vcmcNCj4gW21haWx0bzpkbWFlbmdpbmUtb3duZXJAdmdlci5rZXJuZWwub3JnXSBP
biBCZWhhbGYgT2YgQWRhbSBXYWxsaXMNCj4gU2VudDogMjAxOOW5tDHmnIgyM+aXpSAyMjozMg0K
PiBUbzogWWFuZyBTaHVueW9uZyA8c2h1bnlvbmcueWFuZ0BoeHQtc2VtaXRlY2guY29tPjsNCj4g
dmlub2Qua291bEBpbnRlbC5jb20NCj4gQ2M6IGRhbi5qLndpbGxpYW1zQGludGVsLmNvbTsgeXUu
emhlbmdAaHh0LXNlbWl0ZWNoLmNvbTsNCj4gZG1hZW5naW5lQHZnZXIua2VybmVsLm9yZzsgbGlu
dXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgR3JhaGFtIE1vb3JlDQo+IDxncmFoYW0ubW9vcmVA
bGludXguaW50ZWwuY29tPjsgb2theWFAY29kZWF1cm9yYS5vcmcgPj4gU2luYW4gS2F5YQ0KPiA8
b2theWFAY29kZWF1cm9yYS5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRtYWVuZ2luZTog
ZG1hdGVzdDogZml4IGNvbnRhaW5lcl9vZiBtZW1iZXIgaW4NCj4gZG1hdGVzdF9jYWxsYmFjaw0K
PiANCj4gT24gMS8yMi8yMDE4IDI6MjggQU0sIFlhbmcgU2h1bnlvbmcgd3JvdGU6DQo+ID4gVGhl
IHR5cGUgb2YgYXJnIHBhc3NlZCB0byBkbWF0ZXN0X2NhbGxiYWNrIGlzIHN0cnVjdCBkbWF0ZXN0
X2RvbmUuDQo+ID4gSXQgcmVmZXJzIHRvIHRlc3RfZG9uZSBpbiBzdHJ1Y3QgZG1hdGVzdF90aHJl
YWQsIG5vdCBkb25lX3dhaXQuDQo+ID4NCj4gPiBGaXhlczogNmY2YTIzYTIxM2JlICgiZG1hZW5n
aW5lOiBkbWF0ZXN0OiBtb3ZlIGNhbGxiYWNrIHdhaXQgLi4uIikNCj4gPiBTaWduZWQtb2ZmLWJ5
OiBZYW5nIFNodW55b25nIDxzaHVueW9uZy55YW5nQGh4dC1zZW1pdGVjaC5jb20+DQo+ID4gLS0t
DQo+ID4gIGRyaXZlcnMvZG1hL2RtYXRlc3QuYyB8IDIgKy0NCj4gPiAgMSBmaWxlIGNoYW5nZWQs
IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9kbWEvZG1hdGVzdC5jIGIvZHJpdmVycy9kbWEvZG1hdGVzdC5jIGluZGV4DQo+ID4gZWM1
ZjlkMmJjODIwLi45MDZlODVkNmRlZGMgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9kbWEvZG1h
dGVzdC5jDQo+ID4gKysrIGIvZHJpdmVycy9kbWEvZG1hdGVzdC5jDQo+ID4gQEAgLTM1NSw3ICsz
NTUsNyBAQCBzdGF0aWMgdm9pZCBkbWF0ZXN0X2NhbGxiYWNrKHZvaWQgKmFyZykgIHsNCj4gPiAg
CXN0cnVjdCBkbWF0ZXN0X2RvbmUgKmRvbmUgPSBhcmc7DQo+ID4gIAlzdHJ1Y3QgZG1hdGVzdF90
aHJlYWQgKnRocmVhZCA9DQo+ID4gLQkJY29udGFpbmVyX29mKGFyZywgc3RydWN0IGRtYXRlc3Rf
dGhyZWFkLCBkb25lX3dhaXQpOw0KPiA+ICsJCWNvbnRhaW5lcl9vZihhcmcsIHN0cnVjdCBkbWF0
ZXN0X3RocmVhZCwgdGVzdF9kb25lKTsNCj4gPiAgCWlmICghdGhyZWFkLT5kb25lKSB7DQo+ID4g
IAkJZG9uZS0+ZG9uZSA9IHRydWU7DQo+ID4gIAkJd2FrZV91cF9hbGwoZG9uZS0+d2FpdCk7DQo+
ID4NCj4gVGhhbmtzIGZvciB0aGUgY2F0Y2gNCj4gDQo+IEFja2VkLWJ5OiBBZGFtIFdhbGxpcyA8
YXdhbGxpc0Bjb2RlYXVyb3JhLm9yZz4NCj4gLS0NCj4gQWRhbSBXYWxsaXMNCj4gUXVhbGNvbW0g
RGF0YWNlbnRlciBUZWNobm9sb2dpZXMgYXMgYW4gYWZmaWxpYXRlIG9mIFF1YWxjb21tIFRlY2hu
b2xvZ2llcywNCj4gSW5jLg0KPiBRdWFsY29tbSBUZWNobm9sb2dpZXMsIEluYy4gaXMgYSBtZW1i
ZXIgb2YgdGhlIENvZGUgQXVyb3JhIEZvcnVtLCBhIExpbnV4DQo+IEZvdW5kYXRpb24gQ29sbGFi
b3JhdGl2ZSBQcm9qZWN0Lg0KPiAtLQ0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDog
c2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgZG1hZW5naW5lIiBpbiB0aGUNCj4gYm9keSBvZiBh
IG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZyBNb3JlIG1ham9yZG9tbyBpbmZv
IGF0DQo+IGh0dHBzOi8vZW1lYTAxLnNhZmVsaW5rcy5wcm90ZWN0aW9uLm91dGxvb2suY29tLz91
cmw9aHR0cCUzQSUyRiUyRnZnZXIuDQo+IGtlcm5lbC5vcmclMkZtYWpvcmRvbW8taW5mby5odG1s
JmRhdGE9MDIlN0MwMSU3Q3dlbi5oZV8xJTQwbnhwLmNvDQo+IG0lN0M4ODE2MTU2OGE3ZmQ0MzQ5
MTQ5YjA4ZDU2MjZlMTY2MSU3QzY4NmVhMWQzYmMyYjRjNmZhOTJjZDkNCj4gOWM1YzMwMTYzNSU3
QzAlN0MwJTdDNjM2NTIzMTQ3MzU0MTk2NjIyJnNkYXRhPXR4SXRndkQzUCUyRnJRcQ0KPiBNU21w
WmxUWTFyQTF5VWVXeE1IVGxFTE81dnd5ODQlM0QmcmVzZXJ2ZWQ9MA0K
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Wen He]

Thanks for you, Shunyong.

Best Regards,
Wen He

> -----Original Message-----
> From: dmaengine-owner@vger.kernel.org
> [mailto:dmaengine-owner@vger.kernel.org] On Behalf Of Adam Wallis
> Sent: 2018年1月23日 22:32
> To: Yang Shunyong <shunyong.yang@hxt-semitech.com>;
> vinod.koul@intel.com
> Cc: dan.j.williams@intel.com; yu.zheng@hxt-semitech.com;
> dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org; Graham Moore
> <graham.moore@linux.intel.com>; okaya@codeaurora.org >> Sinan Kaya
> <okaya@codeaurora.org>
> Subject: Re: [PATCH] dmaengine: dmatest: fix container_of member in
> dmatest_callback
> 
> On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> >
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> >  drivers/dma/dmatest.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index
> > ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)  {
> >  	struct dmatest_done *done = arg;
> >  	struct dmatest_thread *thread =
> > -		container_of(arg, struct dmatest_thread, done_wait);
> > +		container_of(arg, struct dmatest_thread, test_done);
> >  	if (!thread->done) {
> >  		done->done = true;
> >  		wake_up_all(done->wait);
> >
> Thanks for the catch
> 
> Acked-by: Adam Wallis <awallis@codeaurora.org>
> --
> Adam Wallis
> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies,
> Inc.
> Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux
> Foundation Collaborative Project.
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.
> kernel.org%2Fmajordomo-info.html&data=02%7C01%7Cwen.he_1%40nxp.co
> m%7C88161568a7fd4349149b08d5626e1661%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C636523147354196622&sdata=txItgvD3P%2FrQq
> MSmpZlTY1rA1yUeWxMHTlELO5vwy84%3D&reserved=0

dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang Shunyong]

SGksIFdlbg0KDQpZb3UncmUgd2VsY29tZS4gVGhhdCdzIHdoeSBjYWxsIHRoaXMgQ09NTVVOSVRZ
IcKgOi0pDQoNClNodW55b25nLg0KVGhhbmtzLg0KDQpPbiBTdW4sIDIwMTgtMDItMTEgYXQgMDk6
MjggKzAwMDAsIFdlbiBIZSB3cm90ZToNCj4gVGhhbmtzIGZvciB5b3UsIFNodW55b25nLg0KPiAN
Cj4gQmVzdCBSZWdhcmRzLA0KPiBXZW4gSGUNCj4gDQo+ID4gDQo+ID4gLS0tLS1PcmlnaW5hbCBN
ZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBkbWFlbmdpbmUtb3duZXJAdmdlci5rZXJuZWwub3JnDQo+
ID4gW21haWx0bzpkbWFlbmdpbmUtb3duZXJAdmdlci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2Yg
QWRhbSBXYWxsaXMNCj4gPiBTZW50OiAyMDE45bm0MeaciDIz5pelIDIyOjMyDQo+ID4gVG86IFlh
bmcgU2h1bnlvbmcgPHNodW55b25nLnlhbmdAaHh0LXNlbWl0ZWNoLmNvbT47DQo+ID4gdmlub2Qu
a291bEBpbnRlbC5jb20NCj4gPiBDYzogZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tOyB5dS56aGVu
Z0BoeHQtc2VtaXRlY2guY29tOw0KPiA+IGRtYWVuZ2luZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4
LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IEdyYWhhbQ0KPiA+IE1vb3JlDQo+ID4gPGdyYWhhbS5t
b29yZUBsaW51eC5pbnRlbC5jb20+OyBva2F5YUBjb2RlYXVyb3JhLm9yZyA+PiBTaW5hbiBLYXlh
DQo+ID4gPG9rYXlhQGNvZGVhdXJvcmEub3JnPg0KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRt
YWVuZ2luZTogZG1hdGVzdDogZml4IGNvbnRhaW5lcl9vZiBtZW1iZXIgaW4NCj4gPiBkbWF0ZXN0
X2NhbGxiYWNrDQo+ID4gDQo+ID4gT24gMS8yMi8yMDE4IDI6MjggQU0sIFlhbmcgU2h1bnlvbmcg
d3JvdGU6DQo+ID4gPiANCj4gPiA+IFRoZSB0eXBlIG9mIGFyZyBwYXNzZWQgdG8gZG1hdGVzdF9j
YWxsYmFjayBpcyBzdHJ1Y3QNCj4gPiA+IGRtYXRlc3RfZG9uZS4NCj4gPiA+IEl0IHJlZmVycyB0
byB0ZXN0X2RvbmUgaW4gc3RydWN0IGRtYXRlc3RfdGhyZWFkLCBub3QgZG9uZV93YWl0Lg0KPiA+
ID4gDQo+ID4gPiBGaXhlczogNmY2YTIzYTIxM2JlICgiZG1hZW5naW5lOiBkbWF0ZXN0OiBtb3Zl
IGNhbGxiYWNrIHdhaXQNCj4gPiA+IC4uLiIpDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZYW5nIFNo
dW55b25nIDxzaHVueW9uZy55YW5nQGh4dC1zZW1pdGVjaC5jb20+DQo+ID4gPiAtLS0NCj4gPiA+
IMKgZHJpdmVycy9kbWEvZG1hdGVzdC5jIHwgMiArLQ0KPiA+ID4gwqAxIGZpbGUgY2hhbmdlZCwg
MSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gPiA+IA0KPiA+ID4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZG1hL2RtYXRlc3QuYyBiL2RyaXZlcnMvZG1hL2RtYXRlc3QuYyBpbmRleA0KPiA+
ID4gZWM1ZjlkMmJjODIwLi45MDZlODVkNmRlZGMgMTAwNjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJz
L2RtYS9kbWF0ZXN0LmMNCj4gPiA+ICsrKyBiL2RyaXZlcnMvZG1hL2RtYXRlc3QuYw0KPiA+ID4g
QEAgLTM1NSw3ICszNTUsNyBAQCBzdGF0aWMgdm9pZCBkbWF0ZXN0X2NhbGxiYWNrKHZvaWQgKmFy
ZynCoMKgew0KPiA+ID4gwqAJc3RydWN0IGRtYXRlc3RfZG9uZSAqZG9uZSA9IGFyZzsNCj4gPiA+
IMKgCXN0cnVjdCBkbWF0ZXN0X3RocmVhZCAqdGhyZWFkID0NCj4gPiA+IC0JCWNvbnRhaW5lcl9v
ZihhcmcsIHN0cnVjdCBkbWF0ZXN0X3RocmVhZCwNCj4gPiA+IGRvbmVfd2FpdCk7DQo+ID4gPiAr
CQljb250YWluZXJfb2YoYXJnLCBzdHJ1Y3QgZG1hdGVzdF90aHJlYWQsDQo+ID4gPiB0ZXN0X2Rv
bmUpOw0KPiA+ID4gwqAJaWYgKCF0aHJlYWQtPmRvbmUpIHsNCj4gPiA+IMKgCQlkb25lLT5kb25l
ID0gdHJ1ZTsNCj4gPiA+IMKgCQl3YWtlX3VwX2FsbChkb25lLT53YWl0KTsNCj4gPiA+IA0KPiA+
IFRoYW5rcyBmb3IgdGhlIGNhdGNoDQo+ID4gDQo+ID4gQWNrZWQtYnk6IEFkYW0gV2FsbGlzIDxh
d2FsbGlzQGNvZGVhdXJvcmEub3JnPg0KPiA+IC0tDQo+ID4gQWRhbSBXYWxsaXMNCj4gPiBRdWFs
Y29tbSBEYXRhY2VudGVyIFRlY2hub2xvZ2llcyBhcyBhbiBhZmZpbGlhdGUgb2YgUXVhbGNvbW0N
Cj4gPiBUZWNobm9sb2dpZXMsDQo+ID4gSW5jLg0KPiA+IFF1YWxjb21tIFRlY2hub2xvZ2llcywg
SW5jLiBpcyBhIG1lbWJlciBvZiB0aGUgQ29kZSBBdXJvcmEgRm9ydW0sIGENCj4gPiBMaW51eA0K
PiA+IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Lg0KPiA+IC0tDQo+ID4gVG8gdW5z
dWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlDQo+ID4g
ZG1hZW5naW5lIiBpbiB0aGUNCj4gPiBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdl
ci5rZXJuZWwub3JnIE1vcmUgbWFqb3Jkb21vIGluZm8NCj4gPiBhdA0KPiA+IGh0dHBzOi8vZW1l
YTAxLnNhZmVsaW5rcy5wcm90ZWN0aW9uLm91dGxvb2suY29tLz91cmw9aHR0cCUzQSUyRiUyRnYN
Cj4gPiBnZXIuDQo+ID4ga2VybmVsLm9yZyUyRm1ham9yZG9tby1pbmZvLmh0bWwmZGF0YT0wMiU3
QzAxJTdDd2VuLmhlXzElNDBueHAuY28NCj4gPiBtJTdDODgxNjE1NjhhN2ZkNDM0OTE0OWIwOGQ1
NjI2ZTE2NjElN0M2ODZlYTFkM2JjMmI0YzZmYTkyY2Q5DQo+ID4gOWM1YzMwMTYzNSU3QzAlN0Mw
JTdDNjM2NTIzMTQ3MzU0MTk2NjIyJnNkYXRhPXR4SXRndkQzUCUyRnJRcQ0KPiA+IE1TbXBabFRZ
MXJBMXlVZVd4TUhUbEVMTzV2d3k4NCUzRCZyZXNlcnZlZD0w
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

[Yang, Shunyong]

Hi, Wen

You're welcome. That's why call this COMMUNITY! :-)

Shunyong.
Thanks.

On Sun, 2018-02-11 at 09:28 +0000, Wen He wrote:
> Thanks for you, Shunyong.
> 
> Best Regards,
> Wen He
> 
> > 
> > -----Original Message-----
> > From: dmaengine-owner@vger.kernel.org
> > [mailto:dmaengine-owner@vger.kernel.org] On Behalf Of Adam Wallis
> > Sent: 2018年1月23日 22:32
> > To: Yang Shunyong <shunyong.yang@hxt-semitech.com>;
> > vinod.koul@intel.com
> > Cc: dan.j.williams@intel.com; yu.zheng@hxt-semitech.com;
> > dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org; Graham
> > Moore
> > <graham.moore@linux.intel.com>; okaya@codeaurora.org >> Sinan Kaya
> > <okaya@codeaurora.org>
> > Subject: Re: [PATCH] dmaengine: dmatest: fix container_of member in
> > dmatest_callback
> > 
> > On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> > > 
> > > The type of arg passed to dmatest_callback is struct
> > > dmatest_done.
> > > It refers to test_done in struct dmatest_thread, not done_wait.
> > > 
> > > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait
> > > ...")
> > > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > > ---
> > >  drivers/dma/dmatest.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index
> > > ec5f9d2bc820..906e85d6dedc 100644
> > > --- a/drivers/dma/dmatest.c
> > > +++ b/drivers/dma/dmatest.c
> > > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)  {
> > >  	struct dmatest_done *done = arg;
> > >  	struct dmatest_thread *thread =
> > > -		container_of(arg, struct dmatest_thread,
> > > done_wait);
> > > +		container_of(arg, struct dmatest_thread,
> > > test_done);
> > >  	if (!thread->done) {
> > >  		done->done = true;
> > >  		wake_up_all(done->wait);
> > > 
> > Thanks for the catch
> > 
> > Acked-by: Adam Wallis <awallis@codeaurora.org>
> > --
> > Adam Wallis
> > Qualcomm Datacenter Technologies as an affiliate of Qualcomm
> > Technologies,
> > Inc.
> > Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a
> > Linux
> > Foundation Collaborative Project.
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > dmaengine" in the
> > body of a message to majordomo@vger.kernel.org More majordomo info
> > at
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fv
> > ger.
> > kernel.org%2Fmajordomo-info.html&data=02%7C01%7Cwen.he_1%40nxp.co
> > m%7C88161568a7fd4349149b08d5626e1661%7C686ea1d3bc2b4c6fa92cd9
> > 9c5c301635%7C0%7C0%7C636523147354196622&sdata=txItgvD3P%2FrQq
> > MSmpZlTY1rA1yUeWxMHTlELO5vwy84%3D&reserved=0