All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/etnaviv: fix '%x' warning
@ 2018-01-23 17:07 Gustavo A. R. Silva
  2018-01-24 11:57   ` Lucas Stach
  0 siblings, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-23 17:07 UTC (permalink / raw)
  To: Lucas Stach, Russell King, Christian Gmeiner, David Airlie
  Cc: etnaviv, dri-devel, linux-kernel, Gustavo A. R. Silva

Fix the following warning by using %zx instead of %x for variable of
type size_t:

warning: format ‘%x’ expects argument of type ‘unsigned int’, but
argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]

Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
This code was compiled with GCC 7.2.0

 drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index d113fe0..49e0497 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
 	size_t pgsize = SZ_4K;
 
 	if (!IS_ALIGNED(iova | size, pgsize)) {
-		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
 		       iova, size, pgsize);
 		return;
 	}
@@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
 	int ret = 0;
 
 	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
-		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
 		       iova, &paddr, size, pgsize);
 		return -EINVAL;
 	}
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/etnaviv: fix '%x' warning
  2018-01-23 17:07 [PATCH] drm/etnaviv: fix '%x' warning Gustavo A. R. Silva
@ 2018-01-24 11:57   ` Lucas Stach
  0 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2018-01-24 11:57 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Russell King, Christian Gmeiner, David Airlie
  Cc: etnaviv, dri-devel, linux-kernel, Gustavo A. R. Silva

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
> Fix the following warning by using %zx instead of %x for variable of
> type size_t:
> 
> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
> 
> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks for the patch, but I already have an equivalent change queued up.

Regards,
Lucas

> ---
> This code was compiled with GCC 7.2.0
> 
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index d113fe0..49e0497 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
> >  	size_t pgsize = SZ_4K;
>  
> >  	if (!IS_ALIGNED(iova | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, size, pgsize);
> >  		return;
> >  	}
> @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
> >  	int ret = 0;
>  
> >  	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, &paddr, size, pgsize);
> >  		return -EINVAL;
> >  	}

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/etnaviv: fix '%x' warning
@ 2018-01-24 11:57   ` Lucas Stach
  0 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2018-01-24 11:57 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Russell King, Christian Gmeiner, David Airlie
  Cc: Gustavo A. R. Silva, etnaviv, dri-devel, linux-kernel

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
> Fix the following warning by using %zx instead of %x for variable of
> type size_t:
> 
> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
> 
> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks for the patch, but I already have an equivalent change queued up.

Regards,
Lucas

> ---
> This code was compiled with GCC 7.2.0
> 
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index d113fe0..49e0497 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
> >  	size_t pgsize = SZ_4K;
>  
> >  	if (!IS_ALIGNED(iova | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, size, pgsize);
> >  		return;
> >  	}
> @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
> >  	int ret = 0;
>  
> >  	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, &paddr, size, pgsize);
> >  		return -EINVAL;
> >  	}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/etnaviv: fix '%x' warning
  2018-01-24 11:57   ` Lucas Stach
  (?)
@ 2018-01-24 19:39   ` Gustavo A. R. Silva
  -1 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-24 19:39 UTC (permalink / raw)
  To: Lucas Stach
  Cc: Gustavo A. R. Silva, Russell King, Christian Gmeiner,
	David Airlie, etnaviv, dri-devel, linux-kernel

Hello Lucas,

Quoting Lucas Stach <l.stach@pengutronix.de>:

> Hi Gustavo,
>
> Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
>> Fix the following warning by using %zx instead of %x for variable of
>> type size_t:
>>
>> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
>> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>>
>> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap  
>> functions")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thanks for the patch, but I already have an equivalent change queued up.
>

That's great. I'm glad it is already fixed.

Thanks
--
Gustavo

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-24 19:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23 17:07 [PATCH] drm/etnaviv: fix '%x' warning Gustavo A. R. Silva
2018-01-24 11:57 ` Lucas Stach
2018-01-24 11:57   ` Lucas Stach
2018-01-24 19:39   ` Gustavo A. R. Silva

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.