All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 13/24] mmc: omap_hsmmc: allow the simple HS modes to use the default pinctrl
Date: Thu, 25 Jan 2018 11:51:39 +0100	[thread overview]
Message-ID: <1516877510-14863-14-git-send-email-jjhiblot@ti.com> (raw)
In-Reply-To: <1516877510-14863-1-git-send-email-jjhiblot@ti.com>

The default configuration is usually working fine for the the HS modes.
Don't enforce the presence of a dedicated pinmux for the HS modes.

Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---

 drivers/mmc/omap_hsmmc.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
index a2d68f7..052162b 100644
--- a/drivers/mmc/omap_hsmmc.c
+++ b/drivers/mmc/omap_hsmmc.c
@@ -328,6 +328,9 @@ static void omap_hsmmc_io_recalibrate(struct mmc *mmc)
 		break;
 	}
 
+	if (!pinctrl_state)
+		pinctrl_state = priv->default_pinctrl_state;
+
 	if (priv->controller_flags & OMAP_HSMMC_REQUIRE_IODELAY) {
 		if (pinctrl_state->iodelay)
 			late_recalibrate_iodelay(pinctrl_state->padconf,
@@ -1589,7 +1592,7 @@ err_pinctrl_state:
 	return 0;
 }
 
-#define OMAP_HSMMC_SETUP_PINCTRL(capmask, mode)				\
+#define OMAP_HSMMC_SETUP_PINCTRL(capmask, mode, optional)		\
 	do {								\
 		struct omap_hsmmc_pinctrl_state *s = NULL;		\
 		char str[20];						\
@@ -1604,7 +1607,7 @@ err_pinctrl_state:
 		if (!s)							\
 			s = omap_hsmmc_get_pinctrl_by_mode(mmc, #mode);	\
 									\
-		if (!s) {						\
+		if (!s && !optional) {					\
 			debug("%s: no pinctrl for %s\n",		\
 			      mmc->dev->name, #mode);			\
 			cfg->host_caps &= ~(capmask);			\
@@ -1630,15 +1633,15 @@ static int omap_hsmmc_get_pinctrl_state(struct mmc *mmc)
 
 	priv->default_pinctrl_state = default_pinctrl;
 
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR104), sdr104);
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR50), sdr50);
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_DDR50), ddr50);
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR25), sdr25);
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR12), sdr12);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR104), sdr104, false);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR50), sdr50, false);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_DDR50), ddr50, false);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR25), sdr25, false);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(UHS_SDR12), sdr12, false);
 
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(MMC_HS_200), hs200_1_8v);
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(MMC_DDR_52), ddr_1_8v);
-	OMAP_HSMMC_SETUP_PINCTRL(MMC_MODE_HS, hs);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(MMC_HS_200), hs200_1_8v, false);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_CAP(MMC_DDR_52), ddr_1_8v, false);
+	OMAP_HSMMC_SETUP_PINCTRL(MMC_MODE_HS, hs, true);
 
 	return 0;
 }
-- 
1.9.1

  parent reply	other threads:[~2018-01-25 10:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180125105204epcas1p33c3b7c1ace6aae2cfd1da807e869ad7e@epcas1p3.samsung.com>
2018-01-25 10:51 ` [U-Boot] [PATCH v2 00/24] omap_hsmmc: Add support for HS200 and UHS modes Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 01/24] mmc: omap_hsmmc: cleanup clock configuration Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 02/24] mmc: omap_hsmmc: cleanup omap_hsmmc_set_ios Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 03/24] mmc: omap_hsmmc: add support to set default io voltage Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 04/24] mmc: omap_hsmmc: set MMC mode in the UHSMS bit field Jean-Jacques Hiblot
2018-01-29  4:33     ` Jaehoon Chung
2018-01-29 13:26       ` Jaehoon Chung
2018-01-30 13:40       ` Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 05/24] mmc: omap_hsmmc: Enable DDR mode support Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 06/24] mmc: omap_hsmmc: Add tuning support Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 07/24] mmc: omap_hsmmc: Workaround for errata id i802 Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 08/24] mmc: omap_hsmmc: Reduce the max timeout for reset controller fsm Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 09/24] mmc: omap_hsmmc: use mmc_of_parse to populate mmc_config Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 10/24] ARM: OMAP5/DRA7: Enable iodelay recalibration to be done from uboot Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 11/24] mmc: omap_hsmmc: Add support to set IODELAY values Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 12/24] mmc: omap_hsmmc: Add support to get pinctrl values and max frequency for different hw revisions Jean-Jacques Hiblot
2018-01-25 10:51   ` Jean-Jacques Hiblot [this message]
2018-01-25 10:51   ` [U-Boot] [PATCH v2 14/24] mmc: omap_hsmmc: update mmc->clock with the actual bus speed Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 15/24] mmc: omap_hsmmc: implement send_init_stream callback Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 16/24] mmc: omap_hsmmc: allow mmc clock to be gated Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 17/24] mmc: omap_hsmmc: add signal voltage selection support Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 18/24] ARM: OMAP5: set mmc clock frequency to 192MHz Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 19/24] ARM: dts: DRA7: use new dra7-specific compatible string Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 20/24] ARM: dts: dra7: Add supported MMC/SD modes in MMC dt nodes Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 21/24] dts: am57xx-beagle-x15: disable UHS and HS200 support Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 22/24] dts: am57xx-idk: disable " Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 23/24] ARM: DRA7x/AM57x: Add MMC/SD fixups for rev1.0 and rev 1.1 Jean-Jacques Hiblot
2018-01-25 10:51   ` [U-Boot] [PATCH v2 24/24] configs: dra7xx_evm/dra7xx_hs_evm: Enable MMC HS200 and SD UHS support Jean-Jacques Hiblot
2018-01-25 11:14   ` [U-Boot] [PATCH v2 00/24] omap_hsmmc: Add support for HS200 and UHS modes Jaehoon Chung
2018-01-29  4:45   ` Lokesh Vutla
2018-01-29 10:20     ` Jean-Jacques Hiblot
2018-01-30  5:17   ` Jaehoon Chung
2018-01-30 13:30     ` Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516877510-14863-14-git-send-email-jjhiblot@ti.com \
    --to=jjhiblot@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.