All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taras Kondratiuk <takondra@cisco.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
	James McMechan <james.w.mcmechan@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Rob Landley <rob@landley.net>
Cc: initramfs@vger.kernel.org, Victor Kamensky <kamensky@cisco.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	xe-linux-external@cisco.com
Subject: Re: [PATCH v2 01/15] Documentation: add newcx initramfs format description
Date: Fri, 26 Jan 2018 13:02:52 -0800	[thread overview]
Message-ID: <151700057225.21956.4502484965110175077@takondra-t460s> (raw)
In-Reply-To: <da9b623c-dd0c-9aff-8eaa-43afa4714b34@landley.net>

Quoting Rob Landley (2018-01-25 18:40:54)
> On 01/24/2018 09:27 PM, Taras Kondratiuk wrote:
> > diff --git a/Documentation/early-userspace/buffer-format.txt b/Documentation/early-userspace/buffer-format.txt
> > index e1fd7f9dad16..d818df4f72dc 100644
> > --- a/Documentation/early-userspace/buffer-format.txt
> > +++ b/Documentation/early-userspace/buffer-format.txt
> 
> > +compressed and/or uncompressed cpio archives; arbitrary amounts
> > +zero bytes (for padding) can be added between members.
> 
> Missing "of" between amounts and zero. (Yeah it was in the original, but
> if you're touching it anyway...)
> 
> > +c_xattrs_size  8 bytes                Size of xattrs field
> > +
> > +Most of the fields match cpio_newc_header except c_mtime that contains
> > +microseconds. c_chksum field is dropped.
> > +
> > +xattr_size is a total size of xattr_entry including 8 bytes of
> > +xattr_size. xattr_size has the same hexadecimal ASCII encoding as other
> > +fields of cpio header.
> 
> xattrs_size or xattr_size?
> 
> Total nitpicks, I know. :)

xattr_size here refers to size of each xattr_entry:
xattr_entry := xattr_size[8] + xattr_name + "\0" + xattr_value

I'll move this paragraph closer to that line.

WARNING: multiple messages have this Message-ID (diff)
From: takondra@cisco.com (Taras Kondratiuk)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 01/15] Documentation: add newcx initramfs format description
Date: Fri, 26 Jan 2018 13:02:52 -0800	[thread overview]
Message-ID: <151700057225.21956.4502484965110175077@takondra-t460s> (raw)
In-Reply-To: <da9b623c-dd0c-9aff-8eaa-43afa4714b34@landley.net>

Quoting Rob Landley (2018-01-25 18:40:54)
> On 01/24/2018 09:27 PM, Taras Kondratiuk wrote:
> > diff --git a/Documentation/early-userspace/buffer-format.txt b/Documentation/early-userspace/buffer-format.txt
> > index e1fd7f9dad16..d818df4f72dc 100644
> > --- a/Documentation/early-userspace/buffer-format.txt
> > +++ b/Documentation/early-userspace/buffer-format.txt
> 
> > +compressed and/or uncompressed cpio archives; arbitrary amounts
> > +zero bytes (for padding) can be added between members.
> 
> Missing "of" between amounts and zero. (Yeah it was in the original, but
> if you're touching it anyway...)
> 
> > +c_xattrs_size  8 bytes                Size of xattrs field
> > +
> > +Most of the fields match cpio_newc_header except c_mtime that contains
> > +microseconds. c_chksum field is dropped.
> > +
> > +xattr_size is a total size of xattr_entry including 8 bytes of
> > +xattr_size. xattr_size has the same hexadecimal ASCII encoding as other
> > +fields of cpio header.
> 
> xattrs_size or xattr_size?
> 
> Total nitpicks, I know. :)

xattr_size here refers to size of each xattr_entry:
xattr_entry := xattr_size[8] + xattr_name + "\0" + xattr_value

I'll move this paragraph closer to that line.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-01-26 21:03 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  3:27 [PATCH v2 00/15] extend initramfs archive format to support xattrs Taras Kondratiuk
2018-01-25  3:27 ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 01/15] Documentation: add newcx initramfs format description Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  9:29   ` Arnd Bergmann
2018-01-25  9:29     ` Arnd Bergmann
2018-01-25 20:26     ` Taras Kondratiuk
2018-01-25 20:26       ` Taras Kondratiuk
2018-01-25 20:26       ` Taras Kondratiuk
2018-01-25 21:02       ` Arnd Bergmann
2018-01-25 21:02         ` Arnd Bergmann
2018-01-25 22:13         ` Taras Kondratiuk
2018-01-25 22:13           ` Taras Kondratiuk
2018-01-26  2:39     ` Rob Landley
2018-01-26  2:39       ` Rob Landley
2018-01-26  9:04       ` Arnd Bergmann
2018-01-26  9:04         ` Arnd Bergmann
2018-01-26 10:31       ` Henrique de Moraes Holschuh
2018-01-26 10:31         ` Henrique de Moraes Holschuh
2018-01-26 15:51         ` Victor Kamensky
2018-01-26 15:51           ` Victor Kamensky
2018-01-26 18:15           ` Henrique de Moraes Holschuh
2018-01-26 18:15             ` Henrique de Moraes Holschuh
2018-01-26 18:15             ` Henrique de Moraes Holschuh
2018-01-26  2:40   ` Rob Landley
2018-01-26  2:40     ` Rob Landley
2018-01-26 21:02     ` Taras Kondratiuk [this message]
2018-01-26 21:02       ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 02/15] initramfs: replace states with function pointers Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 03/15] initramfs: store file name in name_buf Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 04/15] initramfs: remove unnecessary symlinks processing shortcut Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 05/15] initramfs: move files creation into separate state Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 06/15] initramfs: separate reading cpio method from header Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 07/15] initramfs: split header layout information from parsing function Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 08/15] initramfs: add newcx format Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 09/15] initramfs: set extended attributes Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 10/15] gen_init_cpio: move header formatting into function Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 11/15] gen_init_cpio: add newcx format Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-26  2:40   ` Rob Landley
2018-01-26  2:40     ` Rob Landley
2018-01-26 20:37     ` Taras Kondratiuk
2018-01-26 20:37       ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 12/15] gen_init_cpio: set extended attributes for " Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 13/15] gen_initramfs_list.sh: add -x option to enable " Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25  3:27 ` [PATCH v2 14/15] selinux: allow setxattr on rootfs so initramfs code can set them Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25 13:51   ` [Fwd: [PATCH v2 14/15] selinux: allow setxattr on rootfs so initramfs code can set them] Stephen Smalley
2018-01-25  3:27 ` [PATCH v2 15/15] selinux: delay sid population for rootfs till init is complete Taras Kondratiuk
2018-01-25  3:27   ` Taras Kondratiuk
2018-01-25 13:48   ` [Fwd: [PATCH v2 15/15] selinux: delay sid population for rootfs till init is complete] Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151700057225.21956.4502484965110175077@takondra-t460s \
    --to=takondra@cisco.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=hpa@zytor.com \
    --cc=initramfs@vger.kernel.org \
    --cc=james.w.mcmechan@gmail.com \
    --cc=kamensky@cisco.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xe-linux-external@cisco.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.