All of lore.kernel.org
 help / color / mirror / Atom feed
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-01-22 10:44 ` Yang Shunyong
  0 siblings, 0 replies; 22+ messages in thread
From: Yang Shunyong @ 2018-01-22 10:44 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel, Yang Shunyong

Current coding style prefers octal permissions values. This patch
changes symbolic permissions to octal values.

Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
---
 drivers/dma/dmatest.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ec5f9d2..4cdccc3 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -24,60 +24,58 @@
 #include <linux/wait.h>
 
 static unsigned int test_buf_size = 16384;
-module_param(test_buf_size, uint, S_IRUGO | S_IWUSR);
+module_param(test_buf_size, uint, 0644);
 MODULE_PARM_DESC(test_buf_size, "Size of the memcpy test buffer");
 
 static char test_channel[20];
-module_param_string(channel, test_channel, sizeof(test_channel),
-		S_IRUGO | S_IWUSR);
+module_param_string(channel, test_channel, sizeof(test_channel), 0644);
 MODULE_PARM_DESC(channel, "Bus ID of the channel to test (default: any)");
 
 static char test_device[32];
-module_param_string(device, test_device, sizeof(test_device),
-		S_IRUGO | S_IWUSR);
+module_param_string(device, test_device, sizeof(test_device), 0644);
 MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
 
 static unsigned int threads_per_chan = 1;
-module_param(threads_per_chan, uint, S_IRUGO | S_IWUSR);
+module_param(threads_per_chan, uint, 0644);
 MODULE_PARM_DESC(threads_per_chan,
 		"Number of threads to start per channel (default: 1)");
 
 static unsigned int max_channels;
-module_param(max_channels, uint, S_IRUGO | S_IWUSR);
+module_param(max_channels, uint, 0644);
 MODULE_PARM_DESC(max_channels,
 		"Maximum number of channels to use (default: all)");
 
 static unsigned int iterations;
-module_param(iterations, uint, S_IRUGO | S_IWUSR);
+module_param(iterations, uint, 0644);
 MODULE_PARM_DESC(iterations,
 		"Iterations before stopping test (default: infinite)");
 
 static unsigned int dmatest;
-module_param(dmatest, uint, S_IRUGO | S_IWUSR);
+module_param(dmatest, uint, 0644);
 MODULE_PARM_DESC(dmatest,
 		"dmatest 0-memcpy 1-memset (default: 0)");
 
 static unsigned int xor_sources = 3;
-module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
+module_param(xor_sources, uint, 0644);
 MODULE_PARM_DESC(xor_sources,
 		"Number of xor source buffers (default: 3)");
 
 static unsigned int pq_sources = 3;
-module_param(pq_sources, uint, S_IRUGO | S_IWUSR);
+module_param(pq_sources, uint, 0644);
 MODULE_PARM_DESC(pq_sources,
 		"Number of p+q source buffers (default: 3)");
 
 static int timeout = 3000;
-module_param(timeout, uint, S_IRUGO | S_IWUSR);
+module_param(timeout, uint, 0644);
 MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), "
 		 "Pass -1 for infinite timeout");
 
 static bool noverify;
-module_param(noverify, bool, S_IRUGO | S_IWUSR);
+module_param(noverify, bool, 0644);
 MODULE_PARM_DESC(noverify, "Disable random data setup and verification");
 
 static bool verbose;
-module_param(verbose, bool, S_IRUGO | S_IWUSR);
+module_param(verbose, bool, 0644);
 MODULE_PARM_DESC(verbose, "Enable \"success\" result messages (default: off)");
 
 /**
@@ -131,7 +129,7 @@ struct dmatest_params {
 	.get = dmatest_run_get,
 };
 static bool dmatest_run;
-module_param_cb(run, &run_ops, &dmatest_run, S_IRUGO | S_IWUSR);
+module_param_cb(run, &run_ops, &dmatest_run, 0644);
 MODULE_PARM_DESC(run, "Run the test (default: false)");
 
 /* Maximum amount of mismatched bytes in buffer to print */
@@ -216,7 +214,7 @@ static int dmatest_wait_get(char *val, const struct kernel_param *kp)
 	.get = dmatest_wait_get,
 	.set = param_set_bool,
 };
-module_param_cb(wait, &wait_ops, &wait, S_IRUGO);
+module_param_cb(wait, &wait_ops, &wait, 0444);
 MODULE_PARM_DESC(wait, "Wait for tests to complete (default: false)");
 
 static bool dmatest_match_channel(struct dmatest_params *params,

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-01-22 10:44 ` Yang Shunyong
  0 siblings, 0 replies; 22+ messages in thread
From: Yang Shunyong @ 2018-01-22 10:44 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel, Yang Shunyong

Current coding style prefers octal permissions values. This patch
changes symbolic permissions to octal values.

Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
---
 drivers/dma/dmatest.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index ec5f9d2..4cdccc3 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -24,60 +24,58 @@
 #include <linux/wait.h>
 
 static unsigned int test_buf_size = 16384;
-module_param(test_buf_size, uint, S_IRUGO | S_IWUSR);
+module_param(test_buf_size, uint, 0644);
 MODULE_PARM_DESC(test_buf_size, "Size of the memcpy test buffer");
 
 static char test_channel[20];
-module_param_string(channel, test_channel, sizeof(test_channel),
-		S_IRUGO | S_IWUSR);
+module_param_string(channel, test_channel, sizeof(test_channel), 0644);
 MODULE_PARM_DESC(channel, "Bus ID of the channel to test (default: any)");
 
 static char test_device[32];
-module_param_string(device, test_device, sizeof(test_device),
-		S_IRUGO | S_IWUSR);
+module_param_string(device, test_device, sizeof(test_device), 0644);
 MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
 
 static unsigned int threads_per_chan = 1;
-module_param(threads_per_chan, uint, S_IRUGO | S_IWUSR);
+module_param(threads_per_chan, uint, 0644);
 MODULE_PARM_DESC(threads_per_chan,
 		"Number of threads to start per channel (default: 1)");
 
 static unsigned int max_channels;
-module_param(max_channels, uint, S_IRUGO | S_IWUSR);
+module_param(max_channels, uint, 0644);
 MODULE_PARM_DESC(max_channels,
 		"Maximum number of channels to use (default: all)");
 
 static unsigned int iterations;
-module_param(iterations, uint, S_IRUGO | S_IWUSR);
+module_param(iterations, uint, 0644);
 MODULE_PARM_DESC(iterations,
 		"Iterations before stopping test (default: infinite)");
 
 static unsigned int dmatest;
-module_param(dmatest, uint, S_IRUGO | S_IWUSR);
+module_param(dmatest, uint, 0644);
 MODULE_PARM_DESC(dmatest,
 		"dmatest 0-memcpy 1-memset (default: 0)");
 
 static unsigned int xor_sources = 3;
-module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
+module_param(xor_sources, uint, 0644);
 MODULE_PARM_DESC(xor_sources,
 		"Number of xor source buffers (default: 3)");
 
 static unsigned int pq_sources = 3;
-module_param(pq_sources, uint, S_IRUGO | S_IWUSR);
+module_param(pq_sources, uint, 0644);
 MODULE_PARM_DESC(pq_sources,
 		"Number of p+q source buffers (default: 3)");
 
 static int timeout = 3000;
-module_param(timeout, uint, S_IRUGO | S_IWUSR);
+module_param(timeout, uint, 0644);
 MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), "
 		 "Pass -1 for infinite timeout");
 
 static bool noverify;
-module_param(noverify, bool, S_IRUGO | S_IWUSR);
+module_param(noverify, bool, 0644);
 MODULE_PARM_DESC(noverify, "Disable random data setup and verification");
 
 static bool verbose;
-module_param(verbose, bool, S_IRUGO | S_IWUSR);
+module_param(verbose, bool, 0644);
 MODULE_PARM_DESC(verbose, "Enable \"success\" result messages (default: off)");
 
 /**
@@ -131,7 +129,7 @@ struct dmatest_params {
 	.get = dmatest_run_get,
 };
 static bool dmatest_run;
-module_param_cb(run, &run_ops, &dmatest_run, S_IRUGO | S_IWUSR);
+module_param_cb(run, &run_ops, &dmatest_run, 0644);
 MODULE_PARM_DESC(run, "Run the test (default: false)");
 
 /* Maximum amount of mismatched bytes in buffer to print */
@@ -216,7 +214,7 @@ static int dmatest_wait_get(char *val, const struct kernel_param *kp)
 	.get = dmatest_wait_get,
 	.set = param_set_bool,
 };
-module_param_cb(wait, &wait_ops, &wait, S_IRUGO);
+module_param_cb(wait, &wait_ops, &wait, 0444);
 MODULE_PARM_DESC(wait, "Wait for tests to complete (default: false)");
 
 static bool dmatest_match_channel(struct dmatest_params *params,
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [2/2] dmaengine: dmatest: add norandom option
  2018-01-22 10:44 ` [PATCH 1/2] " Yang Shunyong
@ 2018-01-22 10:44 ` Yang Shunyong
  -1 siblings, 0 replies; 22+ messages in thread
From: Yang Shunyong @ 2018-01-22 10:44 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel, Yang Shunyong

Existing option noverify disables both random src/dst address offset
setup and data verification. Sometimes, we need to control random
src/dst address setup and verification separately, such as disabling
random to make sure that test covers addresses in all interleaving
banks in one run. This patch adds option norandom to disable random
offset setup. Option noverify has been changed to disable data
verification only.

Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
---
 drivers/dma/dmatest.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 4cdccc3..cc3ab97 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -72,7 +72,11 @@
 
 static bool noverify;
 module_param(noverify, bool, 0644);
-MODULE_PARM_DESC(noverify, "Disable random data setup and verification");
+MODULE_PARM_DESC(noverify, "Disable data verification (default: verify)");
+
+static bool norandom;
+module_param(norandom, bool, 0644);
+MODULE_PARM_DESC(norandom, "Disable random offset setup (default: random)");
 
 static bool verbose;
 module_param(verbose, bool, 0644);
@@ -101,6 +105,7 @@ struct dmatest_params {
 	unsigned int	pq_sources;
 	int		timeout;
 	bool		noverify;
+	bool		norandom;
 };
 
 /**
@@ -573,7 +578,7 @@ static int dmatest_func(void *data)
 			break;
 		}
 
-		if (params->noverify)
+		if (params->norandom)
 			len = params->buf_size;
 		else
 			len = dmatest_random() % params->buf_size + 1;
@@ -584,17 +589,19 @@ static int dmatest_func(void *data)
 
 		total_len += len;
 
-		if (params->noverify) {
+		if (params->norandom) {
 			src_off = 0;
 			dst_off = 0;
 		} else {
-			start = ktime_get();
 			src_off = dmatest_random() % (params->buf_size - len + 1);
 			dst_off = dmatest_random() % (params->buf_size - len + 1);
 
 			src_off = (src_off >> align) << align;
 			dst_off = (dst_off >> align) << align;
+		}
 
+		if (!params->noverify) {
+			start = ktime_get();
 			dmatest_init_srcs(thread->srcs, src_off, len,
 					  params->buf_size, is_memset);
 			dmatest_init_dsts(thread->dsts, dst_off, len,
@@ -973,6 +980,7 @@ static void run_threaded_test(struct dmatest_info *info)
 	params->pq_sources = pq_sources;
 	params->timeout = timeout;
 	params->noverify = noverify;
+	params->norandom = norandom;
 
 	request_channels(info, DMA_MEMCPY);
 	request_channels(info, DMA_MEMSET);

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 2/2] dmaengine: dmatest: add norandom option
@ 2018-01-22 10:44 ` Yang Shunyong
  0 siblings, 0 replies; 22+ messages in thread
From: Yang Shunyong @ 2018-01-22 10:44 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel, Yang Shunyong

Existing option noverify disables both random src/dst address offset
setup and data verification. Sometimes, we need to control random
src/dst address setup and verification separately, such as disabling
random to make sure that test covers addresses in all interleaving
banks in one run. This patch adds option norandom to disable random
offset setup. Option noverify has been changed to disable data
verification only.

Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
---
 drivers/dma/dmatest.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 4cdccc3..cc3ab97 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -72,7 +72,11 @@
 
 static bool noverify;
 module_param(noverify, bool, 0644);
-MODULE_PARM_DESC(noverify, "Disable random data setup and verification");
+MODULE_PARM_DESC(noverify, "Disable data verification (default: verify)");
+
+static bool norandom;
+module_param(norandom, bool, 0644);
+MODULE_PARM_DESC(norandom, "Disable random offset setup (default: random)");
 
 static bool verbose;
 module_param(verbose, bool, 0644);
@@ -101,6 +105,7 @@ struct dmatest_params {
 	unsigned int	pq_sources;
 	int		timeout;
 	bool		noverify;
+	bool		norandom;
 };
 
 /**
@@ -573,7 +578,7 @@ static int dmatest_func(void *data)
 			break;
 		}
 
-		if (params->noverify)
+		if (params->norandom)
 			len = params->buf_size;
 		else
 			len = dmatest_random() % params->buf_size + 1;
@@ -584,17 +589,19 @@ static int dmatest_func(void *data)
 
 		total_len += len;
 
-		if (params->noverify) {
+		if (params->norandom) {
 			src_off = 0;
 			dst_off = 0;
 		} else {
-			start = ktime_get();
 			src_off = dmatest_random() % (params->buf_size - len + 1);
 			dst_off = dmatest_random() % (params->buf_size - len + 1);
 
 			src_off = (src_off >> align) << align;
 			dst_off = (dst_off >> align) << align;
+		}
 
+		if (!params->noverify) {
+			start = ktime_get();
 			dmatest_init_srcs(thread->srcs, src_off, len,
 					  params->buf_size, is_memset);
 			dmatest_init_dsts(thread->dsts, dst_off, len,
@@ -973,6 +980,7 @@ static void run_threaded_test(struct dmatest_info *info)
 	params->pq_sources = pq_sources;
 	params->timeout = timeout;
 	params->noverify = noverify;
+	params->norandom = norandom;
 
 	request_channels(info, DMA_MEMCPY);
 	request_channels(info, DMA_MEMSET);
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-01-22 10:44 ` [PATCH 1/2] " Yang Shunyong
@ 2018-01-29  4:48 ` Vinod Koul
  -1 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-01-29  4:48 UTC (permalink / raw)
  To: Yang Shunyong; +Cc: dan.j.williams, dmaengine, linux-kernel

On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> Current coding style prefers octal permissions values. This patch
> changes symbolic permissions to octal values.

Is this preference documented anywhere?

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-01-29  4:48 ` Vinod Koul
  0 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-01-29  4:48 UTC (permalink / raw)
  To: Yang Shunyong; +Cc: dan.j.williams, dmaengine, linux-kernel

On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> Current coding style prefers octal permissions values. This patch
> changes symbolic permissions to octal values.

Is this preference documented anywhere?

-- 
~Vinod

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-01-29  4:48 ` [PATCH 1/2] " Vinod Koul
@ 2018-01-29  6:26 ` Yang, Shunyong
  -1 siblings, 0 replies; 22+ messages in thread
From: Yang Shunyong @ 2018-01-29  6:26 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel

Hi, Vinod

On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > 
> > Current coding style prefers octal permissions values. This patch
> > changes symbolic permissions to octal values.
> Is this preference documented anywhere?
> 

When using symbolic permissions like "S_IRUGO | S_IWUSR". The
checkpatch.pl will output some warnings to suggest to use octal values.
I quote following lines from checkpatch.pl,

# check for uses of S_<PERMS> that could be octal for readability
...
if (WARN("SYMBOLIC_PERMS",
                                 "Symbolic permissions '$oval' are not
preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
&&
                            $fix) {
                                $fixed[$fixlinenr] =~ s/$val/$octal/;
                        }

Thanks.
Shunyong
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-01-29  6:26 ` Yang, Shunyong
  0 siblings, 0 replies; 22+ messages in thread
From: Yang, Shunyong @ 2018-01-29  6:26 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel

Hi, Vinod

On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > 
> > Current coding style prefers octal permissions values. This patch
> > changes symbolic permissions to octal values.
> Is this preference documented anywhere?
> 

When using symbolic permissions like "S_IRUGO | S_IWUSR". The
checkpatch.pl will output some warnings to suggest to use octal values.
I quote following lines from checkpatch.pl,

# check for uses of S_<PERMS> that could be octal for readability
...
if (WARN("SYMBOLIC_PERMS",
                                 "Symbolic permissions '$oval' are not
preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
&&
                            $fix) {
                                $fixed[$fixlinenr] =~ s/$val/$octal/;
                        }

Thanks.
Shunyong

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-01-29  6:26 ` Re: [PATCH 1/2] " Yang, Shunyong
@ 2018-01-30 10:04 ` Vinod Koul
  -1 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-01-30 10:04 UTC (permalink / raw)
  To: Yang, Shunyong; +Cc: dan.j.williams, dmaengine, linux-kernel

On Mon, Jan 29, 2018 at 06:26:40AM +0000, Yang, Shunyong wrote:
> Hi, Vinod
> 
> On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > > 
> > > Current coding style prefers octal permissions values. This patch
> > > changes symbolic permissions to octal values.
> > Is this preference documented anywhere?
> > 
> 
> When using symbolic permissions like "S_IRUGO | S_IWUSR". The
> checkpatch.pl will output some warnings to suggest to use octal values.
> I quote following lines from checkpatch.pl,
> 
> # check for uses of S_<PERMS> that could be octal for readability
> ...
> if (WARN("SYMBOLIC_PERMS",
>                                  "Symbolic permissions '$oval' are not
> preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
> &&

It is a warning and a preference. And I don't prefer changing code for no
benefit. Sorry but I am not considering this change

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-01-30 10:04 ` Vinod Koul
  0 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-01-30 10:04 UTC (permalink / raw)
  To: Yang, Shunyong; +Cc: dan.j.williams, dmaengine, linux-kernel

On Mon, Jan 29, 2018 at 06:26:40AM +0000, Yang, Shunyong wrote:
> Hi, Vinod
> 
> On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > > 
> > > Current coding style prefers octal permissions values. This patch
> > > changes symbolic permissions to octal values.
> > Is this preference documented anywhere?
> > 
> 
> When using symbolic permissions like "S_IRUGO | S_IWUSR". The
> checkpatch.pl will output some warnings to suggest to use octal values.
> I quote following lines from checkpatch.pl,
> 
> # check for uses of S_<PERMS> that could be octal for readability
> ...
> if (WARN("SYMBOLIC_PERMS",
>                                  "Symbolic permissions '$oval' are not
> preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
> &&

It is a warning and a preference. And I don't prefer changing code for no
benefit. Sorry but I am not considering this change

-- 
~Vinod

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [2/2] dmaengine: dmatest: add norandom option
  2018-01-22 10:44 ` [PATCH 2/2] " Yang Shunyong
@ 2018-01-31  7:34 ` Vinod Koul
  -1 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-01-31  7:34 UTC (permalink / raw)
  To: Yang Shunyong; +Cc: dan.j.williams, dmaengine, linux-kernel

On Mon, Jan 22, 2018 at 06:44:41PM +0800, Yang Shunyong wrote:
> Existing option noverify disables both random src/dst address offset
> setup and data verification. Sometimes, we need to control random
> src/dst address setup and verification separately, such as disabling
> random to make sure that test covers addresses in all interleaving
> banks in one run. This patch adds option norandom to disable random
> offset setup. Option noverify has been changed to disable data
> verification only.

This doesn't apply for me due to dependency on previous patch. Please rebase
and resend.

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] dmaengine: dmatest: add norandom option
@ 2018-01-31  7:34 ` Vinod Koul
  0 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-01-31  7:34 UTC (permalink / raw)
  To: Yang Shunyong; +Cc: dan.j.williams, dmaengine, linux-kernel

On Mon, Jan 22, 2018 at 06:44:41PM +0800, Yang Shunyong wrote:
> Existing option noverify disables both random src/dst address offset
> setup and data verification. Sometimes, we need to control random
> src/dst address setup and verification separately, such as disabling
> random to make sure that test covers addresses in all interleaving
> banks in one run. This patch adds option norandom to disable random
> offset setup. Option noverify has been changed to disable data
> verification only.

This doesn't apply for me due to dependency on previous patch. Please rebase
and resend.

-- 
~Vinod

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [2/2] dmaengine: dmatest: add norandom option
  2018-01-31  7:34 ` [PATCH 2/2] " Vinod Koul
@ 2018-01-31  7:38 ` Yang, Shunyong
  -1 siblings, 0 replies; 22+ messages in thread
From: Yang Shunyong @ 2018-01-31  7:38 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel

Hi, Vinod

On Wed, 2018-01-31 at 13:04 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 06:44:41PM +0800, Yang Shunyong wrote:
> > 
> > Existing option noverify disables both random src/dst address
> > offset
> > setup and data verification. Sometimes, we need to control random
> > src/dst address setup and verification separately, such as
> > disabling
> > random to make sure that test covers addresses in all interleaving
> > banks in one run. This patch adds option norandom to disable random
> > offset setup. Option noverify has been changed to disable data
> > verification only.
> This doesn't apply for me due to dependency on previous patch. Please
> rebase
> and resend.
> 

Thanks. I have finished the rebase. I will send out v2 patch when I
finish test.

Thanks.
Shunyong.--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: Re: [PATCH 2/2] dmaengine: dmatest: add norandom option
@ 2018-01-31  7:38 ` Yang, Shunyong
  0 siblings, 0 replies; 22+ messages in thread
From: Yang, Shunyong @ 2018-01-31  7:38 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel

Hi, Vinod

On Wed, 2018-01-31 at 13:04 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 06:44:41PM +0800, Yang Shunyong wrote:
> > 
> > Existing option noverify disables both random src/dst address
> > offset
> > setup and data verification. Sometimes, we need to control random
> > src/dst address setup and verification separately, such as
> > disabling
> > random to make sure that test covers addresses in all interleaving
> > banks in one run. This patch adds option norandom to disable random
> > offset setup. Option noverify has been changed to disable data
> > verification only.
> This doesn't apply for me due to dependency on previous patch. Please
> rebase
> and resend.
> 

Thanks. I have finished the rebase. I will send out v2 patch when I
finish test.

Thanks.
Shunyong.

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-01-29  4:48 ` [PATCH 1/2] " Vinod Koul
@ 2018-01-31 10:01 ` Viresh Kumar
  -1 siblings, 0 replies; 22+ messages in thread
From: Viresh Kumar @ 2018-01-31 10:01 UTC (permalink / raw)
  To: Vinod Koul; +Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Mon, Jan 29, 2018 at 10:18 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
>> Current coding style prefers octal permissions values. This patch
>> changes symbolic permissions to octal values.
>
> Is this preference documented anywhere?

This is where it started.

lkml.kernel.org/r/CA+55aFzu59sXo7qA8CoCo+tSJgEkW7fWDjkt_tsTzPWZ7gxj1A@mail.gmail.com
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-01-31 10:01 ` Viresh Kumar
  0 siblings, 0 replies; 22+ messages in thread
From: Viresh Kumar @ 2018-01-31 10:01 UTC (permalink / raw)
  To: Vinod Koul; +Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Mon, Jan 29, 2018 at 10:18 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
>> Current coding style prefers octal permissions values. This patch
>> changes symbolic permissions to octal values.
>
> Is this preference documented anywhere?

This is where it started.

lkml.kernel.org/r/CA+55aFzu59sXo7qA8CoCo+tSJgEkW7fWDjkt_tsTzPWZ7gxj1A@mail.gmail.com

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-01-31 10:01 ` [PATCH 1/2] " Viresh Kumar
@ 2018-02-01  3:45 ` Vinod Koul
  -1 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-02-01  3:45 UTC (permalink / raw)
  To: Viresh Kumar; +Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Wed, Jan 31, 2018 at 03:31:48PM +0530, Viresh Kumar wrote:
> On Mon, Jan 29, 2018 at 10:18 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> >> Current coding style prefers octal permissions values. This patch
> >> changes symbolic permissions to octal values.
> >
> > Is this preference documented anywhere?
> 
> This is where it started.
> 
> lkml.kernel.org/r/CA+55aFzu59sXo7qA8CoCo+tSJgEkW7fWDjkt_tsTzPWZ7gxj1A@mail.gmail.com

Right but lets no go changing to octals everywhere, new code sure :)
I don't see plans to remove representations entirely from kernel yet.

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-02-01  3:45 ` Vinod Koul
  0 siblings, 0 replies; 22+ messages in thread
From: Vinod Koul @ 2018-02-01  3:45 UTC (permalink / raw)
  To: Viresh Kumar; +Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Wed, Jan 31, 2018 at 03:31:48PM +0530, Viresh Kumar wrote:
> On Mon, Jan 29, 2018 at 10:18 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> >> Current coding style prefers octal permissions values. This patch
> >> changes symbolic permissions to octal values.
> >
> > Is this preference documented anywhere?
> 
> This is where it started.
> 
> lkml.kernel.org/r/CA+55aFzu59sXo7qA8CoCo+tSJgEkW7fWDjkt_tsTzPWZ7gxj1A@mail.gmail.com

Right but lets no go changing to octals everywhere, new code sure :)
I don't see plans to remove representations entirely from kernel yet.

-- 
~Vinod

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-02-01  3:45 ` [PATCH 1/2] " Vinod Koul
@ 2018-02-01  3:46 ` Viresh Kumar
  -1 siblings, 0 replies; 22+ messages in thread
From: Viresh Kumar @ 2018-02-01  3:46 UTC (permalink / raw)
  To: Vinod Koul; +Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Thu, Feb 1, 2018 at 9:15 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> Right but lets no go changing to octals everywhere, new code sure :)
> I don't see plans to remove representations entirely from kernel yet.

Sure. I was just pointing out to the discussion where the *preferred* thing
happened.
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-02-01  3:46 ` Viresh Kumar
  0 siblings, 0 replies; 22+ messages in thread
From: Viresh Kumar @ 2018-02-01  3:46 UTC (permalink / raw)
  To: Vinod Koul; +Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Thu, Feb 1, 2018 at 9:15 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> Right but lets no go changing to octals everywhere, new code sure :)
> I don't see plans to remove representations entirely from kernel yet.

Sure. I was just pointing out to the discussion where the *preferred* thing
happened.

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [1/2] dmaengine: dmatest: change symbolic permissions to octal values
  2018-02-01  3:46 ` [PATCH 1/2] " Viresh Kumar
@ 2018-02-01  3:57 ` Joe Perches
  -1 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2018-02-01  3:57 UTC (permalink / raw)
  To: Viresh Kumar, Vinod Koul
  Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Thu, 2018-02-01 at 09:16 +0530, Viresh Kumar wrote:
> On Thu, Feb 1, 2018 at 9:15 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > Right but lets no go changing to octals everywhere, new code sure :)
> > I don't see plans to remove representations entirely from kernel yet.
> 
> Sure. I was just pointing out to the discussion where the *preferred* thing
> happened.

Not really true.  Linus prefers actual octal
and suggested treewide conversions.

https://lwn.net/Articles/696229/
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
@ 2018-02-01  3:57 ` Joe Perches
  0 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2018-02-01  3:57 UTC (permalink / raw)
  To: Viresh Kumar, Vinod Koul
  Cc: Yang Shunyong, Dan Williams, dmaengine, linux-kernel

On Thu, 2018-02-01 at 09:16 +0530, Viresh Kumar wrote:
> On Thu, Feb 1, 2018 at 9:15 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > Right but lets no go changing to octals everywhere, new code sure :)
> > I don't see plans to remove representations entirely from kernel yet.
> 
> Sure. I was just pointing out to the discussion where the *preferred* thing
> happened.

Not really true.  Linus prefers actual octal
and suggested treewide conversions.

https://lwn.net/Articles/696229/

^ permalink raw reply	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2018-02-01  3:57 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31  7:38 [2/2] dmaengine: dmatest: add norandom option Yang Shunyong
2018-01-31  7:38 ` Re: [PATCH 2/2] " Yang, Shunyong
  -- strict thread matches above, loose matches on Subject: below --
2018-02-01  3:57 [1/2] dmaengine: dmatest: change symbolic permissions to octal values Joe Perches
2018-02-01  3:57 ` [PATCH 1/2] " Joe Perches
2018-02-01  3:46 [1/2] " Viresh Kumar
2018-02-01  3:46 ` [PATCH 1/2] " Viresh Kumar
2018-02-01  3:45 [1/2] " Vinod Koul
2018-02-01  3:45 ` [PATCH 1/2] " Vinod Koul
2018-01-31 10:01 [1/2] " Viresh Kumar
2018-01-31 10:01 ` [PATCH 1/2] " Viresh Kumar
2018-01-31  7:34 [2/2] dmaengine: dmatest: add norandom option Vinod Koul
2018-01-31  7:34 ` [PATCH 2/2] " Vinod Koul
2018-01-30 10:04 [1/2] dmaengine: dmatest: change symbolic permissions to octal values Vinod Koul
2018-01-30 10:04 ` Re: [PATCH 1/2] " Vinod Koul
2018-01-29  6:26 [1/2] " Yang Shunyong
2018-01-29  6:26 ` Re: [PATCH 1/2] " Yang, Shunyong
2018-01-29  4:48 [1/2] " Vinod Koul
2018-01-29  4:48 ` [PATCH 1/2] " Vinod Koul
2018-01-22 10:44 [2/2] dmaengine: dmatest: add norandom option Yang Shunyong
2018-01-22 10:44 ` [PATCH 2/2] " Yang Shunyong
2018-01-22 10:44 [1/2] dmaengine: dmatest: change symbolic permissions to octal values Yang Shunyong
2018-01-22 10:44 ` [PATCH 1/2] " Yang Shunyong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.