* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-07 17:24 `
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Díaz @ 2018-02-07 17:24 UTC (permalink / raw)
To: shuahkh, linux-kselftest
Cc: Daniel Díaz, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
Darren Hart, Shuah Khan, open list:FUTEX SUBSYSTEM
The Makefile lacks a couple of line continuation backslashes
in an `if' clause, which produces an error while make'ing:
$ make
make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
/bin/sh: -c: line 5: syntax error: unexpected end of file
make[1]: *** [all] Error 1
make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
make: *** [all] Error 2
Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
tools/testing/selftests/futex/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index cea4adc..a63e845 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -12,9 +12,9 @@ all:
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
- if [ -e $$DIR/$(TEST_PROGS) ]; then
- rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
- fi
+ if [ -e $$DIR/$(TEST_PROGS) ]; then \
+ rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+ fi \
done
override define RUN_TESTS
--
2.7.4
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Linux-kselftest-mirror] [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-07 17:24 `
0 siblings, 0 replies; 21+ messages in thread
From: @ 2018-02-07 17:24 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
The Makefile lacks a couple of line continuation backslashes
in an `if' clause, which produces an error while make'ing:
$ make
make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
/bin/sh: -c: line 5: syntax error: unexpected end of file
make[1]: *** [all] Error 1
make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
make: *** [all] Error 2
Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
---
tools/testing/selftests/futex/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index cea4adc..a63e845 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -12,9 +12,9 @@ all:
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
- if [ -e $$DIR/$(TEST_PROGS) ]; then
- rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
- fi
+ if [ -e $$DIR/$(TEST_PROGS) ]; then \
+ rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+ fi \
done
override define RUN_TESTS
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Linux-kselftest-mirror] [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-07 17:24 `
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Díaz @ 2018-02-07 17:24 UTC (permalink / raw)
The Makefile lacks a couple of line continuation backslashes
in an `if' clause, which produces an error while make'ing:
$ make
make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
/bin/sh: -c: line 5: syntax error: unexpected end of file
make[1]: *** [all] Error 1
make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
make: *** [all] Error 2
Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
---
tools/testing/selftests/futex/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index cea4adc..a63e845 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -12,9 +12,9 @@ all:
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
- if [ -e $$DIR/$(TEST_PROGS) ]; then
- rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
- fi
+ if [ -e $$DIR/$(TEST_PROGS) ]; then \
+ rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
+ fi \
done
override define RUN_TESTS
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] selftests/futex: Fix line continuation in Makefile
2018-02-07 17:24 `
(?)
@ 2018-02-13 21:26 ` shuahkh
-1 siblings, 0 replies; 21+ messages in thread
From: Shuah Khan @ 2018-02-13 21:26 UTC (permalink / raw)
To: Daniel Díaz, linux-kselftest
Cc: Thomas Gleixner, Ingo Molnar, Peter Zijlstra, Darren Hart,
Shuah Khan, open list:FUTEX SUBSYSTEM, Shuah Khan
On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which produces an error while make'ing:
>
> $ make
> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> /bin/sh: -c: line 5: syntax error: unexpected end of file
> make[1]: *** [all] Error 1
> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> make: *** [all] Error 2
>
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
> tools/testing/selftests/futex/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adc..a63e845 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -12,9 +12,9 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> - if [ -e $$DIR/$(TEST_PROGS) ]; then
> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> - fi
> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> + fi \
> done
>
> override define RUN_TESTS
>
Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-13 21:26 ` shuahkh
0 siblings, 0 replies; 21+ messages in thread
From: shuahkh @ 2018-02-13 21:26 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which produces an error while make'ing:
>
> $ make
> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> /bin/sh: -c: line 5: syntax error: unexpected end of file
> make[1]: *** [all] Error 1
> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> make: *** [all] Error 2
>
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
> tools/testing/selftests/futex/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adc..a63e845 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -12,9 +12,9 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> - if [ -e $$DIR/$(TEST_PROGS) ]; then
> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> - fi
> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> + fi \
> done
>
> override define RUN_TESTS
>
Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-13 21:26 ` shuahkh
0 siblings, 0 replies; 21+ messages in thread
From: Shuah Khan @ 2018-02-13 21:26 UTC (permalink / raw)
On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> The Makefile lacks a couple of line continuation backslashes
> in an `if' clause, which produces an error while make'ing:
>
> $ make
> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> /bin/sh: -c: line 5: syntax error: unexpected end of file
> make[1]: *** [all] Error 1
> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> make: *** [all] Error 2
>
> Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> ---
> tools/testing/selftests/futex/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index cea4adc..a63e845 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -12,9 +12,9 @@ all:
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> - if [ -e $$DIR/$(TEST_PROGS) ]; then
> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> - fi
> + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> + fi \
> done
>
> override define RUN_TESTS
>
Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] selftests/futex: Fix line continuation in Makefile
2018-02-13 21:26 ` shuahkh
(?)
@ 2018-02-14 1:33 ` dvhart
-1 siblings, 0 replies; 21+ messages in thread
From: Darren Hart @ 2018-02-14 1:33 UTC (permalink / raw)
To: Shuah Khan
Cc: Daniel Díaz, linux-kselftest, Thomas Gleixner, Ingo Molnar,
Peter Zijlstra, Shuah Khan, open list:FUTEX SUBSYSTEM
On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> > The Makefile lacks a couple of line continuation backslashes
> > in an `if' clause, which produces an error while make'ing:
> >
> > $ make
> > make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> > /bin/sh: -c: line 5: syntax error: unexpected end of file
> > make[1]: *** [all] Error 1
> > make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> > make: *** [all] Error 2
> >
What is the failure scenario here? Is this shell specific? What does /bin/sh
point to for you?
> > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> > ---
> > tools/testing/selftests/futex/Makefile | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> > index cea4adc..a63e845 100644
> > --- a/tools/testing/selftests/futex/Makefile
> > +++ b/tools/testing/selftests/futex/Makefile
> > @@ -12,9 +12,9 @@ all:
> > BUILD_TARGET=$(OUTPUT)/$$DIR; \
> > mkdir $$BUILD_TARGET -p; \
> > make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> > - if [ -e $$DIR/$(TEST_PROGS) ]; then
> > - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> > - fi
> > + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> > + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> > + fi \
> > done
> >
> > override define RUN_TESTS
> >
>
> Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
>
> thanks,
> -- Shuah
>
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 1:33 ` dvhart
0 siblings, 0 replies; 21+ messages in thread
From: dvhart @ 2018-02-14 1:33 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]
On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> > The Makefile lacks a couple of line continuation backslashes
> > in an `if' clause, which produces an error while make'ing:
> >
> > $ make
> > make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> > /bin/sh: -c: line 5: syntax error: unexpected end of file
> > make[1]: *** [all] Error 1
> > make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> > make: *** [all] Error 2
> >
What is the failure scenario here? Is this shell specific? What does /bin/sh
point to for you?
> > Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> > ---
> > tools/testing/selftests/futex/Makefile | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> > index cea4adc..a63e845 100644
> > --- a/tools/testing/selftests/futex/Makefile
> > +++ b/tools/testing/selftests/futex/Makefile
> > @@ -12,9 +12,9 @@ all:
> > BUILD_TARGET=$(OUTPUT)/$$DIR; \
> > mkdir $$BUILD_TARGET -p; \
> > make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> > - if [ -e $$DIR/$(TEST_PROGS) ]; then
> > - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> > - fi
> > + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> > + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> > + fi \
> > done
> >
> > override define RUN_TESTS
> >
>
> Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
>
> thanks,
> -- Shuah
>
--
Darren Hart
VMware Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 1:33 ` dvhart
0 siblings, 0 replies; 21+ messages in thread
From: Darren Hart @ 2018-02-14 1:33 UTC (permalink / raw)
On Tue, Feb 13, 2018@02:26:46PM -0700, Shuah Khan wrote:
> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> > The Makefile lacks a couple of line continuation backslashes
> > in an `if' clause, which produces an error while make'ing:
> >
> > $ make
> > make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> > /bin/sh: -c: line 5: syntax error: unexpected end of file
> > make[1]: *** [all] Error 1
> > make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> > make: *** [all] Error 2
> >
What is the failure scenario here? Is this shell specific? What does /bin/sh
point to for you?
> > Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
> > ---
> > tools/testing/selftests/futex/Makefile | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> > index cea4adc..a63e845 100644
> > --- a/tools/testing/selftests/futex/Makefile
> > +++ b/tools/testing/selftests/futex/Makefile
> > @@ -12,9 +12,9 @@ all:
> > BUILD_TARGET=$(OUTPUT)/$$DIR; \
> > mkdir $$BUILD_TARGET -p; \
> > make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> > - if [ -e $$DIR/$(TEST_PROGS) ]; then
> > - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> > - fi
> > + if [ -e $$DIR/$(TEST_PROGS) ]; then \
> > + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> > + fi \
> > done
> >
> > override define RUN_TESTS
> >
>
> Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3
>
> thanks,
> -- Shuah
>
--
Darren Hart
VMware Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] selftests/futex: Fix line continuation in Makefile
2018-02-14 1:33 ` dvhart
(?)
@ 2018-02-14 1:45 ` shuahkh
-1 siblings, 0 replies; 21+ messages in thread
From: Shuah Khan @ 2018-02-14 1:45 UTC (permalink / raw)
To: Darren Hart, Daniel Díaz
Cc: linux-kselftest, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
Shuah Khan, open list:FUTEX SUBSYSTEM, Shuah Khan
On 02/13/2018 06:33 PM, Darren Hart wrote:
> On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
>> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
>>> The Makefile lacks a couple of line continuation backslashes
>>> in an `if' clause, which produces an error while make'ing:
>>>
>>> $ make
>>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>> make[1]: *** [all] Error 1
>>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
>>> make: *** [all] Error 2
>>>
>
> What is the failure scenario here? Is this shell specific? What does /bin/sh
> point to for you?
My understanding is that this problem is seen with make versions prior to 4.x.
This specific problem is seen with make version 3.81
I will let Daniel Díaz share details on his environment.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 1:45 ` shuahkh
0 siblings, 0 replies; 21+ messages in thread
From: shuahkh @ 2018-02-14 1:45 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On 02/13/2018 06:33 PM, Darren Hart wrote:
> On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
>> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
>>> The Makefile lacks a couple of line continuation backslashes
>>> in an `if' clause, which produces an error while make'ing:
>>>
>>> $ make
>>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>> make[1]: *** [all] Error 1
>>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
>>> make: *** [all] Error 2
>>>
>
> What is the failure scenario here? Is this shell specific? What does /bin/sh
> point to for you?
My understanding is that this problem is seen with make versions prior to 4.x.
This specific problem is seen with make version 3.81
I will let Daniel Díaz share details on his environment.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 1:45 ` shuahkh
0 siblings, 0 replies; 21+ messages in thread
From: Shuah Khan @ 2018-02-14 1:45 UTC (permalink / raw)
On 02/13/2018 06:33 PM, Darren Hart wrote:
> On Tue, Feb 13, 2018@02:26:46PM -0700, Shuah Khan wrote:
>> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
>>> The Makefile lacks a couple of line continuation backslashes
>>> in an `if' clause, which produces an error while make'ing:
>>>
>>> $ make
>>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>> make[1]: *** [all] Error 1
>>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
>>> make: *** [all] Error 2
>>>
>
> What is the failure scenario here? Is this shell specific? What does /bin/sh
> point to for you?
My understanding is that this problem is seen with make versions prior to 4.x.
This specific problem is seen with make version 3.81
I will let Daniel Díaz share details on his environment.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] selftests/futex: Fix line continuation in Makefile
2018-02-14 1:45 ` shuahkh
(?)
@ 2018-02-14 2:03 ` dvhart
-1 siblings, 0 replies; 21+ messages in thread
From: Darren Hart @ 2018-02-14 2:03 UTC (permalink / raw)
To: Shuah Khan
Cc: Daniel Díaz, linux-kselftest, Thomas Gleixner, Ingo Molnar,
Peter Zijlstra, Shuah Khan, open list:FUTEX SUBSYSTEM
On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> On 02/13/2018 06:33 PM, Darren Hart wrote:
> > On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> >> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> >>> The Makefile lacks a couple of line continuation backslashes
> >>> in an `if' clause, which produces an error while make'ing:
> >>>
> >>> $ make
> >>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> >>> /bin/sh: -c: line 5: syntax error: unexpected end of file
> >>> make[1]: *** [all] Error 1
> >>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> >>> make: *** [all] Error 2
> >>>
> >
> > What is the failure scenario here? Is this shell specific? What does /bin/sh
> > point to for you?
>
> My understanding is that this problem is seen with make versions prior to 4.x.
> This specific problem is seen with make version 3.81
>
> I will let Daniel Díaz share details on his environment.
OK, thanks Shuah. I think this would be important to capture in the commit
message.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 2:03 ` dvhart
0 siblings, 0 replies; 21+ messages in thread
From: dvhart @ 2018-02-14 2:03 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> On 02/13/2018 06:33 PM, Darren Hart wrote:
> > On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote:
> >> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> >>> The Makefile lacks a couple of line continuation backslashes
> >>> in an `if' clause, which produces an error while make'ing:
> >>>
> >>> $ make
> >>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> >>> /bin/sh: -c: line 5: syntax error: unexpected end of file
> >>> make[1]: *** [all] Error 1
> >>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> >>> make: *** [all] Error 2
> >>>
> >
> > What is the failure scenario here? Is this shell specific? What does /bin/sh
> > point to for you?
>
> My understanding is that this problem is seen with make versions prior to 4.x.
> This specific problem is seen with make version 3.81
>
> I will let Daniel Díaz share details on his environment.
OK, thanks Shuah. I think this would be important to capture in the commit
message.
--
Darren Hart
VMware Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 2:03 ` dvhart
0 siblings, 0 replies; 21+ messages in thread
From: Darren Hart @ 2018-02-14 2:03 UTC (permalink / raw)
On Tue, Feb 13, 2018@06:45:54PM -0700, Shuah Khan wrote:
> On 02/13/2018 06:33 PM, Darren Hart wrote:
> > On Tue, Feb 13, 2018@02:26:46PM -0700, Shuah Khan wrote:
> >> On 02/07/2018 10:24 AM, Daniel Díaz wrote:
> >>> The Makefile lacks a couple of line continuation backslashes
> >>> in an `if' clause, which produces an error while make'ing:
> >>>
> >>> $ make
> >>> make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex'
> >>> /bin/sh: -c: line 5: syntax error: unexpected end of file
> >>> make[1]: *** [all] Error 1
> >>> make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex'
> >>> make: *** [all] Error 2
> >>>
> >
> > What is the failure scenario here? Is this shell specific? What does /bin/sh
> > point to for you?
>
> My understanding is that this problem is seen with make versions prior to 4.x.
> This specific problem is seen with make version 3.81
>
> I will let Daniel Díaz share details on his environment.
OK, thanks Shuah. I think this would be important to capture in the commit
message.
--
Darren Hart
VMware Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] selftests/futex: Fix line continuation in Makefile
2018-02-14 2:03 ` dvhart
(?)
@ 2018-02-14 14:49 `
-1 siblings, 0 replies; 21+ messages in thread
From: Daniel Díaz Rodríguez @ 2018-02-14 14:49 UTC (permalink / raw)
To: Darren Hart
Cc: Shuah Khan, linux-kselftest, Thomas Gleixner, Ingo Molnar,
Peter Zijlstra, Shuah Khan, open list:FUTEX SUBSYSTEM
Hello!
On 13 February 2018 at 20:03, Darren Hart <dvhart@infradead.org> wrote:
> On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
[...]
>> My understanding is that this problem is seen with make versions prior to 4.x.
>> This specific problem is seen with make version 3.81
>> I will let Daniel Díaz share details on his environment.
>
> OK, thanks Shuah. I think this would be important to capture in the commit
> message.
That's correct -- fails with GNU Make 3.80, 3.81; works with GNU Make
3.82 and the 4.x series. Shuah, if you'd like me to resubmit let me
know.
Thanks and greetings!
Daniel Díaz
daniel.diaz@linaro.org
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 14:49 `
0 siblings, 0 replies; 21+ messages in thread
From: @ 2018-02-14 14:49 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
Hello!
On 13 February 2018 at 20:03, Darren Hart <dvhart at infradead.org> wrote:
> On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
[...]
>> My understanding is that this problem is seen with make versions prior to 4.x.
>> This specific problem is seen with make version 3.81
>> I will let Daniel Díaz share details on his environment.
>
> OK, thanks Shuah. I think this would be important to capture in the commit
> message.
That's correct -- fails with GNU Make 3.80, 3.81; works with GNU Make
3.82 and the 4.x series. Shuah, if you'd like me to resubmit let me
know.
Thanks and greetings!
Daniel Díaz
daniel.diaz at linaro.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 14:49 `
0 siblings, 0 replies; 21+ messages in thread
From: Daniel Díaz Rodríguez @ 2018-02-14 14:49 UTC (permalink / raw)
Hello!
On 13 February 2018@20:03, Darren Hart <dvhart@infradead.org> wrote:
> On Tue, Feb 13, 2018@06:45:54PM -0700, Shuah Khan wrote:
[...]
>> My understanding is that this problem is seen with make versions prior to 4.x.
>> This specific problem is seen with make version 3.81
>> I will let Daniel Díaz share details on his environment.
>
> OK, thanks Shuah. I think this would be important to capture in the commit
> message.
That's correct -- fails with GNU Make 3.80, 3.81; works with GNU Make
3.82 and the 4.x series. Shuah, if you'd like me to resubmit let me
know.
Thanks and greetings!
Daniel Díaz
daniel.diaz at linaro.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] selftests/futex: Fix line continuation in Makefile
2018-02-14 14:49 `
(?)
@ 2018-02-14 15:02 ` shuahkh
-1 siblings, 0 replies; 21+ messages in thread
From: Shuah Khan @ 2018-02-14 15:02 UTC (permalink / raw)
To: Daniel Díaz Rodríguez, Darren Hart
Cc: linux-kselftest, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
Shuah Khan, open list:FUTEX SUBSYSTEM, Shuah Khan
On 02/14/2018 07:49 AM, Daniel Díaz Rodríguez wrote:
> Hello!
>
>
> On 13 February 2018 at 20:03, Darren Hart <dvhart@infradead.org> wrote:
>> On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> [...]
>>> My understanding is that this problem is seen with make versions prior to 4.x.
>>> This specific problem is seen with make version 3.81
>>> I will let Daniel Díaz share details on his environment.
>>
>> OK, thanks Shuah. I think this would be important to capture in the commit
>> message.
Thanks.
>
> That's correct -- fails with GNU Make 3.80, 3.81; works with GNU Make
> 3.82 and the 4.x series. Shuah, if you'd like me to resubmit let me
> know.
>
Thanks you both. I will update the commit log with the details on why
this fix is needed. No need to send an updated patch.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 15:02 ` shuahkh
0 siblings, 0 replies; 21+ messages in thread
From: shuahkh @ 2018-02-14 15:02 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On 02/14/2018 07:49 AM, Daniel Díaz Rodríguez wrote:
> Hello!
>
>
> On 13 February 2018 at 20:03, Darren Hart <dvhart at infradead.org> wrote:
>> On Tue, Feb 13, 2018 at 06:45:54PM -0700, Shuah Khan wrote:
> [...]
>>> My understanding is that this problem is seen with make versions prior to 4.x.
>>> This specific problem is seen with make version 3.81
>>> I will let Daniel Díaz share details on his environment.
>>
>> OK, thanks Shuah. I think this would be important to capture in the commit
>> message.
Thanks.
>
> That's correct -- fails with GNU Make 3.80, 3.81; works with GNU Make
> 3.82 and the 4.x series. Shuah, if you'd like me to resubmit let me
> know.
>
Thanks you both. I will update the commit log with the details on why
this fix is needed. No need to send an updated patch.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] selftests/futex: Fix line continuation in Makefile
@ 2018-02-14 15:02 ` shuahkh
0 siblings, 0 replies; 21+ messages in thread
From: Shuah Khan @ 2018-02-14 15:02 UTC (permalink / raw)
On 02/14/2018 07:49 AM, Daniel Díaz Rodríguez wrote:
> Hello!
>
>
> On 13 February 2018@20:03, Darren Hart <dvhart@infradead.org> wrote:
>> On Tue, Feb 13, 2018@06:45:54PM -0700, Shuah Khan wrote:
> [...]
>>> My understanding is that this problem is seen with make versions prior to 4.x.
>>> This specific problem is seen with make version 3.81
>>> I will let Daniel Díaz share details on his environment.
>>
>> OK, thanks Shuah. I think this would be important to capture in the commit
>> message.
Thanks.
>
> That's correct -- fails with GNU Make 3.80, 3.81; works with GNU Make
> 3.82 and the 4.x series. Shuah, if you'd like me to resubmit let me
> know.
>
Thanks you both. I will update the commit log with the details on why
this fix is needed. No need to send an updated patch.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-02-14 15:02 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 17:24 [PATCH] selftests/futex: Fix line continuation in Makefile Daniel Díaz
2018-02-07 17:24 ` [Linux-kselftest-mirror] " Daniel Díaz
2018-02-07 17:24 `
2018-02-13 21:26 ` Shuah Khan
2018-02-13 21:26 ` Shuah Khan
2018-02-13 21:26 ` shuahkh
2018-02-14 1:33 ` Darren Hart
2018-02-14 1:33 ` Darren Hart
2018-02-14 1:33 ` dvhart
2018-02-14 1:45 ` Shuah Khan
2018-02-14 1:45 ` Shuah Khan
2018-02-14 1:45 ` shuahkh
2018-02-14 2:03 ` Darren Hart
2018-02-14 2:03 ` Darren Hart
2018-02-14 2:03 ` dvhart
2018-02-14 14:49 ` Daniel Díaz Rodríguez
2018-02-14 14:49 ` Daniel Díaz Rodríguez
2018-02-14 14:49 `
2018-02-14 15:02 ` Shuah Khan
2018-02-14 15:02 ` Shuah Khan
2018-02-14 15:02 ` shuahkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.