From: Arnd Bergmann <arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org Cc: Brijesh Singh <brijesh.singh@amd.com>, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, mark.rutland@arm.com, devicetree@vger.kernel.org, arm@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, leo.duran@amd.com, galak@codeaurora.org, thomas.lendacky@amd.com, brijeshkumar.singh@amd.com Subject: Re: [PATCH V2 09/12] dtb: amd: Add KCS device tree node Date: Tue, 09 Feb 2016 17:00:48 +0100 [thread overview] Message-ID: <15181064.RzzsN4CWec@wuerfel> (raw) In-Reply-To: <56BA0A2B.5000705@amd.com> On Tuesday 09 February 2016 09:47:55 Brijesh Singh wrote: > > > > I see we don't have a binding file for this, can you add one please? > > > There is binding file ipmi.txt [1]. Am I missing something ? > > [1] http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/ipmi.txt Sorry, my mistake: I was looking for "ipmi_kcs", which is not in there. > > > > Why the strange name for the interrupt? > > > > Now I don't remember the doc but sometime back while implementing BMC on Seattle I saw that interrupt was labeled as "ipmi_kcs" > hence used the same name in DT. But if you want to use different name then let me know the string and will update it. > > Theoretically IPMI system interface supports the following interface and any of these interfaces can be used by > A57 to communicate with BMC: > > * Keyboard controller style (KCS) > * System Management Interface (SMIC) > * Block transfer (BT) > * SMBus system interface (SSIF) > > AMD Seattle platform supports "KCS". > The important part for interrupt/reg/... names is that you must use exactly the names that are listed in the binding. If there is no name in there, it's better not to add the name property. The other point is that "ipmi_kcs" is a name that is picked really badly, as it uses a '_' character while DT properties by convention use '-' between names, and the name of the IRQ is the same as the device itself, which is really not a useful way to disambiguate multiple interrupts in the same device, if someone ever adds another irq line. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 09/12] dtb: amd: Add KCS device tree node Date: Tue, 09 Feb 2016 17:00:48 +0100 [thread overview] Message-ID: <15181064.RzzsN4CWec@wuerfel> (raw) In-Reply-To: <56BA0A2B.5000705@amd.com> On Tuesday 09 February 2016 09:47:55 Brijesh Singh wrote: > > > > I see we don't have a binding file for this, can you add one please? > > > There is binding file ipmi.txt [1]. Am I missing something ? > > [1] http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/ipmi.txt Sorry, my mistake: I was looking for "ipmi_kcs", which is not in there. > > > > Why the strange name for the interrupt? > > > > Now I don't remember the doc but sometime back while implementing BMC on Seattle I saw that interrupt was labeled as "ipmi_kcs" > hence used the same name in DT. But if you want to use different name then let me know the string and will update it. > > Theoretically IPMI system interface supports the following interface and any of these interfaces can be used by > A57 to communicate with BMC: > > * Keyboard controller style (KCS) > * System Management Interface (SMIC) > * Block transfer (BT) > * SMBus system interface (SSIF) > > AMD Seattle platform supports "KCS". > The important part for interrupt/reg/... names is that you must use exactly the names that are listed in the binding. If there is no name in there, it's better not to add the name property. The other point is that "ipmi_kcs" is a name that is picked really badly, as it uses a '_' character while DT properties by convention use '-' between names, and the name of the IRQ is the same as the device itself, which is really not a useful way to disambiguate multiple interrupts in the same device, if someone ever adds another irq line. Arnd
next prev parent reply other threads:[~2016-02-09 16:01 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-08 17:59 [PATCH V2 00/12] dtb: amd: Miscelleneous Updates for AMD Seattle DTS Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 01/12] MAINTAINERS: Adding Maintainers for AMD Seattle Device Tree Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 21:38 ` Olof Johansson 2016-02-08 21:38 ` Olof Johansson 2016-02-09 19:49 ` Suravee Suthikulpanit 2016-02-09 19:49 ` Suravee Suthikulpanit 2016-02-09 19:49 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 02/12] dtb: amd: Fix GICv2 hypervisor and virtual interface sizes Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-09 14:57 ` Arnd Bergmann 2016-02-09 14:57 ` Arnd Bergmann 2016-02-10 21:13 ` Suravee Suthikulpanit 2016-02-10 21:13 ` Suravee Suthikulpanit 2016-02-10 21:13 ` Suravee Suthikulpanit 2016-02-10 21:19 ` Arnd Bergmann 2016-02-10 21:19 ` Arnd Bergmann 2016-02-10 21:19 ` Arnd Bergmann 2016-02-11 21:23 ` Olof Johansson 2016-02-11 21:23 ` Olof Johansson 2016-02-11 21:23 ` Olof Johansson 2016-02-11 22:59 ` Suravee Suthikulpanit 2016-02-11 22:59 ` Suravee Suthikulpanit 2016-02-11 22:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 04/12] dtb: amd: Fix typo in SPI device nodes Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 05/12] dtb: amd: Misc changes for I2C " Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 06/12] dtb: amd: Misc changes for SATA device tree nodes Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 07/12] dtb: amd: Misc changes for GPIO devices Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 08/12] dtb: amd: Add PERF CCN-504 device tree node Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-09 14:58 ` Arnd Bergmann 2016-02-09 14:58 ` Arnd Bergmann 2016-02-09 23:35 ` Suravee Suthikulpanit 2016-02-09 23:35 ` Suravee Suthikulpanit 2016-02-09 23:35 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 09/12] dtb: amd: Add KCS " Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-09 14:59 ` Arnd Bergmann 2016-02-09 14:59 ` Arnd Bergmann 2016-02-09 15:47 ` Brijesh Singh 2016-02-09 15:47 ` Brijesh Singh 2016-02-09 15:47 ` Brijesh Singh 2016-02-09 16:00 ` Arnd Bergmann [this message] 2016-02-09 16:00 ` Arnd Bergmann 2016-02-09 16:11 ` Brijesh Singh 2016-02-09 16:11 ` Brijesh Singh 2016-02-09 16:11 ` Brijesh Singh 2016-02-08 17:59 ` [PATCH V2 10/12] dtb: amd: Add AMD XGBE device tree file Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 11/12] dtb: amd: Add support for new AMD Overdrive boards Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` [PATCH V2 12/12] dtb: amd: Add support for AMD/Linaro 96Boards Enterprise Edition Server board Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit 2016-02-08 17:59 ` Suravee Suthikulpanit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=15181064.RzzsN4CWec@wuerfel \ --to=arnd@arndb.de \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=arm@kernel.org \ --cc=brijesh.singh@amd.com \ --cc=brijeshkumar.singh@amd.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=leo.duran@amd.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=thomas.lendacky@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.