[PATCH 1/2] bmap-tools: change SRC_URI to use tarball instead

[PATCH 1/2] bmap-tools: change SRC_URI to use tarball instead

[Chang Rebecca Swee Fun]

Tarball sources can be checksummed and are faster to download.

Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
---
 meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
index 70b6e91..6975acb 100644
--- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
+++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
@@ -9,10 +9,10 @@ SECTION = "console/utils"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-SRC_URI = "git://github.com/intel/bmap-tools.git"
-SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
+SRC_URI = "https://github.com/intel/${BPN}/releases/download/v${PV}/${BPN}-${PV}.tgz"
 
-S = "${WORKDIR}/git"
+SRC_URI[md5sum] = "883420183611aa137cbaf68a91ef0d7e"
+SRC_URI[sha256sum] = "0064891270c180c190f41925b0f6fb9cecac3056f1168d2592dbe90e5f226c0a"
 
 RDEPENDS_${PN} = "python3-core python3-compression python3-mmap python3-setuptools"
 
-- 
2.7.4

[PATCH 2/2] maintainers.inc: change ownership for bmap-tools and wic-tools

[Chang Rebecca Swee Fun]

Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
---
 meta/conf/distro/include/maintainers.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 34f3d81..dc7d688 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -77,7 +77,7 @@ RECIPE_MAINTAINER_pn-bjam-native = "Alexander Kanavin <alexander.kanavin@intel.c
 RECIPE_MAINTAINER_pn-blktool = "Yi Zhao <yi.zhao@windriver.com>"
 RECIPE_MAINTAINER_pn-blktrace = "Alexander Kanavin <alexander.kanavin@intel.com>"
 RECIPE_MAINTAINER_pn-bluez5 = "Maxin B. John <maxin.john@intel.com>"
-RECIPE_MAINTAINER_pn-bmap-tools = "Ed Bartosh <ed.bartosh@linux.intel.com>"
+RECIPE_MAINTAINER_pn-bmap-tools = "Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>"
 RECIPE_MAINTAINER_pn-boost = "Alexander Kanavin <alexander.kanavin@intel.com>"
 RECIPE_MAINTAINER_pn-bootchart2 = "Alexander Kanavin <alexander.kanavin@intel.com>"
 RECIPE_MAINTAINER_pn-bsd-headers = "Khem Raj <raj.khem@gmail.com>"
@@ -740,7 +740,7 @@ RECIPE_MAINTAINER_pn-weston = "Denys Dmytriyenko <denys@ti.com>"
 RECIPE_MAINTAINER_pn-weston-init = "Denys Dmytriyenko <denys@ti.com>"
 RECIPE_MAINTAINER_pn-wget = "Yi Zhao <yi.zhao@windriver.com>"
 RECIPE_MAINTAINER_pn-which = "Maxin B. John <maxin.john@intel.com>"
-RECIPE_MAINTAINER_pn-wic-tools = "Ed Bartosh <ed.bartosh@linux.intel.com>"
+RECIPE_MAINTAINER_pn-wic-tools = "Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>"
 RECIPE_MAINTAINER_pn-wireless-tools = "Changhyeok Bae <changhyeok.bae@lge.com>"
 RECIPE_MAINTAINER_pn-wpa-supplicant = "Changhyeok Bae <changhyeok.bae@lge.com>"
 RECIPE_MAINTAINER_pn-x11-common = "Armin Kuster <akuster@mvista.com>"
-- 
2.7.4

[PATCHv2] bmap-tools: change SRC_URI to use tarball instead

[rebecca.swee.fun.chang]

From: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>

Tarball sources can be checksummed and are faster to download.

Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
---
 meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
index 70b6e91..3f15e12 100644
--- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
+++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
@@ -9,10 +9,10 @@ SECTION = "console/utils"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-SRC_URI = "git://github.com/intel/bmap-tools.git"
-SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
+SRC_URI = "https://github.com/intel/${BPN}/releases/download/v${PV}/${BP}.tgz"
 
-S = "${WORKDIR}/git"
+SRC_URI[md5sum] = "883420183611aa137cbaf68a91ef0d7e"
+SRC_URI[sha256sum] = "0064891270c180c190f41925b0f6fb9cecac3056f1168d2592dbe90e5f226c0a"
 
 RDEPENDS_${PN} = "python3-core python3-compression python3-mmap python3-setuptools"
 
-- 
2.7.4

Re: [PATCH 1/2] bmap-tools: change SRC_URI to use tarball instead

[Alexander Kanavin]

On 02/09/2018 06:25 AM, Chang Rebecca Swee Fun wrote:
> -SRC_URI = "git://github.com/intel/bmap-tools.git"
> -SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
> +SRC_URI = "https://github.com/intel/${BPN}/releases/download/v${PV}/${BPN}-${PV}.tgz"

When you switch the upstream source location like this, you need to 
verify that upstream version check still works:

bitbake -c checkpkg bmap-tools

and inspect tmp/log/checkpkg.csv to see the outcome. If bitbake can no 
longer determine the latest version, set UPSTREAM_CHECK_URI to the 
webpage where all the tarballs are linked from (I think it would be 
https://github.com/intel/${BPN}/releases/). There's plenty of recipes in 
oe-core with similar adjustments, if you need further examples.

Alex

Re: [PATCH 1/2] bmap-tools: change SRC_URI to use tarball instead

[Chang, Rebecca Swee Fun]

Hi Alex,

> -----Original Message-----
> From: Alexander Kanavin [mailto:alexander.kanavin@linux.intel.com]
> Sent: Friday, February 9, 2018 2:52 PM
> To: Chang, Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/2] bmap-tools: change SRC_URI to use tarball
> instead
> 
> On 02/09/2018 06:25 AM, Chang Rebecca Swee Fun wrote:
> > -SRC_URI = "git://github.com/intel/bmap-tools.git"
> > -SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
> > +SRC_URI =
> "https://github.com/intel/${BPN}/releases/download/v${PV}/${BPN}-${PV}.tgz"
> 
> When you switch the upstream source location like this, you need to verify that
> upstream version check still works:
> 
> bitbake -c checkpkg bmap-tools
>
> and inspect tmp/log/checkpkg.csv to see the outcome. If bitbake can no longer
> determine the latest version, set UPSTREAM_CHECK_URI to the webpage where
> all the tarballs are linked from (I think it would be
> https://github.com/intel/${BPN}/releases/). There's plenty of recipes in oe-core
> with similar adjustments, if you need further examples.
> 
Thanks for your input! I will double check and send a new revision.

Rebecca

Re: [PATCH 1/2] bmap-tools: change SRC_URI to use tarball instead

[Alexander Kanavin]

On 02/09/2018 09:14 AM, Chang, Rebecca Swee Fun wrote:
>> When you switch the upstream source location like this, you need to verify that
>> upstream version check still works:
>>
>> bitbake -c checkpkg bmap-tools
>>
>> and inspect tmp/log/checkpkg.csv to see the outcome. If bitbake can no longer
>> determine the latest version, set UPSTREAM_CHECK_URI to the webpage where
>> all the tarballs are linked from (I think it would be
>> https://github.com/intel/${BPN}/releases/). There's plenty of recipes in oe-core
>> with similar adjustments, if you need further examples.
>>
> Thanks for your input! I will double check and send a new revision.

Ah, how could I forget. Devtool makes this much more convenient:

devtool latest-version bmap-tools


Alex

[PATCHv3] bmap-tools: change SRC_URI to use tarball instead

[rebecca.swee.fun.chang]

From: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>

Tarball sources can be checksummed and are faster to download.
Added UPSTREAM_CHECK_URI to improve recipe maintenance and to
verify upstream version check is still work.

Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
---
 meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
index 70b6e91..9d8191f 100644
--- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
+++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
@@ -9,10 +9,12 @@ SECTION = "console/utils"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-SRC_URI = "git://github.com/intel/bmap-tools.git"
-SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
+SRC_URI = "https://github.com/intel/${BPN}/releases/download/v${PV}/${BP}.tgz"
 
-S = "${WORKDIR}/git"
+SRC_URI[md5sum] = "883420183611aa137cbaf68a91ef0d7e"
+SRC_URI[sha256sum] = "0064891270c180c190f41925b0f6fb9cecac3056f1168d2592dbe90e5f226c0a"
+
+UPSTREAM_CHECK_URI = "https://github.com/intel/${BPN}/releases"
 
 RDEPENDS_${PN} = "python3-core python3-compression python3-mmap python3-setuptools"
 
-- 
2.7.4