All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, Jiri Kosina <jkosina@suse.cz>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Brian Gerst <brgerst@gmail.com>,
	David Laight <David.Laight@aculab.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Eduardo Valentin <eduval@amazon.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Will Deacon <will.deacon@arm.com>,
	aliguori@amazon.com, daniel.gruss@iaik.tugraz.at,
	hughd@google.com, keescook@google.com,
	Andrea Arcangeli <aarcange@redhat.com>,
	Waiman Long <llong@redhat.com>, Pavel Machek <pavel@ucw.cz>,
	jroedel@suse.de, joro@8bytes.org
Subject: [PATCH 10/31] x86/entry/32: Introduce SAVE_ALL_NMI and RESTORE_ALL_NMI
Date: Fri,  9 Feb 2018 10:25:19 +0100	[thread overview]
Message-ID: <1518168340-9392-11-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1518168340-9392-1-git-send-email-joro@8bytes.org>

From: Joerg Roedel <jroedel@suse.de>

These macros will be used in the NMI handler code and
replace plain SAVE_ALL and RESTORE_REGS there. We will add
the NMI-specific CR3-switch to these macros later.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 arch/x86/entry/entry_32.S | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S
index ba3d8c2..be1d814 100644
--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -167,6 +167,9 @@
 
 .endm
 
+.macro SAVE_ALL_NMI
+	SAVE_ALL
+.endm
 /*
  * This is a sneaky trick to help the unwinder find pt_regs on the stack.  The
  * frame pointer is replaced with an encoded pointer to pt_regs.  The encoding
@@ -224,6 +227,18 @@
 	RESTORE_SKIP_SEGMENTS \pop
 .endm
 
+.macro RESTORE_ALL_NMI pop=0
+	/*
+	 * Restore segments - might cause exceptions when loading
+	 * user-space segments
+	 */
+	RESTORE_SEGMENTS
+
+	/* Restore integer registers and unwind stack to iret frame */
+	RESTORE_INT_REGS
+	RESTORE_SKIP_SEGMENTS \pop
+.endm
+
 .macro CHECK_AND_APPLY_ESPFIX
 #ifdef CONFIG_X86_ESPFIX32
 #define GDT_ESPFIX_SS PER_CPU_VAR(gdt_page) + (GDT_ENTRY_ESPFIX_SS * 8)
@@ -1127,7 +1142,7 @@ ENTRY(nmi)
 #endif
 
 	pushl	%eax				# pt_regs->orig_ax
-	SAVE_ALL
+	SAVE_ALL_NMI
 	ENCODE_FRAME_POINTER
 	xorl	%edx, %edx			# zero error code
 	movl	%esp, %eax			# pt_regs pointer
@@ -1155,7 +1170,7 @@ ENTRY(nmi)
 
 .Lnmi_return:
 	CHECK_AND_APPLY_ESPFIX
-	RESTORE_REGS 4
+	RESTORE_ALL_NMI pop=4
 	jmp	.Lirq_return
 
 #ifdef CONFIG_X86_ESPFIX32
@@ -1171,12 +1186,12 @@ ENTRY(nmi)
 	pushl	16(%esp)
 	.endr
 	pushl	%eax
-	SAVE_ALL
+	SAVE_ALL_NMI
 	ENCODE_FRAME_POINTER
 	FIXUP_ESPFIX_STACK			# %eax == %esp
 	xorl	%edx, %edx			# zero error code
 	call	do_nmi
-	RESTORE_REGS
+	RESTORE_ALL_NMI
 	lss	12+4(%esp), %esp		# back to espfix stack
 	jmp	.Lirq_return
 #endif
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, Jiri Kosina <jkosina@suse.cz>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Brian Gerst <brgerst@gmail.com>,
	David Laight <David.Laight@aculab.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Eduardo Valentin <eduval@amazon.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Will Deacon <will.deacon@arm.com>,
	aliguori@amazon.com, daniel.gruss@iaik.tugraz.at,
	hughd@google.com, keescook@google.com,
	Andrea Arcangeli <aarcange@redhat.com>,
	Waiman Long <llong@redhat.com>, Pavel Machek <pavel@ucw.cz>,
	jroedel@suse.de, joro@8bytes.org
Subject: [PATCH 10/31] x86/entry/32: Introduce SAVE_ALL_NMI and RESTORE_ALL_NMI
Date: Fri,  9 Feb 2018 10:25:19 +0100	[thread overview]
Message-ID: <1518168340-9392-11-git-send-email-joro@8bytes.org> (raw)
In-Reply-To: <1518168340-9392-1-git-send-email-joro@8bytes.org>

From: Joerg Roedel <jroedel@suse.de>

These macros will be used in the NMI handler code and
replace plain SAVE_ALL and RESTORE_REGS there. We will add
the NMI-specific CR3-switch to these macros later.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 arch/x86/entry/entry_32.S | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S
index ba3d8c2..be1d814 100644
--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -167,6 +167,9 @@
 
 .endm
 
+.macro SAVE_ALL_NMI
+	SAVE_ALL
+.endm
 /*
  * This is a sneaky trick to help the unwinder find pt_regs on the stack.  The
  * frame pointer is replaced with an encoded pointer to pt_regs.  The encoding
@@ -224,6 +227,18 @@
 	RESTORE_SKIP_SEGMENTS \pop
 .endm
 
+.macro RESTORE_ALL_NMI pop=0
+	/*
+	 * Restore segments - might cause exceptions when loading
+	 * user-space segments
+	 */
+	RESTORE_SEGMENTS
+
+	/* Restore integer registers and unwind stack to iret frame */
+	RESTORE_INT_REGS
+	RESTORE_SKIP_SEGMENTS \pop
+.endm
+
 .macro CHECK_AND_APPLY_ESPFIX
 #ifdef CONFIG_X86_ESPFIX32
 #define GDT_ESPFIX_SS PER_CPU_VAR(gdt_page) + (GDT_ENTRY_ESPFIX_SS * 8)
@@ -1127,7 +1142,7 @@ ENTRY(nmi)
 #endif
 
 	pushl	%eax				# pt_regs->orig_ax
-	SAVE_ALL
+	SAVE_ALL_NMI
 	ENCODE_FRAME_POINTER
 	xorl	%edx, %edx			# zero error code
 	movl	%esp, %eax			# pt_regs pointer
@@ -1155,7 +1170,7 @@ ENTRY(nmi)
 
 .Lnmi_return:
 	CHECK_AND_APPLY_ESPFIX
-	RESTORE_REGS 4
+	RESTORE_ALL_NMI pop=4
 	jmp	.Lirq_return
 
 #ifdef CONFIG_X86_ESPFIX32
@@ -1171,12 +1186,12 @@ ENTRY(nmi)
 	pushl	16(%esp)
 	.endr
 	pushl	%eax
-	SAVE_ALL
+	SAVE_ALL_NMI
 	ENCODE_FRAME_POINTER
 	FIXUP_ESPFIX_STACK			# %eax == %esp
 	xorl	%edx, %edx			# zero error code
 	call	do_nmi
-	RESTORE_REGS
+	RESTORE_ALL_NMI
 	lss	12+4(%esp), %esp		# back to espfix stack
 	jmp	.Lirq_return
 #endif
-- 
2.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2018-02-09  9:25 UTC|newest]

Thread overview: 181+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  9:25 [PATCH 00/31 v2] PTI support for x86_32 Joerg Roedel
2018-02-09  9:25 ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 01/31] x86/asm-offsets: Move TSS_sp0 and TSS_sp1 to asm-offsets.c Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 02/31] x86/entry/32: Rename TSS_sysenter_sp0 to TSS_entry_stack Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 03/31] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 04/31] x86/entry/32: Put ESPFIX code into a macro Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 05/31] x86/entry/32: Unshare NMI return path Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 06/31] x86/entry/32: Split off return-to-kernel path Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 07/31] x86/entry/32: Restore segments before int registers Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 08/31] x86/entry/32: Enter the kernel via trampoline stack Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 09/31] x86/entry/32: Leave " Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09 17:05   ` Linus Torvalds
2018-02-09 17:05     ` Linus Torvalds
2018-02-09 17:17     ` Denys Vlasenko
2018-02-09 17:17       ` Denys Vlasenko
2018-02-10 15:26       ` David Laight
2018-02-10 15:26         ` David Laight
2018-02-10 20:18         ` Linus Torvalds
2018-02-10 20:18           ` Linus Torvalds
2018-02-09 17:43     ` Andy Lutomirski
2018-02-09 17:43       ` Andy Lutomirski
2018-02-09 19:06       ` Joerg Roedel
2018-02-09 19:06         ` Joerg Roedel
2018-02-09 19:02     ` Joerg Roedel
2018-02-09 19:02       ` Joerg Roedel
2018-02-09 19:17       ` Linus Torvalds
2018-02-09 19:17         ` Linus Torvalds
2018-02-09 19:25         ` Joerg Roedel
2018-02-09 19:25           ` Joerg Roedel
2018-02-09 19:48           ` Linus Torvalds
2018-02-09 19:48             ` Linus Torvalds
2018-02-10 15:41             ` David Laight
2018-02-10 15:41               ` David Laight
2018-02-09 19:30       ` Denys Vlasenko
2018-02-09 19:30         ` Denys Vlasenko
2018-02-09  9:25 ` Joerg Roedel [this message]
2018-02-09  9:25   ` [PATCH 10/31] x86/entry/32: Introduce SAVE_ALL_NMI and RESTORE_ALL_NMI Joerg Roedel
2018-02-09  9:25 ` [PATCH 11/31] x86/entry/32: Add PTI cr3 switches to NMI handler code Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 12/31] x86/entry/32: Add PTI cr3 switch to non-NMI entry/exit points Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-27 19:18   ` Waiman Long
2018-02-27 19:18     ` Waiman Long
2018-03-01 12:03     ` Joerg Roedel
2018-03-01 12:03       ` Joerg Roedel
2018-03-01 13:34     ` Joerg Roedel
2018-03-01 13:34       ` Joerg Roedel
2018-03-01 14:33       ` Waiman Long
2018-03-01 14:33         ` Waiman Long
2018-03-01 16:50         ` Joerg Roedel
2018-03-01 16:50           ` Joerg Roedel
2018-03-01 18:24           ` Brian Gerst
2018-03-01 18:24             ` Brian Gerst
2018-03-01 18:36             ` Dave Hansen
2018-03-01 18:36               ` Dave Hansen
2018-03-01 18:38             ` Linus Torvalds
2018-03-01 18:38               ` Linus Torvalds
2018-03-02  9:10               ` Joerg Roedel
2018-03-02  9:10                 ` Joerg Roedel
2018-03-16 20:55                 ` Andy Lutomirski
2018-03-02  9:07             ` Joerg Roedel
2018-03-02  9:07               ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 13/31] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 14/31] x86/pgtable/pae: Unshare kernel PMDs when PTI is enabled Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 15/31] x86/pgtable/32: Allocate 8k page-tables " Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 16/31] x86/pgtable: Move pgdp kernel/user conversion functions to pgtable.h Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 17/31] x86/pgtable: Move pti_set_user_pgd() " Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 18/31] x86/pgtable: Move two more functions from pgtable_64.h " Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 19/31] x86/mm/pae: Populate valid user PGD entries Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-14  9:45   ` Juergen Gross
2018-02-14  9:45     ` Juergen Gross
2018-02-14 10:00     ` Joerg Roedel
2018-02-14 10:00       ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 20/31] x86/mm/pae: Populate the user page-table with user pgd's Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09 17:48   ` Andy Lutomirski
2018-02-09 17:48     ` Andy Lutomirski
2018-02-09 19:09     ` Joerg Roedel
2018-02-09 19:09       ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 21/31] x86/mm/legacy: " Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 22/31] x86/mm/pti: Add an overflow check to pti_clone_pmds() Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 23/31] x86/mm/pti: Define X86_CR3_PTI_PCID_USER_BIT on x86_32 Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09 17:42   ` Andy Lutomirski
2018-02-09 17:42     ` Andy Lutomirski
2018-02-09  9:25 ` [PATCH 24/31] x86/mm/pti: Clone CPU_ENTRY_AREA on PMD level " Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 25/31] x86/mm/dump_pagetables: Define INIT_PGD Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 26/31] x86/pgtable/pae: Use separate kernel PMDs for user page-table Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 27/31] x86/ldt: Reserve address-space range on 32 bit for the LDT Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 28/31] x86/ldt: Define LDT_END_ADDR Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 29/31] x86/ldt: Split out sanity check in map_ldt_struct() Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 30/31] x86/ldt: Enable LDT user-mapping for PAE Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09  9:25 ` [PATCH 31/31] x86/pti: Allow CONFIG_PAGE_TABLE_ISOLATION for x86_32 Joerg Roedel
2018-02-09  9:25   ` Joerg Roedel
2018-02-09 12:11 ` [PATCH 00/31 v2] PTI support " Juergen Gross
2018-02-09 12:11   ` Juergen Gross
2018-02-09 13:35   ` Joerg Roedel
2018-02-09 13:35     ` Joerg Roedel
2018-02-09 13:54     ` Andrew Cooper
2018-02-09 13:54       ` Andrew Cooper
2018-02-09 17:47 ` Andy Lutomirski
2018-02-09 17:47   ` Andy Lutomirski
2018-02-09 19:11   ` Joerg Roedel
2018-02-09 19:11     ` Joerg Roedel
2018-02-10  9:15     ` Adam Borowski
2018-02-10  9:15       ` Adam Borowski
2018-02-10 20:22       ` Linus Torvalds
2018-02-10 20:22         ` Linus Torvalds
2018-02-11 10:59         ` Adam Borowski
2018-02-11 10:59           ` Adam Borowski
2018-02-11 17:40           ` Mark D Rustad
2018-02-11 19:42             ` Andy Lutomirski
2018-02-11 19:42               ` Andy Lutomirski
2018-02-11 20:14               ` Linus Torvalds
2018-02-11 20:14                 ` Linus Torvalds
2018-02-11 22:12               ` James Bottomley
2018-02-11 22:12                 ` James Bottomley
2018-02-11 22:30                 ` Andy Lutomirski
2018-02-11 22:30                   ` Andy Lutomirski
2018-02-11 23:47                   ` James Bottomley
2018-02-11 23:47                     ` James Bottomley
2018-02-11 22:34               ` Pavel Machek
2018-02-11 22:34                 ` Pavel Machek
2018-02-11 23:25               ` Alan Cox
2018-02-11 23:25                 ` Alan Cox
2018-02-12 10:16                 ` Anders Larsen
2018-02-12 10:16                   ` Anders Larsen
2018-02-14 10:43               ` Pavel Machek
2018-02-15  3:44                 ` joe.korty
2018-02-16 14:34                   ` Pavel Machek
2018-02-13  8:54             ` Greg KH
2018-02-13  8:54               ` Greg KH
2018-02-13 17:25               ` Linus Torvalds
2018-02-13 17:25                 ` Linus Torvalds
2018-02-14  8:54                 ` Greg KH
2018-02-14  8:54                   ` Greg KH
2018-02-21 10:26                   ` Lorenzo Colitti
2018-02-21 10:26                     ` Lorenzo Colitti
2018-02-21 16:59                     ` Arnd Bergmann
2018-02-21 16:59                       ` Arnd Bergmann
2018-02-22 11:10                       ` Greg KH
2018-02-22 11:10                         ` Greg KH
2018-02-22 11:18                         ` Arnd Bergmann
2018-02-22 11:18                           ` Arnd Bergmann
2018-03-06 15:39                 ` Jason A. Donenfeld
2018-03-06 15:39                   ` Jason A. Donenfeld
2018-03-06 15:39                   ` Jason A. Donenfeld
2018-02-11 19:13     ` Ingo Molnar
2018-02-11 19:13       ` Ingo Molnar
2018-02-12 14:51       ` Joerg Roedel
2018-02-12 14:51         ` Joerg Roedel
2018-02-09 21:09   ` Pavel Machek
2018-02-09 21:11     ` Linus Torvalds
2018-02-09 21:11       ` Linus Torvalds
2018-02-09 21:28     ` Andrew Cooper
2018-02-09 21:28       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518168340-9392-11-git-send-email-joro@8bytes.org \
    --to=joro@8bytes.org \
    --cc=David.Laight@aculab.com \
    --cc=aarcange@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=daniel.gruss@iaik.tugraz.at \
    --cc=dave.hansen@intel.com \
    --cc=dvlasenk@redhat.com \
    --cc=eduval@amazon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jgross@suse.com \
    --cc=jkosina@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=jroedel@suse.de \
    --cc=keescook@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=llong@redhat.com \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.