* [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect
@ 2018-02-09 19:56 Tushar Dave
2018-02-14 1:44 ` Alexei Starovoitov
2018-02-14 2:56 ` John Fastabend
0 siblings, 2 replies; 3+ messages in thread
From: Tushar Dave @ 2018-02-09 19:56 UTC (permalink / raw)
To: ast, daniel, netdev
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
e.g.
[root@labbpf]# ./xdp_redirect $(</sys/class/net/eth2/ifindex) \
> $(</sys/class/net/eth3/ifindex)
failed to create a map: 1 Operation not permitted
The failure is seen when executing xdp_redirect while xdp_monitor
is already runnig.
Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
---
samples/bpf/xdp_redirect_user.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c
index 4475d83..2490235 100644
--- a/samples/bpf/xdp_redirect_user.c
+++ b/samples/bpf/xdp_redirect_user.c
@@ -20,6 +20,7 @@
#include <string.h>
#include <unistd.h>
#include <libgen.h>
+#include <sys/resource.h>
#include "bpf_load.h"
#include "bpf_util.h"
@@ -75,6 +76,7 @@ static void usage(const char *prog)
int main(int argc, char **argv)
{
+ struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
const char *optstr = "SN";
char filename[256];
int ret, opt, key = 0;
@@ -98,6 +100,11 @@ int main(int argc, char **argv)
return 1;
}
+ if (setrlimit(RLIMIT_MEMLOCK, &r)) {
+ perror("setrlimit(RLIMIT_MEMLOCK)");
+ return 1;
+ }
+
ifindex_in = strtoul(argv[optind], NULL, 0);
ifindex_out = strtoul(argv[optind + 1], NULL, 0);
printf("input: %d output: %d\n", ifindex_in, ifindex_out);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect
2018-02-09 19:56 [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect Tushar Dave
@ 2018-02-14 1:44 ` Alexei Starovoitov
2018-02-14 2:56 ` John Fastabend
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2018-02-14 1:44 UTC (permalink / raw)
To: Tushar Dave; +Cc: ast, daniel, netdev
On Fri, Feb 09, 2018 at 11:56:12AM -0800, Tushar Dave wrote:
> Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
> e.g.
> [root@labbpf]# ./xdp_redirect $(</sys/class/net/eth2/ifindex) \
> > $(</sys/class/net/eth3/ifindex)
> failed to create a map: 1 Operation not permitted
>
> The failure is seen when executing xdp_redirect while xdp_monitor
> is already runnig.
>
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
Applied to bpf-next, thanks Tushar.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect
2018-02-09 19:56 [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect Tushar Dave
2018-02-14 1:44 ` Alexei Starovoitov
@ 2018-02-14 2:56 ` John Fastabend
1 sibling, 0 replies; 3+ messages in thread
From: John Fastabend @ 2018-02-14 2:56 UTC (permalink / raw)
To: Tushar Dave, ast, daniel, netdev
On 02/09/2018 11:56 AM, Tushar Dave wrote:
> Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
> e.g.
> [root@labbpf]# ./xdp_redirect $(</sys/class/net/eth2/ifindex) \
>> $(</sys/class/net/eth3/ifindex)
> failed to create a map: 1 Operation not permitted
>
> The failure is seen when executing xdp_redirect while xdp_monitor
> is already runnig.
>
> Signed-off-by: Tushar Dave <tushar.n.dave@oracle.com>
> ---
Looks good to me.
Acked-by: John Fastabend <john.fastabend@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-14 2:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09 19:56 [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect Tushar Dave
2018-02-14 1:44 ` Alexei Starovoitov
2018-02-14 2:56 ` John Fastabend
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.