* [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
@ 2018-02-12 21:30 Anusha Srivatsa
2018-02-12 22:35 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-13 1:38 ` ✗ Fi.CI.IGT: failure " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Anusha Srivatsa @ 2018-02-12 21:30 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, Rodrigo Vivi
Rework the rotate and reflect subtests by checking the
crtc supported properties against the ones that the
test is testing. Remove the hardcoded platform names in
igt_require()
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
tests/kms_rotation_crc.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 0cd5c6e..49d57a2 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -373,9 +373,6 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
igt_plane_t *plane;
int i, j;
- if (IS_CHERRYVIEW(data->devid) && pipe != PIPE_B)
- continue;
-
igt_output_set_pipe(output, pipe);
plane = igt_output_get_plane_type(output, plane_type);
@@ -558,9 +555,7 @@ igt_main
igt_subtest_f("%s-rotation-%s",
plane_test_str(subtest->plane),
rot_test_str(subtest->rot)) {
- igt_require(!(subtest->rot &
- (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
- gen >= 9);
+ igt_require(igt_plane_get_prop(data.display.pipes->planes, IGT_PLANE_ROTATION) & subtest->rot);
data.rotation = subtest->rot;
test_plane_rotation(&data, subtest->plane, false);
}
@@ -596,9 +591,8 @@ igt_main
igt_subtest_f("primary-%s-reflect-x-%s",
tiling_test_str(reflect_x->tiling),
rot_test_str(reflect_x->rot)) {
- igt_require(gen >= 10 ||
- (IS_CHERRYVIEW(data.devid) && reflect_x->rot == IGT_ROTATION_0
- && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
+ igt_require((igt_plane_get_prop(data.display.pipes->planes, IGT_PLANE_ROTATION) & subtest->rot) &&
+ (reflect_x->rot == IGT_ROTATION_0 && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
data.rotation = (IGT_REFLECT_X | reflect_x->rot);
data.override_tiling = reflect_x->tiling;
test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, false);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-12 21:30 [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
@ 2018-02-12 22:35 ` Patchwork
2018-02-13 1:38 ` ✗ Fi.CI.IGT: failure " Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-02-12 22:35 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
URL : https://patchwork.freedesktop.org/series/38108/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
f8d6fa4fa04103b027430f960f2c55d24c4a9600 igt/gem_exec_capture: MI_STORE_DWORD requires EXEC_SECURE + DRM_MASTER on ctg/ilk
with latest DRM-Tip kernel build CI_DRM_3757
83878f486e68 drm-tip: 2018y-02m-12d-17h-43m-07s UTC integration manifest
No testlist changes.
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (fi-ilk-650)
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:265 dwarn:0 dfail:0 fail:2 skip:21 time:440s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:434s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:375s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:496s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:290s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:480s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:489s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:475s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:460s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:566s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:584s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:419s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:285s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:513s
fi-hsw-4770 total:288 pass:259 dwarn:0 dfail:0 fail:2 skip:27 time:411s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:418s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:452s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:416s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:459s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:499s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:502s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:589s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:427s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:513s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:529s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:492s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:477s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:417s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:431s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:398s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:472s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_905/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.IGT: failure for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-12 21:30 [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
2018-02-12 22:35 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-02-13 1:38 ` Patchwork
2018-02-23 10:56 ` Arkadiusz Hiler
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2018-02-13 1:38 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
URL : https://patchwork.freedesktop.org/series/38108/
State : failure
== Summary ==
Test pm_rpm:
Subgroup sysfs-read:
fail -> PASS (shard-hsw)
Subgroup gem-mmap-cpu:
skip -> PASS (shard-apl)
Subgroup system-suspend-modeset:
skip -> PASS (shard-apl)
Subgroup modeset-lpsp:
fail -> SKIP (shard-hsw)
Subgroup reg-read-ioctl:
fail -> PASS (shard-hsw)
Subgroup modeset-non-lpsp:
fail -> PASS (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-render:
skip -> PASS (shard-apl) fdo#103167
Test kms_mmio_vs_cs_flip:
Subgroup setcrtc_vs_cs_flip:
skip -> PASS (shard-apl)
Test kms_vblank:
Subgroup pipe-b-ts-continuation-suspend:
pass -> SKIP (shard-snb)
Subgroup pipe-b-wait-busy:
skip -> PASS (shard-apl)
Test kms_rmfb:
Subgroup rmfb-ioctl:
skip -> PASS (shard-apl)
Test kms_rotation_crc:
Subgroup primary-rotation-180:
pass -> SKIP (shard-snb)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-apl) fdo#103925 +1
Subgroup exhaust-fences:
skip -> PASS (shard-apl)
Subgroup sprite-rotation-270:
pass -> SKIP (shard-apl) fdo#103356 +1
Subgroup primary-rotation-270:
pass -> SKIP (shard-apl)
Subgroup cursor-rotation-180:
pass -> SKIP (shard-snb)
pass -> SKIP (shard-hsw) fdo#102614
pass -> SKIP (shard-apl)
Subgroup sprite-rotation-180:
pass -> SKIP (shard-snb)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-apl)
Test kms_color:
Subgroup pipe-c-ctm-max:
skip -> PASS (shard-apl)
Subgroup pipe-c-degamma:
skip -> PASS (shard-apl)
Subgroup pipe-b-ctm-green-to-red:
skip -> PASS (shard-apl)
Subgroup pipe-a-legacy-gamma:
pass -> FAIL (shard-apl)
Test kms_flip:
Subgroup wf_vblank-ts-check-interruptible:
skip -> PASS (shard-apl) fdo#100368
Subgroup blocking-absolute-wf_vblank:
skip -> PASS (shard-apl)
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-crc-legacy:
skip -> PASS (shard-apl)
Subgroup flip-vs-cursor-atomic:
pass -> FAIL (shard-apl) fdo#102670
Subgroup cursora-vs-flipa-legacy:
skip -> PASS (shard-apl)
Test perf:
Subgroup oa-exponents:
fail -> PASS (shard-apl) fdo#102254
Test kms_plane_scaling:
Subgroup pipe-a-scaler-with-rotation:
skip -> PASS (shard-apl)
Test kms_chv_cursor_fail:
Subgroup pipe-b-128x128-top-edge:
pass -> SKIP (shard-snb)
Test pm_lpsp:
Subgroup screens-disabled:
fail -> PASS (shard-hsw) fdo#104941
Test gem_eio:
Subgroup in-flight-contexts:
fail -> PASS (shard-hsw) fdo#104676
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103356 https://bugs.freedesktop.org/show_bug.cgi?id=103356
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#104941 https://bugs.freedesktop.org/show_bug.cgi?id=104941
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
shard-apl total:3381 pass:1743 dwarn:1 dfail:0 fail:22 skip:1614 time:13704s
shard-hsw total:3427 pass:1718 dwarn:1 dfail:0 fail:49 skip:1658 time:14689s
shard-snb total:3427 pass:1344 dwarn:1 dfail:0 fail:10 skip:2072 time:7536s
Blacklisted hosts:
shard-kbl total:3427 pass:1862 dwarn:36 dfail:2 fail:20 skip:1507 time:11007s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_905/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
2018-02-13 1:38 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-02-23 10:56 ` Arkadiusz Hiler
0 siblings, 0 replies; 4+ messages in thread
From: Arkadiusz Hiler @ 2018-02-23 10:56 UTC (permalink / raw)
To: intel-gfx
On Tue, Feb 13, 2018 at 01:38:21AM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require()
> URL : https://patchwork.freedesktop.org/series/38108/
> State : failure
>
> == Summary ==
>
> Test kms_rotation_crc:
> Subgroup primary-rotation-180:
> pass -> SKIP (shard-snb)
> pass -> SKIP (shard-hsw)
> pass -> SKIP (shard-apl) fdo#103925 +1
> Subgroup exhaust-fences:
> skip -> PASS (shard-apl)
> Subgroup sprite-rotation-270:
> pass -> SKIP (shard-apl) fdo#103356 +1
> Subgroup primary-rotation-270:
> pass -> SKIP (shard-apl)
> Subgroup cursor-rotation-180:
> pass -> SKIP (shard-snb)
> pass -> SKIP (shard-hsw) fdo#102614
> pass -> SKIP (shard-apl)
> Subgroup sprite-rotation-180:
> pass -> SKIP (shard-snb)
> pass -> SKIP (shard-hsw)
> pass -> SKIP (shard-apl)
This is strange. Those tests were previously passing on apl, hsw and snb
and now there are skipping? Is the kernel misadvertising properties for
those GENs?
--
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-23 10:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-12 21:30 [i-g-t] tests/kms_rotation_crc: Remove hardcoding of platforms in igt_require() Anusha Srivatsa
2018-02-12 22:35 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-13 1:38 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-02-23 10:56 ` Arkadiusz Hiler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.