From: Jerome Brunet <jbrunet@baylibre.com>
To: Yixun Lan <yixun.lan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh@kernel.org>, Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: meson-axg: Add AO Clock and Reset controller driver
Date: Tue, 13 Feb 2018 15:51:33 +0100 [thread overview]
Message-ID: <1518533493.2883.35.camel@baylibre.com> (raw)
In-Reply-To: <1518449571.2883.30.camel@baylibre.com>
On Mon, 2018-02-12 at 16:32 +0100, Jerome Brunet wrote:
> On Fri, 2018-02-09 at 15:00 +0800, Yixun Lan wrote:
> > Adds a Clock and Reset controller driver for the Always-On part
> > of the Amlogic Meson-AXG SoC.
> >
> > Signed-off-by: Qiufang Dai <qiufang.dai@amlogic.com>
> > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> > ---
> > drivers/clk/meson/Makefile | 2 +-
> > drivers/clk/meson/axg-aoclk.c | 236 ++++++++++++++++++++++++++++++++++++++++++
> > drivers/clk/meson/axg-aoclk.h | 25 +++++
> > 3 files changed, 262 insertions(+), 1 deletion(-)
> > create mode 100644 drivers/clk/meson/axg-aoclk.c
> > create mode 100644 drivers/clk/meson/axg-aoclk.h
Yixun,
Actually, looking at this driver further, except for some of the data, the
driver is exactly the same as gxbb-aoclk. There is no reason to duplicate all
this code.
I'd prefer if you'd factor all this in a dedicated driver.
This philosophy is more or less the same as meson's pinctrl drivers, which all
provides their own data and bindings but share the driver code.
Regards
Jerome
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: meson-axg: Add AO Clock and Reset controller driver
Date: Tue, 13 Feb 2018 15:51:33 +0100 [thread overview]
Message-ID: <1518533493.2883.35.camel@baylibre.com> (raw)
In-Reply-To: <1518449571.2883.30.camel@baylibre.com>
On Mon, 2018-02-12 at 16:32 +0100, Jerome Brunet wrote:
> On Fri, 2018-02-09 at 15:00 +0800, Yixun Lan wrote:
> > Adds a Clock and Reset controller driver for the Always-On part
> > of the Amlogic Meson-AXG SoC.
> >
> > Signed-off-by: Qiufang Dai <qiufang.dai@amlogic.com>
> > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> > ---
> > drivers/clk/meson/Makefile | 2 +-
> > drivers/clk/meson/axg-aoclk.c | 236 ++++++++++++++++++++++++++++++++++++++++++
> > drivers/clk/meson/axg-aoclk.h | 25 +++++
> > 3 files changed, 262 insertions(+), 1 deletion(-)
> > create mode 100644 drivers/clk/meson/axg-aoclk.c
> > create mode 100644 drivers/clk/meson/axg-aoclk.h
Yixun,
Actually, looking at this driver further, except for some of the data, the
driver is exactly the same as gxbb-aoclk. There is no reason to duplicate all
this code.
I'd prefer if you'd factor all this in a dedicated driver.
This philosophy is more or less the same as meson's pinctrl drivers, which all
provides their own data and bindings but share the driver code.
Regards
Jerome
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/2] clk: meson-axg: Add AO Clock and Reset controller driver
Date: Tue, 13 Feb 2018 15:51:33 +0100 [thread overview]
Message-ID: <1518533493.2883.35.camel@baylibre.com> (raw)
In-Reply-To: <1518449571.2883.30.camel@baylibre.com>
On Mon, 2018-02-12 at 16:32 +0100, Jerome Brunet wrote:
> On Fri, 2018-02-09 at 15:00 +0800, Yixun Lan wrote:
> > Adds a Clock and Reset controller driver for the Always-On part
> > of the Amlogic Meson-AXG SoC.
> >
> > Signed-off-by: Qiufang Dai <qiufang.dai@amlogic.com>
> > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> > ---
> > drivers/clk/meson/Makefile | 2 +-
> > drivers/clk/meson/axg-aoclk.c | 236 ++++++++++++++++++++++++++++++++++++++++++
> > drivers/clk/meson/axg-aoclk.h | 25 +++++
> > 3 files changed, 262 insertions(+), 1 deletion(-)
> > create mode 100644 drivers/clk/meson/axg-aoclk.c
> > create mode 100644 drivers/clk/meson/axg-aoclk.h
Yixun,
Actually, looking at this driver further, except for some of the data, the
driver is exactly the same as gxbb-aoclk. There is no reason to duplicate all
this code.
I'd prefer if you'd factor all this in a dedicated driver.
This philosophy is more or less the same as meson's pinctrl drivers, which all
provides their own data and bindings but share the driver code.
Regards
Jerome
next prev parent reply other threads:[~2018-02-13 14:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 7:00 [PATCH 0/2] clk: meson-axg: Add AO Cloclk and Reset driver Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-09 7:00 ` [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-09 11:07 ` Philippe Ombredanne
2018-02-09 11:07 ` Philippe Ombredanne
2018-02-09 11:07 ` Philippe Ombredanne
2018-03-23 14:06 ` Yixun Lan
2018-03-23 14:06 ` Yixun Lan
2018-03-23 14:06 ` Yixun Lan
2018-03-23 14:06 ` Yixun Lan
2018-02-09 7:00 ` [PATCH 2/2] clk: meson-axg: Add AO Clock and Reset controller driver Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-09 7:00 ` Yixun Lan
2018-02-12 15:32 ` Jerome Brunet
2018-02-12 15:32 ` Jerome Brunet
2018-02-12 15:32 ` Jerome Brunet
2018-02-13 14:51 ` Jerome Brunet [this message]
2018-02-13 14:51 ` Jerome Brunet
2018-02-13 14:51 ` Jerome Brunet
2018-03-23 14:13 ` Yixun Lan
2018-03-23 14:13 ` Yixun Lan
2018-03-23 14:13 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518533493.2883.35.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=carlo@caione.org \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.