All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: broonie@kernel.org
Cc: Fabio Estevam <fabio.estevam@nxp.com>, alsa-devel@alsa-project.org
Subject: [PATCH 3/3] ASoC: soc-dapm: Use empty struct initializer
Date: Wed, 14 Feb 2018 13:39:05 -0200	[thread overview]
Message-ID: <1518622745-12162-3-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1518622745-12162-1-git-send-email-festevam@gmail.com>

From: Fabio Estevam <fabio.estevam@nxp.com>

{ NULL } only clears the first member of the structure.

Even though the first member of the snd_soc_dapm_update struct is a
pointer,it is more robust to use the empty struct initializer that
clears all the struct members.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 sound/soc/soc-dapm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 92894d9..2f34590 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3165,7 +3165,7 @@ int snd_soc_dapm_put_volsw(struct snd_kcontrol *kcontrol,
 	unsigned int invert = mc->invert;
 	unsigned int val, rval = 0;
 	int connect, rconnect = -1, change, reg_change = 0;
-	struct snd_soc_dapm_update update = { NULL };
+	struct snd_soc_dapm_update update = {};
 	int ret = 0;
 
 	val = (ucontrol->value.integer.value[0] & mask);
@@ -3292,7 +3292,7 @@ int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol,
 	unsigned int *item = ucontrol->value.enumerated.item;
 	unsigned int val, change, reg_change = 0;
 	unsigned int mask;
-	struct snd_soc_dapm_update update = { NULL };
+	struct snd_soc_dapm_update update = {};
 	int ret = 0;
 
 	if (item[0] >= e->items)
-- 
2.7.4

  parent reply	other threads:[~2018-02-14 15:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 15:39 [PATCH 1/3] ASoC: adau17x1: Use empty struct initializer Fabio Estevam
2018-02-14 15:39 ` [PATCH 2/3] ASoC: wm9713: " Fabio Estevam
2018-02-14 15:48   ` Charles Keepax
2018-02-14 16:28   ` Applied "ASoC: wm9713: Use empty struct initializer" to the asoc tree Mark Brown
2018-02-14 16:41   ` [PATCH 2/3] ASoC: wm9713: Use empty struct initializer Richard Fitzgerald
2018-02-14 16:49     ` Fabio Estevam
2018-02-14 16:51       ` Fabio Estevam
2018-02-14 16:56       ` Richard Fitzgerald
2018-02-14 17:01         ` Fabio Estevam
2018-02-14 17:15           ` Richard Fitzgerald
2018-02-14 17:19             ` Fabio Estevam
2018-02-14 15:39 ` Fabio Estevam [this message]
2018-02-14 16:28   ` Applied "ASoC: soc-dapm: Use empty struct initializer" to the asoc tree Mark Brown
2018-02-14 16:28 ` Applied "ASoC: adau17x1: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518622745-12162-3-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.