From: Fabio Estevam <festevam@gmail.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [PATCH 2/3] ASoC: wm9713: Use empty struct initializer
Date: Wed, 14 Feb 2018 14:49:01 -0200 [thread overview]
Message-ID: <CAOMZO5BS9oiDPT3oEK7ROhetJcHmfWL+XGZsY9ncMJsB9Qcbww@mail.gmail.com> (raw)
In-Reply-To: <938aa54c-c599-9efc-e78f-4e72db08199e@opensource.cirrus.com>
On Wed, Feb 14, 2018 at 2:41 PM, Richard Fitzgerald
<rf@opensource.cirrus.com> wrote:
> This is the actual problem you are trying to fix? The comment about
> { 0 } only clearing the first member is probably bogus, your actual
> problem is that it should have been { NULL } ?
Changing to { NULL } fixes the sparse warning, but that would be a
fragile fix because it relies on the order of the struct members.
If someday the struct changes in a way so that the first member is no
longer a pointer, then we will have issues again.
Using {} is more error prone.
next prev parent reply other threads:[~2018-02-14 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:39 [PATCH 1/3] ASoC: adau17x1: Use empty struct initializer Fabio Estevam
2018-02-14 15:39 ` [PATCH 2/3] ASoC: wm9713: " Fabio Estevam
2018-02-14 15:48 ` Charles Keepax
2018-02-14 16:28 ` Applied "ASoC: wm9713: Use empty struct initializer" to the asoc tree Mark Brown
2018-02-14 16:41 ` [PATCH 2/3] ASoC: wm9713: Use empty struct initializer Richard Fitzgerald
2018-02-14 16:49 ` Fabio Estevam [this message]
2018-02-14 16:51 ` Fabio Estevam
2018-02-14 16:56 ` Richard Fitzgerald
2018-02-14 17:01 ` Fabio Estevam
2018-02-14 17:15 ` Richard Fitzgerald
2018-02-14 17:19 ` Fabio Estevam
2018-02-14 15:39 ` [PATCH 3/3] ASoC: soc-dapm: " Fabio Estevam
2018-02-14 16:28 ` Applied "ASoC: soc-dapm: Use empty struct initializer" to the asoc tree Mark Brown
2018-02-14 16:28 ` Applied "ASoC: adau17x1: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5BS9oiDPT3oEK7ROhetJcHmfWL+XGZsY9ncMJsB9Qcbww@mail.gmail.com \
--to=festevam@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=fabio.estevam@nxp.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.