* [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect
@ 2010-06-03 18:19 Cole Robinson
2010-06-03 21:41 ` Yoshiaki Tamura
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Cole Robinson @ 2010-06-03 18:19 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
** Affects: qemu
Importance: Undecided
Status: New
--
qemu: Improve error reporting when migration can't connect
https://bugs.launchpad.net/bugs/589315
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect
2010-06-03 18:19 [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect Cole Robinson
@ 2010-06-03 21:41 ` Yoshiaki Tamura
2010-06-09 16:43 ` Cole Robinson
2010-06-04 14:25 ` [Qemu-devel] [Bug 589315] " Luiz Capitulino
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Yoshiaki Tamura @ 2010-06-03 21:41 UTC (permalink / raw)
To: Bug 589315; +Cc: qemu-devel, crobinso
2010/6/4 Cole Robinson <crobinso@redhat.com>:
> Public bug reported:
>
> Tested with upstream qemu as of Jun 3 2010
>
> If the source qemu instance can't connect to the migration destination (say
> there is no listening QEMU instance, or port is blocked by a firewall), all we
> get is info migrate -> Migration status: failed. This is all we have to report
> back to libvirt users if their firewall is misconfigured, which is crappy.
>
> Ideally, if we can't connect, migration would fail immediately with a relevant
> message and strerror(). More info from 'info migrate' would be nice too, no
> idea how this will play with QMP though.
>
> As a slightly related issue, try entering
>
> migrate tcp:127.0.0.0:6000
>
> We get a 'migration failed' error, and then the monitor hangs!
>
> ** Affects: qemu
> Importance: Undecided
> Status: New
>
> --
> qemu: Improve error reporting when migration can't connect
> https://bugs.launchpad.net/bugs/589315
> You received this bug notification because you are a member of qemu-
> devel-ml, which is subscribed to QEMU.
>
> Status in QEMU: New
>
> Bug description:
> Tested with upstream qemu as of Jun 3 2010
>
> If the source qemu instance can't connect to the migration destination (say
> there is no listening QEMU instance, or port is blocked by a firewall), all we
> get is info migrate -> Migration status: failed. This is all we have to report
> back to libvirt users if their firewall is misconfigured, which is crappy.
>
> Ideally, if we can't connect, migration would fail immediately with a relevant
> message and strerror(). More info from 'info migrate' would be nice too, no
> idea how this will play with QMP though.
>
> As a slightly related issue, try entering
>
> migrate tcp:127.0.0.0:6000
>
> We get a 'migration failed' error, and then the monitor hangs!
>
Hi,
Does the following patch fix the problem?
Thanks,
Yoshi
[PATCH] migration-tcp: call migrate_fd_error() instead of close() and free().
This patch fixes the following error report. When changing
migration-tcp.c to call migrate_fd_error() instead of close() and
free() by itself, monitor is resumed, and returns allocated mig_state
is set to current_migration in migration.c allows us to print "info
migrate".
Reported-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
--
qemu: Improve error reporting when migration can't connect
https://bugs.launchpad.net/bugs/589315
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
--
---
migration-tcp.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/migration-tcp.c b/migration-tcp.c
index 95ce722..43af2e0 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -128,9 +128,7 @@ MigrationState *tcp_start_outgoing_migration(Monitor *mon,
if (ret < 0 && ret != -EINPROGRESS && ret != -EWOULDBLOCK) {
DPRINTF("connect failed\n");
- close(s->fd);
- qemu_free(s);
- return NULL;
+ migrate_fd_error(s);
} else if (ret >= 0)
migrate_fd_connect(s);
--
1.7.0.31.g1df487
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 589315] Re: qemu: Improve error reporting when migration can't connect
2010-06-03 18:19 [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect Cole Robinson
2010-06-03 21:41 ` Yoshiaki Tamura
@ 2010-06-04 14:25 ` Luiz Capitulino
2010-06-09 21:38 ` Yoshiaki Tamura
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Luiz Capitulino @ 2010-06-04 14:25 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: New => Confirmed
--
qemu: Improve error reporting when migration can't connect
https://bugs.launchpad.net/bugs/589315
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Confirmed
Bug description:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect
2010-06-03 21:41 ` Yoshiaki Tamura
@ 2010-06-09 16:43 ` Cole Robinson
0 siblings, 0 replies; 7+ messages in thread
From: Cole Robinson @ 2010-06-09 16:43 UTC (permalink / raw)
To: Yoshiaki Tamura; +Cc: qemu-devel
On 06/03/2010 05:41 PM, Yoshiaki Tamura wrote:
>
> Hi,
>
> Does the following patch fix the problem?
>
> Thanks,
>
> Yoshi
>
> [PATCH] migration-tcp: call migrate_fd_error() instead of close() and free().
>
> This patch fixes the following error report. When changing
> migration-tcp.c to call migrate_fd_error() instead of close() and
> free() by itself, monitor is resumed, and returns allocated mig_state
> is set to current_migration in migration.c allows us to print "info
> migrate".
>
> Reported-by: Cole Robinson <crobinso@redhat.com>
> Signed-off-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
>
> --
> qemu: Improve error reporting when migration can't connect
> https://bugs.launchpad.net/bugs/589315
> You received this bug notification because you are a member of qemu-
> devel-ml, which is subscribed to QEMU.
>
> Status in QEMU: New
>
> Bug description:
> Tested with upstream qemu as of Jun 3 2010
>
> If the source qemu instance can't connect to the migration destination (say
> there is no listening QEMU instance, or port is blocked by a firewall), all we
> get is info migrate -> Migration status: failed. This is all we have to report
> back to libvirt users if their firewall is misconfigured, which is crappy.
>
> Ideally, if we can't connect, migration would fail immediately with a relevant
> message and strerror(). More info from 'info migrate' would be nice too, no
> idea how this will play with QMP though.
>
> As a slightly related issue, try entering
>
> migrate tcp:127.0.0.0:6000
>
> We get a 'migration failed' error, and then the monitor hangs!
> --
> ---
> migration-tcp.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/migration-tcp.c b/migration-tcp.c
> index 95ce722..43af2e0 100644
> --- a/migration-tcp.c
> +++ b/migration-tcp.c
> @@ -128,9 +128,7 @@ MigrationState *tcp_start_outgoing_migration(Monitor *mon,
>
> if (ret < 0 && ret != -EINPROGRESS && ret != -EWOULDBLOCK) {
> DPRINTF("connect failed\n");
> - close(s->fd);
> - qemu_free(s);
> - return NULL;
> + migrate_fd_error(s);
> } else if (ret >= 0)
> migrate_fd_connect(s);
>
Yes, this fixes the monitor hang. Thanks!
- Cole
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 589315] Re: qemu: Improve error reporting when migration can't connect
2010-06-03 18:19 [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect Cole Robinson
2010-06-03 21:41 ` Yoshiaki Tamura
2010-06-04 14:25 ` [Qemu-devel] [Bug 589315] " Luiz Capitulino
@ 2010-06-09 21:38 ` Yoshiaki Tamura
2018-02-14 16:39 ` Dr. David Alan Gilbert
2018-02-16 23:16 ` Thomas Huth
4 siblings, 0 replies; 7+ messages in thread
From: Yoshiaki Tamura @ 2010-06-09 21:38 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Confirmed => In Progress
--
qemu: Improve error reporting when migration can't connect
https://bugs.launchpad.net/bugs/589315
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: In Progress
Bug description:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 589315] Re: qemu: Improve error reporting when migration can't connect
2010-06-03 18:19 [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect Cole Robinson
` (2 preceding siblings ...)
2010-06-09 21:38 ` Yoshiaki Tamura
@ 2018-02-14 16:39 ` Dr. David Alan Gilbert
2018-02-16 23:16 ` Thomas Huth
4 siblings, 0 replies; 7+ messages in thread
From: Dr. David Alan Gilbert @ 2018-02-14 16:39 UTC (permalink / raw)
To: qemu-devel
yep, it's been giving errors now for a while (and not hanging) and also
recently gained the error text in 'info migrate':
[dgilbert@dgilbert-t530 ~]$ /usr/bin/qemu-system-x86_64 -nographic
QEMU 2.10.1 monitor - type 'help' for more information
(qemu) migrate tcp:0:12345
qemu-system-x86_64: Failed to connect socket: Connection refused
(qemu) info migrate
globals: store-global-state=1, only_migratable=0, send-configuration=1, send-section-footer=1
capabilities: xbzrle: off rdma-pin-all: off auto-converge: off zero-blocks: off compress: off events: off postcopy-ram: off x-colo: off release-ram: off block: off return-path: off
Migration status: failed (Failed to connect socket: Connection refused)
total time: 0 milliseconds
(qemu)
So marking as fix-release
(Note that there's a bug that causes a crash in the disconnect case on
current head, but that's only been in for a week or so and I've just
sent a fix for it).
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/589315
Title:
qemu: Improve error reporting when migration can't connect
Status in QEMU:
In Progress
Bug description:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/589315/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 589315] Re: qemu: Improve error reporting when migration can't connect
2010-06-03 18:19 [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect Cole Robinson
` (3 preceding siblings ...)
2018-02-14 16:39 ` Dr. David Alan Gilbert
@ 2018-02-16 23:16 ` Thomas Huth
4 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2018-02-16 23:16 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/589315
Title:
qemu: Improve error reporting when migration can't connect
Status in QEMU:
Fix Released
Bug description:
Tested with upstream qemu as of Jun 3 2010
If the source qemu instance can't connect to the migration destination (say
there is no listening QEMU instance, or port is blocked by a firewall), all we
get is info migrate -> Migration status: failed. This is all we have to report
back to libvirt users if their firewall is misconfigured, which is crappy.
Ideally, if we can't connect, migration would fail immediately with a relevant
message and strerror(). More info from 'info migrate' would be nice too, no
idea how this will play with QMP though.
As a slightly related issue, try entering
migrate tcp:127.0.0.0:6000
We get a 'migration failed' error, and then the monitor hangs!
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/589315/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-16 23:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-03 18:19 [Qemu-devel] [Bug 589315] [NEW] qemu: Improve error reporting when migration can't connect Cole Robinson
2010-06-03 21:41 ` Yoshiaki Tamura
2010-06-09 16:43 ` Cole Robinson
2010-06-04 14:25 ` [Qemu-devel] [Bug 589315] " Luiz Capitulino
2010-06-09 21:38 ` Yoshiaki Tamura
2018-02-14 16:39 ` Dr. David Alan Gilbert
2018-02-16 23:16 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.