From: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> To: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Linus Walleij <linus.walleij@linaro.org>, Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com>, Benjamin Gaignard <benjamin.gaignard@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH 1/2] ARM: irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain Date: Wed, 21 Feb 2018 14:50:26 +0100 [thread overview] Message-ID: <1519221027-4028-2-git-send-email-radoslaw.pietrzyk@gmail.com> (raw) In-Reply-To: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> - allocates generic chip with handle_simple_irq which simplifies irq_domain_ops.alloc callback - removes ack register from generic chip which is not used for handle_simple_irq as acking is done in a chained handler - removes unneeded irq_domain_ops.xlate callback Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> --- drivers/irqchip/irq-stm32-exti.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index 36f0fbe..42e74e3 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -176,16 +176,12 @@ static int stm32_irq_set_wake(struct irq_data *data, unsigned int on) static int stm32_exti_alloc(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs, void *data) { - struct irq_chip_generic *gc; struct irq_fwspec *fwspec = data; irq_hw_number_t hwirq; hwirq = fwspec->param[0]; - gc = irq_get_domain_generic_chip(d, hwirq); irq_map_generic_chip(d, virq, hwirq); - irq_domain_set_info(d, virq, hwirq, &gc->chip_types->chip, gc, - handle_simple_irq, NULL, NULL); return 0; } @@ -200,7 +196,6 @@ static void stm32_exti_free(struct irq_domain *d, unsigned int virq, struct irq_domain_ops irq_exti_domain_ops = { .map = irq_map_generic_chip, - .xlate = irq_domain_xlate_onetwocell, .alloc = stm32_exti_alloc, .free = stm32_exti_free, }; @@ -231,7 +226,7 @@ __init stm32_exti_init(const struct stm32_exti_bank **stm32_exti_banks, } ret = irq_alloc_domain_generic_chips(domain, IRQS_PER_BANK, 1, "exti", - handle_edge_irq, clr, 0, 0); + handle_simple_irq, clr, 0, 0); if (ret) { pr_err("%pOF: Could not allocate generic interrupt chip.\n", node); @@ -246,13 +241,10 @@ __init stm32_exti_init(const struct stm32_exti_bank **stm32_exti_banks, gc->reg_base = base; gc->chip_types->type = IRQ_TYPE_EDGE_BOTH; - gc->chip_types->chip.irq_ack = irq_gc_ack_set_bit; gc->chip_types->chip.irq_mask = irq_gc_mask_clr_bit; gc->chip_types->chip.irq_unmask = irq_gc_mask_set_bit; gc->chip_types->chip.irq_set_type = stm32_irq_set_type; gc->chip_types->chip.irq_set_wake = stm32_irq_set_wake; - gc->chip_types->regs.ack = stm32_bank->pr_ofst; - gc->chip_types->regs.mask = stm32_bank->imr_ofst; gc->private = (void *)stm32_bank; /* Determine number of irqs supported */ -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: radoslaw.pietrzyk@gmail.com (Radoslaw Pietrzyk) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] ARM: irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain Date: Wed, 21 Feb 2018 14:50:26 +0100 [thread overview] Message-ID: <1519221027-4028-2-git-send-email-radoslaw.pietrzyk@gmail.com> (raw) In-Reply-To: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> - allocates generic chip with handle_simple_irq which simplifies irq_domain_ops.alloc callback - removes ack register from generic chip which is not used for handle_simple_irq as acking is done in a chained handler - removes unneeded irq_domain_ops.xlate callback Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> --- drivers/irqchip/irq-stm32-exti.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index 36f0fbe..42e74e3 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -176,16 +176,12 @@ static int stm32_irq_set_wake(struct irq_data *data, unsigned int on) static int stm32_exti_alloc(struct irq_domain *d, unsigned int virq, unsigned int nr_irqs, void *data) { - struct irq_chip_generic *gc; struct irq_fwspec *fwspec = data; irq_hw_number_t hwirq; hwirq = fwspec->param[0]; - gc = irq_get_domain_generic_chip(d, hwirq); irq_map_generic_chip(d, virq, hwirq); - irq_domain_set_info(d, virq, hwirq, &gc->chip_types->chip, gc, - handle_simple_irq, NULL, NULL); return 0; } @@ -200,7 +196,6 @@ static void stm32_exti_free(struct irq_domain *d, unsigned int virq, struct irq_domain_ops irq_exti_domain_ops = { .map = irq_map_generic_chip, - .xlate = irq_domain_xlate_onetwocell, .alloc = stm32_exti_alloc, .free = stm32_exti_free, }; @@ -231,7 +226,7 @@ __init stm32_exti_init(const struct stm32_exti_bank **stm32_exti_banks, } ret = irq_alloc_domain_generic_chips(domain, IRQS_PER_BANK, 1, "exti", - handle_edge_irq, clr, 0, 0); + handle_simple_irq, clr, 0, 0); if (ret) { pr_err("%pOF: Could not allocate generic interrupt chip.\n", node); @@ -246,13 +241,10 @@ __init stm32_exti_init(const struct stm32_exti_bank **stm32_exti_banks, gc->reg_base = base; gc->chip_types->type = IRQ_TYPE_EDGE_BOTH; - gc->chip_types->chip.irq_ack = irq_gc_ack_set_bit; gc->chip_types->chip.irq_mask = irq_gc_mask_clr_bit; gc->chip_types->chip.irq_unmask = irq_gc_mask_set_bit; gc->chip_types->chip.irq_set_type = stm32_irq_set_type; gc->chip_types->chip.irq_set_wake = stm32_irq_set_wake; - gc->chip_types->regs.ack = stm32_bank->pr_ofst; - gc->chip_types->regs.mask = stm32_bank->imr_ofst; gc->private = (void *)stm32_bank; /* Determine number of irqs supported */ -- 1.9.1
next prev parent reply other threads:[~2018-02-21 13:50 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-21 13:50 [PATCH 0/2] Optimizes, cleans up and enhances stm32-exti irq hierarchy Radoslaw Pietrzyk 2018-02-21 13:50 ` Radoslaw Pietrzyk 2018-02-21 13:50 ` Radoslaw Pietrzyk [this message] 2018-02-21 13:50 ` [PATCH 1/2] ARM: irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain Radoslaw Pietrzyk 2018-02-22 10:55 ` [1/2] " Ludovic BARRE 2018-02-22 10:55 ` Ludovic BARRE 2018-02-22 10:55 ` Ludovic BARRE 2018-02-22 11:01 ` Radosław Pietrzyk 2018-02-22 11:01 ` Radosław Pietrzyk 2018-02-22 11:01 ` Radosław Pietrzyk 2018-02-23 8:34 ` Radosław Pietrzyk 2018-02-23 8:34 ` Radosław Pietrzyk 2018-02-23 8:34 ` Radosław Pietrzyk 2018-02-21 13:50 ` [PATCH 2/2] ARM: pinctrl: stm32: Optimizes and enhances stm32gpio irqchip Radoslaw Pietrzyk 2018-02-21 13:50 ` Radoslaw Pietrzyk 2018-02-21 15:11 ` Alexandre Torgue 2018-02-21 15:11 ` Alexandre Torgue 2018-02-21 15:11 ` Alexandre Torgue 2018-02-21 15:12 ` Alexandre Torgue 2018-02-21 15:12 ` Alexandre Torgue 2018-02-21 15:12 ` Alexandre Torgue 2018-03-01 21:04 ` Linus Walleij 2018-03-01 21:04 ` Linus Walleij 2018-03-01 21:24 ` Radosław Pietrzyk 2018-03-01 21:24 ` Radosław Pietrzyk 2018-03-02 8:14 ` Alexandre Torgue 2018-03-02 8:14 ` Alexandre Torgue 2018-03-02 8:14 ` Alexandre Torgue 2018-03-02 8:37 ` Radosław Pietrzyk 2018-03-02 8:37 ` Radosław Pietrzyk 2018-03-02 8:49 ` Alexandre Torgue 2018-03-02 8:49 ` Alexandre Torgue 2018-02-23 8:31 ` [PATCH v2 0/2] v2 patches for stm32-exti irq hierarchy Radoslaw Pietrzyk 2018-02-23 8:31 ` Radoslaw Pietrzyk 2018-02-23 8:31 ` [PATCH v2 1/2] irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain Radoslaw Pietrzyk 2018-02-23 8:31 ` Radoslaw Pietrzyk 2018-02-23 8:42 ` Thomas Gleixner 2018-02-23 8:42 ` Thomas Gleixner 2018-02-23 8:42 ` Thomas Gleixner 2018-02-23 9:05 ` Radosław Pietrzyk 2018-02-23 9:05 ` Radosław Pietrzyk 2018-02-23 9:05 ` Radosław Pietrzyk 2018-03-14 11:09 ` Marc Zyngier 2018-03-14 11:09 ` Marc Zyngier [not found] ` <CAFvLkMSZjgFMAe0VRc0AEpG89BgXkfMb9+ivJ8V+PFighOoDRA@mail.gmail.com> 2018-03-14 12:04 ` Marc Zyngier 2018-03-14 12:04 ` Marc Zyngier 2018-04-19 13:24 ` Ludovic BARRE 2018-04-19 13:24 ` Ludovic BARRE [not found] ` <CAFvLkMQv3AajhFaRxsBt+UzdGFeix_FA-0mhtYqwMo2x0zgrnA@mail.gmail.com> 2018-04-20 7:18 ` Ludovic BARRE 2018-04-20 7:18 ` Ludovic BARRE 2018-02-23 15:46 ` Ludovic BARRE 2018-02-23 15:46 ` Ludovic BARRE 2018-02-23 15:46 ` Ludovic BARRE 2018-02-23 16:16 ` Ludovic BARRE 2018-02-23 16:16 ` Ludovic BARRE 2018-02-23 16:16 ` Ludovic BARRE 2018-02-23 17:37 ` Radosław Pietrzyk 2018-02-23 17:37 ` Radosław Pietrzyk 2018-02-23 17:37 ` Radosław Pietrzyk 2018-02-26 15:23 ` Ludovic BARRE 2018-02-26 15:23 ` Ludovic BARRE 2018-02-26 15:23 ` Ludovic BARRE 2018-02-23 8:31 ` [PATCH v2 2/2] pinctrl: stm32: Optimizes and enhances stm32gpio irqchip Radoslaw Pietrzyk 2018-02-23 8:31 ` Radoslaw Pietrzyk 2018-02-26 15:25 ` Ludovic BARRE 2018-02-26 15:25 ` Ludovic BARRE 2018-02-26 15:25 ` Ludovic BARRE 2018-03-01 22:41 ` Linus Walleij 2018-03-01 22:41 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1519221027-4028-2-git-send-email-radoslaw.pietrzyk@gmail.com \ --to=radoslaw.pietrzyk@gmail.com \ --cc=alexandre.torgue@st.com \ --cc=benjamin.gaignard@linaro.org \ --cc=jason@lakedaemon.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=p.zabel@pengutronix.de \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.