* [PATCH] mfd: rk808: Fix RK818 ID template
@ 2018-02-22 9:54 Daniel Schultz
2018-02-22 15:25 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Schultz @ 2018-02-22 9:54 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, W.Egorov
The Rockchip PMIC driver can automatically detect connected component
versions by reading the ID_MSB and ID_LSB registers. The probe function
will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
RK818 template ID is 0x8181.
This patch changes this value to 0x8180.
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
include/linux/mfd/rk808.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index d315659..338e0f6 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -443,7 +443,7 @@ enum {
enum {
RK805_ID = 0x8050,
RK808_ID = 0x0000,
- RK818_ID = 0x8181,
+ RK818_ID = 0x8180,
};
struct rk808 {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: rk808: Fix RK818 ID template
2018-02-22 9:54 [PATCH] mfd: rk808: Fix RK818 ID template Daniel Schultz
@ 2018-02-22 15:25 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2018-02-22 15:25 UTC (permalink / raw)
To: Daniel Schultz; +Cc: linux-kernel, W.Egorov
On Thu, 22 Feb 2018, Daniel Schultz wrote:
> The Rockchip PMIC driver can automatically detect connected component
> versions by reading the ID_MSB and ID_LSB registers. The probe function
> will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
> RK818 template ID is 0x8181.
>
> This patch changes this value to 0x8180.
>
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
> include/linux/mfd/rk808.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 9:54 [PATCH] mfd: rk808: Fix RK818 ID template Daniel Schultz
2018-02-22 15:25 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.