All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.de,
	liam.r.girdwood@linux.intel.com
Cc: vinod.koul@intel.com, patches.audio@intel.com,
	Rakesh Ughreja <rakesh.a.ughreja@intel.com>,
	pierre-louis.bossart@linux.intel.com
Subject: [PATCH v1 2/9] ASoC: Intel: Skylake: Add entry in sst_acpi_mach for HDA codecs
Date: Fri, 23 Feb 2018 13:42:23 +0530	[thread overview]
Message-ID: <1519373550-2545-3-git-send-email-rakesh.a.ughreja@intel.com> (raw)
In-Reply-To: <1519373550-2545-1-git-send-email-rakesh.a.ughreja@intel.com>

When no I2S based codec entries are found in the BIOS, check if there are
any HDA codecs detected on the bus. If there are two (i.e. iDisp + HDA)
HDA codecs found on the bus, load the HDA machine driver.

Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
---
 sound/soc/intel/skylake/skl.c | 59 +++++++++++++++++++++++++++++++++++++++----
 1 file changed, 54 insertions(+), 5 deletions(-)

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index f948f29..ac64416 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -442,6 +442,24 @@ static struct skl_ssp_clk skl_ssp_clks[] = {
 						{.name = "ssp5_sclkfs"},
 };
 
+static struct snd_soc_acpi_mach *skl_find_hda_machine(struct skl *skl,
+					struct snd_soc_acpi_mach *machines)
+{
+
+	struct snd_soc_acpi_mach *mach;
+	struct hdac_bus *bus = skl_to_bus(skl);
+
+	/* check if we have two HDA codecs */
+	if (hweight_long(bus->codec_mask) != 2)
+		return NULL;
+
+	for (mach = machines; mach->id[0]; mach++) {
+		if (!strcmp(mach->id, "HDA_GEN"))
+			return mach;
+	}
+	return NULL;
+}
+
 static int skl_find_machine(struct skl *skl, void *driver_data)
 {
 	struct hdac_bus *bus = skl_to_bus(skl);
@@ -450,8 +468,12 @@ static int skl_find_machine(struct skl *skl, void *driver_data)
 
 	mach = snd_soc_acpi_find_machine(mach);
 	if (mach == NULL) {
-		dev_err(bus->dev, "No matching machine driver found\n");
-		return -ENODEV;
+		dev_dbg(bus->dev, "No matching I2S machine driver found\n");
+		mach = skl_find_hda_machine(skl, driver_data);
+		if (mach == NULL) {
+			dev_err(bus->dev, "No matching machine driver found\n");
+			return -ENODEV;
+		}
 	}
 
 	skl->mach = mach;
@@ -466,8 +488,9 @@ static int skl_find_machine(struct skl *skl, void *driver_data)
 
 static int skl_machine_device_register(struct skl *skl)
 {
-	struct hdac_bus *bus = skl_to_bus(skl);
 	struct snd_soc_acpi_mach *mach = skl->mach;
+	struct hdac_bus *bus = skl_to_bus(skl);
+	struct skl_machine_pdata *pdata;
 	struct platform_device *pdev;
 	int ret;
 
@@ -484,8 +507,11 @@ static int skl_machine_device_register(struct skl *skl)
 		return -EIO;
 	}
 
-	if (mach->pdata)
+	if (mach->pdata) {
+		pdata = (struct skl_machine_pdata *)mach->pdata;
+		pdata->platform = dev_name(bus->dev);
 		dev_set_drvdata(&pdev->dev, mach->pdata);
+	}
 
 	skl->i2s_dev = pdev;
 
@@ -1030,6 +1056,14 @@ static struct snd_soc_acpi_mach sst_skl_devdata[] = {
 		.quirk_data = &skl_codecs,
 		.pdata = &skl_dmic_data
 	},
+	{
+		.id = "HDA_GEN",
+		.drv_name = "skl_hda_generic",
+		.fw_filename = "intel/dsp_fw_release.bin",
+		.machine_quirk = NULL,
+		.quirk_data = NULL,
+		.pdata = &cnl_pdata,
+	},
 	{}
 };
 
@@ -1046,6 +1080,14 @@ static struct snd_soc_acpi_mach sst_bxtp_devdata[] = {
 		.machine_quirk = snd_soc_acpi_codec_list,
 		.quirk_data = &bxt_codecs,
 	},
+	{
+		.id = "HDA_GEN",
+		.drv_name = "skl_hda_generic",
+		.fw_filename = "intel/dsp_fw_bxtn.bin",
+		.machine_quirk = NULL,
+		.quirk_data = NULL,
+		.pdata = &cnl_pdata,
+	},
 	{}
 };
 
@@ -1100,7 +1142,14 @@ static struct snd_soc_acpi_mach sst_kbl_devdata[] = {
 		.quirk_data = &kbl_7219_98357_codecs,
 		.pdata = &skl_dmic_data
 	},
-
+	{
+		.id = "HDA_GEN",
+		.drv_name = "skl_hda_generic",
+		.fw_filename = "intel/dsp_fw_kbl.bin",
+		.machine_quirk = NULL,
+		.quirk_data = NULL,
+		.pdata = &cnl_pdata,
+	},
 	{}
 };
 
-- 
2.7.4

  parent reply	other threads:[~2018-02-23  8:10 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23  8:12 [PATCH v1 0/9] Enable HDA Codec support on Intel Platforms (Series2) Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 1/9] ASoC: Intel: Boards: Machine driver for Intel platforms Rakesh Ughreja
2018-02-23 16:33   ` Pierre-Louis Bossart
2018-02-26  8:18     ` Ughreja, Rakesh A
2018-02-26 19:11       ` Pierre-Louis Bossart
2018-02-27  5:12         ` Ughreja, Rakesh A
2018-02-23  8:12 ` Rakesh Ughreja [this message]
2018-02-23 16:42   ` [PATCH v1 2/9] ASoC: Intel: Skylake: Add entry in sst_acpi_mach for HDA codecs Pierre-Louis Bossart
2018-02-26  8:17     ` Ughreja, Rakesh A
2018-02-26 18:55       ` Pierre-Louis Bossart
2018-02-27  3:45         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 3/9] ASoC: Intel: Skylake: add HDA BE DAIs Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 4/9] ASoC: Intel: Skylake: use hda_bus instead of hdac_bus Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 5/9] ALSA: hda - split snd_hda_codec_new function Rakesh Ughreja
2018-02-23 16:50   ` Pierre-Louis Bossart
2018-02-26  8:28     ` Ughreja, Rakesh A
2018-02-26 19:14       ` Pierre-Louis Bossart
2018-02-27  3:28         ` Ughreja, Rakesh A
2018-02-23 16:51   ` Takashi Iwai
2018-02-26  8:33     ` Ughreja, Rakesh A
2018-02-26  8:41       ` Takashi Iwai
2018-02-26  9:09         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 6/9] ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 7/9] ALSA: hdac: add extended ops in the hdac_bus Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 8/9] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers Rakesh Ughreja
2018-02-23 10:17   ` Takashi Iwai
2018-02-26 10:11     ` Ughreja, Rakesh A
2018-02-26 10:25       ` Takashi Iwai
2018-02-26 15:57         ` Ughreja, Rakesh A
2018-02-26 15:59           ` Takashi Iwai
2018-02-26 16:02             ` Ughreja, Rakesh A
2018-02-26 19:19         ` Pierre-Louis Bossart
2018-02-27  3:34           ` Ughreja, Rakesh A
2018-02-23 16:54   ` Pierre-Louis Bossart
2018-02-26  8:44     ` Ughreja, Rakesh A
2018-02-26 19:26       ` Pierre-Louis Bossart
2018-02-27  3:31         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 9/9] ASoC: Intel: Boards: add support for HDA codecs Rakesh Ughreja
2018-02-23 17:04   ` Pierre-Louis Bossart
2018-02-26 16:01     ` Ughreja, Rakesh A
2018-02-26 19:37       ` Pierre-Louis Bossart
2018-02-27 16:20         ` Ughreja, Rakesh A
2018-02-27 16:55           ` Takashi Iwai
2018-02-27 17:06             ` Ughreja, Rakesh A
2018-02-27 17:16               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519373550-2545-3-git-send-email-rakesh.a.ughreja@intel.com \
    --to=rakesh.a.ughreja@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.