All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.de,
	liam.r.girdwood@linux.intel.com
Cc: vinod.koul@intel.com, patches.audio@intel.com,
	Rakesh Ughreja <rakesh.a.ughreja@intel.com>,
	pierre-louis.bossart@linux.intel.com
Subject: [PATCH v1 7/9] ALSA: hdac: add extended ops in the hdac_bus
Date: Fri, 23 Feb 2018 13:42:28 +0530	[thread overview]
Message-ID: <1519373550-2545-8-git-send-email-rakesh.a.ughreja@intel.com> (raw)
In-Reply-To: <1519373550-2545-1-git-send-email-rakesh.a.ughreja@intel.com>

Add extended ops in the hdac_bus to allow calling the ASoC HDAC library
ops to reuse the legacy HDA codec drivers with ASoC framework.
Extended ops are used by the legacy codec drivers to call into
hdac_hda library, in the subsequent patches..

Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
---
 include/sound/hdaudio.h       | 9 +++++++++
 include/sound/hdaudio_ext.h   | 3 ++-
 sound/hda/ext/hdac_ext_bus.c  | 4 +++-
 sound/soc/intel/skylake/skl.c | 2 +-
 4 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
index 01d3103..f30ecb0 100644
--- a/include/sound/hdaudio.h
+++ b/include/sound/hdaudio.h
@@ -214,6 +214,14 @@ struct hdac_bus_ops {
 };
 
 /*
+ * ops used for ASoC HDA codec drivers
+ */
+struct hdac_ext_bus_ops {
+	int (*probe)(struct hdac_device *hdev);
+	int (*remove)(struct hdac_device *hdev);
+};
+
+/*
  * Lowlevel I/O operators
  */
 struct hdac_io_ops {
@@ -268,6 +276,7 @@ struct hdac_bus {
 	struct device *dev;
 	const struct hdac_bus_ops *ops;
 	const struct hdac_io_ops *io_ops;
+	const struct hdac_ext_bus_ops *ext_ops;
 
 	/* h/w resources */
 	unsigned long addr;
diff --git a/include/sound/hdaudio_ext.h b/include/sound/hdaudio_ext.h
index c188b80..f34aced 100644
--- a/include/sound/hdaudio_ext.h
+++ b/include/sound/hdaudio_ext.h
@@ -6,7 +6,8 @@
 
 int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev,
 		      const struct hdac_bus_ops *ops,
-		      const struct hdac_io_ops *io_ops);
+		      const struct hdac_io_ops *io_ops,
+		      const struct hdac_ext_bus_ops *ext_ops);
 
 void snd_hdac_ext_bus_exit(struct hdac_bus *bus);
 int snd_hdac_ext_bus_device_init(struct hdac_bus *bus, int addr,
diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c
index 1eb5824..9c37d9a 100644
--- a/sound/hda/ext/hdac_ext_bus.c
+++ b/sound/hda/ext/hdac_ext_bus.c
@@ -89,7 +89,8 @@ static const struct hdac_io_ops hdac_ext_default_io = {
  */
 int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev,
 			const struct hdac_bus_ops *ops,
-			const struct hdac_io_ops *io_ops)
+			const struct hdac_io_ops *io_ops,
+			const struct hdac_ext_bus_ops *ext_ops)
 {
 	int ret;
 	static int idx;
@@ -102,6 +103,7 @@ int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev,
 	if (ret < 0)
 		return ret;
 
+	bus->ext_ops = ext_ops;
 	INIT_LIST_HEAD(&bus->hlink_list);
 	bus->idx = idx++;
 
diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index f273b9f..1a5ac1b 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -801,7 +801,7 @@ static int skl_create(struct pci_dev *pci,
 
 	hbus = skl_to_hbus(skl);
 	bus = skl_to_bus(skl);
-	snd_hdac_ext_bus_init(bus, &pci->dev, &bus_core_ops, io_ops);
+	snd_hdac_ext_bus_init(bus, &pci->dev, &bus_core_ops, io_ops, NULL);
 	bus->use_posbuf = 1;
 	skl->pci = pci;
 	INIT_WORK(&skl->probe_work, skl_probe_work);
-- 
2.7.4

  parent reply	other threads:[~2018-02-23  8:10 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23  8:12 [PATCH v1 0/9] Enable HDA Codec support on Intel Platforms (Series2) Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 1/9] ASoC: Intel: Boards: Machine driver for Intel platforms Rakesh Ughreja
2018-02-23 16:33   ` Pierre-Louis Bossart
2018-02-26  8:18     ` Ughreja, Rakesh A
2018-02-26 19:11       ` Pierre-Louis Bossart
2018-02-27  5:12         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 2/9] ASoC: Intel: Skylake: Add entry in sst_acpi_mach for HDA codecs Rakesh Ughreja
2018-02-23 16:42   ` Pierre-Louis Bossart
2018-02-26  8:17     ` Ughreja, Rakesh A
2018-02-26 18:55       ` Pierre-Louis Bossart
2018-02-27  3:45         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 3/9] ASoC: Intel: Skylake: add HDA BE DAIs Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 4/9] ASoC: Intel: Skylake: use hda_bus instead of hdac_bus Rakesh Ughreja
2018-02-23  8:12 ` [PATCH v1 5/9] ALSA: hda - split snd_hda_codec_new function Rakesh Ughreja
2018-02-23 16:50   ` Pierre-Louis Bossart
2018-02-26  8:28     ` Ughreja, Rakesh A
2018-02-26 19:14       ` Pierre-Louis Bossart
2018-02-27  3:28         ` Ughreja, Rakesh A
2018-02-23 16:51   ` Takashi Iwai
2018-02-26  8:33     ` Ughreja, Rakesh A
2018-02-26  8:41       ` Takashi Iwai
2018-02-26  9:09         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 6/9] ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init Rakesh Ughreja
2018-02-23  8:12 ` Rakesh Ughreja [this message]
2018-02-23  8:12 ` [PATCH v1 8/9] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers Rakesh Ughreja
2018-02-23 10:17   ` Takashi Iwai
2018-02-26 10:11     ` Ughreja, Rakesh A
2018-02-26 10:25       ` Takashi Iwai
2018-02-26 15:57         ` Ughreja, Rakesh A
2018-02-26 15:59           ` Takashi Iwai
2018-02-26 16:02             ` Ughreja, Rakesh A
2018-02-26 19:19         ` Pierre-Louis Bossart
2018-02-27  3:34           ` Ughreja, Rakesh A
2018-02-23 16:54   ` Pierre-Louis Bossart
2018-02-26  8:44     ` Ughreja, Rakesh A
2018-02-26 19:26       ` Pierre-Louis Bossart
2018-02-27  3:31         ` Ughreja, Rakesh A
2018-02-23  8:12 ` [PATCH v1 9/9] ASoC: Intel: Boards: add support for HDA codecs Rakesh Ughreja
2018-02-23 17:04   ` Pierre-Louis Bossart
2018-02-26 16:01     ` Ughreja, Rakesh A
2018-02-26 19:37       ` Pierre-Louis Bossart
2018-02-27 16:20         ` Ughreja, Rakesh A
2018-02-27 16:55           ` Takashi Iwai
2018-02-27 17:06             ` Ughreja, Rakesh A
2018-02-27 17:16               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519373550-2545-8-git-send-email-rakesh.a.ughreja@intel.com \
    --to=rakesh.a.ughreja@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.