All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lightnvm: pblk: remove unused variable
@ 2018-02-26 13:18 ` Javier González
  0 siblings, 0 replies; 7+ messages in thread
From: Javier González @ 2018-02-26 13:18 UTC (permalink / raw)
  To: mb; +Cc: linux-block, linux-kernel, linux-nvme, Javier González

Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index ce6a7cfdba66..e6cb4317bb50 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_geo *geo = &dev->geo;
 	struct pblk_line_meta *lm = &pblk->lm;
 	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
-	int nr_bb = 0;
 	u64 off;
 	int bit = -1;
 	int emeta_secs;
@@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
 							lm->sec_per_line);
 		line->sec_in_line -= geo->c.clba;
-		if (bit >= lm->emeta_bb)
-			nr_bb++;
 	}
 
 	/* Mark smeta metadata sectors as bad sectors */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] lightnvm: pblk: remove unused variable
@ 2018-02-26 13:18 ` Javier González
  0 siblings, 0 replies; 7+ messages in thread
From: Javier González @ 2018-02-26 13:18 UTC (permalink / raw)


Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier Gonz?lez <javier at cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index ce6a7cfdba66..e6cb4317bb50 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_geo *geo = &dev->geo;
 	struct pblk_line_meta *lm = &pblk->lm;
 	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
-	int nr_bb = 0;
 	u64 off;
 	int bit = -1;
 	int emeta_secs;
@@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
 							lm->sec_per_line);
 		line->sec_in_line -= geo->c.clba;
-		if (bit >= lm->emeta_bb)
-			nr_bb++;
 	}
 
 	/* Mark smeta metadata sectors as bad sectors */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] lightnvm: pblk: remove unused variable
  2018-02-26 13:18 ` Javier González
@ 2018-02-26 18:20   ` Matias Bjørling
  -1 siblings, 0 replies; 7+ messages in thread
From: Matias Bjørling @ 2018-02-26 18:20 UTC (permalink / raw)
  To: Javier González
  Cc: linux-block, linux-kernel, linux-nvme, Javier González

On 02/26/2018 02:18 PM, Javier González wrote:
> Remove unused variable after a previous cleanup (a8112b631adb)
> 
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
>   drivers/lightnvm/pblk-core.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index ce6a7cfdba66..e6cb4317bb50 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>   	struct nvm_geo *geo = &dev->geo;
>   	struct pblk_line_meta *lm = &pblk->lm;
>   	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
> -	int nr_bb = 0;
>   	u64 off;
>   	int bit = -1;
>   	int emeta_secs;
> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>   		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>   							lm->sec_per_line);
>   		line->sec_in_line -= geo->c.clba;
> -		if (bit >= lm->emeta_bb)
> -			nr_bb++;
>   	}
>   
>   	/* Mark smeta metadata sectors as bad sectors */
> 

Should Fixes be added?

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] lightnvm: pblk: remove unused variable
@ 2018-02-26 18:20   ` Matias Bjørling
  0 siblings, 0 replies; 7+ messages in thread
From: Matias Bjørling @ 2018-02-26 18:20 UTC (permalink / raw)


On 02/26/2018 02:18 PM, Javier Gonz?lez wrote:
> Remove unused variable after a previous cleanup (a8112b631adb)
> 
> Signed-off-by: Javier Gonz?lez <javier at cnexlabs.com>
> ---
>   drivers/lightnvm/pblk-core.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index ce6a7cfdba66..e6cb4317bb50 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>   	struct nvm_geo *geo = &dev->geo;
>   	struct pblk_line_meta *lm = &pblk->lm;
>   	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
> -	int nr_bb = 0;
>   	u64 off;
>   	int bit = -1;
>   	int emeta_secs;
> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>   		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>   							lm->sec_per_line);
>   		line->sec_in_line -= geo->c.clba;
> -		if (bit >= lm->emeta_bb)
> -			nr_bb++;
>   	}
>   
>   	/* Mark smeta metadata sectors as bad sectors */
> 

Should Fixes be added?

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] lightnvm: pblk: remove unused variable
  2018-02-26 18:20   ` Matias Bjørling
@ 2018-02-26 18:21     ` Javier Gonzalez
  -1 siblings, 0 replies; 7+ messages in thread
From: Javier Gonzalez @ 2018-02-26 18:21 UTC (permalink / raw)
  To: Matias Bjørling; +Cc: linux-block, linux-kernel, linux-nvme

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]


> On 26 Feb 2018, at 19.20, Matias Bjørling <mb@lightnvm.io> wrote:
> 
> On 02/26/2018 02:18 PM, Javier González wrote:
>> Remove unused variable after a previous cleanup (a8112b631adb)
>> Signed-off-by: Javier González <javier@cnexlabs.com>
>> ---
>>  drivers/lightnvm/pblk-core.c | 3 ---
>>  1 file changed, 3 deletions(-)
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ce6a7cfdba66..e6cb4317bb50 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>>  	struct nvm_geo *geo = &dev->geo;
>>  	struct pblk_line_meta *lm = &pblk->lm;
>>  	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
>> -	int nr_bb = 0;
>>  	u64 off;
>>  	int bit = -1;
>>  	int emeta_secs;
>> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>>  		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>>  							lm->sec_per_line);
>>  		line->sec_in_line -= geo->c.clba;
>> -		if (bit >= lm->emeta_bb)
>> -			nr_bb++;
>>  	}
>>    	/* Mark smeta metadata sectors as bad sectors */
> 
> Should Fixes be added?

It's not a bug as such, that's why I didn't add it. But be welcome to do
so if you think it's better.

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] lightnvm: pblk: remove unused variable
@ 2018-02-26 18:21     ` Javier Gonzalez
  0 siblings, 0 replies; 7+ messages in thread
From: Javier Gonzalez @ 2018-02-26 18:21 UTC (permalink / raw)



> On 26 Feb 2018,@19.20, Matias Bj?rling <mb@lightnvm.io> wrote:
> 
> On 02/26/2018 02:18 PM, Javier Gonz?lez wrote:
>> Remove unused variable after a previous cleanup (a8112b631adb)
>> Signed-off-by: Javier Gonz?lez <javier at cnexlabs.com>
>> ---
>>  drivers/lightnvm/pblk-core.c | 3 ---
>>  1 file changed, 3 deletions(-)
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ce6a7cfdba66..e6cb4317bb50 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>>  	struct nvm_geo *geo = &dev->geo;
>>  	struct pblk_line_meta *lm = &pblk->lm;
>>  	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
>> -	int nr_bb = 0;
>>  	u64 off;
>>  	int bit = -1;
>>  	int emeta_secs;
>> @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
>>  		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
>>  							lm->sec_per_line);
>>  		line->sec_in_line -= geo->c.clba;
>> -		if (bit >= lm->emeta_bb)
>> -			nr_bb++;
>>  	}
>>    	/* Mark smeta metadata sectors as bad sectors */
> 
> Should Fixes be added?

It's not a bug as such, that's why I didn't add it. But be welcome to do
so if you think it's better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20180226/33c21c90/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] lightnvm: pblk: remove unused variable
  2018-02-28 15:57 [PATCH V2] " Javier González
@ 2018-02-28 15:57 ` Javier González
  0 siblings, 0 replies; 7+ messages in thread
From: Javier González @ 2018-02-28 15:57 UTC (permalink / raw)
  To: mb; +Cc: linux-block, linux-kernel, Javier González

Remove unused variable after a previous cleanup (a8112b631adb)

Signed-off-by: Javier González <javier@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index cd663855ee88..b85cdedb5f48 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1082,7 +1082,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 	struct nvm_geo *geo = &dev->geo;
 	struct pblk_line_meta *lm = &pblk->lm;
 	struct pblk_line_mgmt *l_mg = &pblk->l_mg;
-	int nr_bb = 0;
 	u64 off;
 	int bit = -1;
 	int emeta_secs;
@@ -1098,8 +1097,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
 		bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux,
 							lm->sec_per_line);
 		line->sec_in_line -= geo->clba;
-		if (bit >= lm->emeta_bb)
-			nr_bb++;
 	}
 
 	/* Mark smeta metadata sectors as bad sectors */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-28 16:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 13:18 [PATCH] lightnvm: pblk: remove unused variable Javier González
2018-02-26 13:18 ` Javier González
2018-02-26 18:20 ` Matias Bjørling
2018-02-26 18:20   ` Matias Bjørling
2018-02-26 18:21   ` Javier Gonzalez
2018-02-26 18:21     ` Javier Gonzalez
2018-02-28 15:57 [PATCH V2] " Javier González
2018-02-28 15:57 ` [PATCH] " Javier González

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.