[PATCH] staging: rtl8192e: move logical continuation to previous line

[PATCH] staging: rtl8192e: move logical continuation to previous line

[Santha Meena Ramamoorthy]

Move logical continuation '&&' to the previous line to conform to the
Linux kernel coding style. Issue found using checkpatch.

Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 30f72d2..22f7e7fd 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -2644,8 +2644,8 @@ static inline void rtllib_process_probe_response(
 	   (network->ssid_len ? 1 : 0))) {
 		update_network(ieee, &ieee->current_network, network);
 		if ((ieee->current_network.mode == IEEE_N_24G ||
-		     ieee->current_network.mode == IEEE_G)
-		     && ieee->current_network.berp_info_valid) {
+		     ieee->current_network.mode == IEEE_G) &&
+		     ieee->current_network.berp_info_valid) {
 			if (ieee->current_network.erp_value & ERP_UseProtection)
 				ieee->current_network.buseprotection = true;
 			else
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: move logical continuation to previous line

[Julia Lawall]

On Wed, 28 Feb 2018, Santha Meena Ramamoorthy wrote:

> Move logical continuation '&&' to the previous line to conform to the
> Linux kernel coding style. Issue found using checkpatch.
>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 30f72d2..22f7e7fd 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -2644,8 +2644,8 @@ static inline void rtllib_process_probe_response(
>  	   (network->ssid_len ? 1 : 0))) {
>  		update_network(ieee, &ieee->current_network, network);
>  		if ((ieee->current_network.mode == IEEE_N_24G ||
> -		     ieee->current_network.mode == IEEE_G)
> -		     && ieee->current_network.berp_info_valid) {
> +		     ieee->current_network.mode == IEEE_G) &&
> +		     ieee->current_network.berp_info_valid) {

It would be nice to move the above line one space to the left, so that it
is just to the right of its associated (, which is the outermost one, not
the innermost one.

julia

>  			if (ieee->current_network.erp_value & ERP_UseProtection)
>  				ieee->current_network.buseprotection = true;
>  			else
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519844728-18917-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>