Re: [PATCH 4/6] xen/sched: Remove {init, destroy}_domain() interfaces

From: Dario Faggioli <dfaggioli@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Josh Whitehead <josh.whitehead@dornerworks.com>,
	Meng Xu <mengxu@cis.upenn.edu>,
	Robert VanVossen <robert.vanvossen@dornerworks.com>
Subject: Re: [PATCH 4/6] xen/sched: Remove {init, destroy}_domain() interfaces
Date: Thu, 01 Mar 2018 12:08:22 +0100	[thread overview]
Message-ID: <1519902502.9145.18.camel@suse.com> (raw)
In-Reply-To: <8bf35012-737a-420e-33a7-ab68b06df14a@citrix.com>

[-- Attachment #1.1: Type: text/plain, Size: 1223 bytes --]

On Wed, 2018-02-28 at 16:33 +0000, Andrew Cooper wrote:
> On 28/02/18 16:22, George Dunlap wrote:
> > 
> > I kind of feel like there was a reason for the init / alloc
> > difference;
> > but as you say, at the moment all the schedulers are basically
> > identical.  In the unlikely event that we need separate callbacks,
> > we
> > can introduce them at such time as we have a need for them.
> > 
> > Reviewed-by: George Dunlap <george.dunlap@citrix.com>
> 
> It looks like it was the cpupool work (c/s 78be3dbb, 2010) which
> split
> alloc/free domdata() out of init/destroy domain() and made the latter
> effectively redundant.
> 
Yes. As far as I can see/tell (I wasn't here), that commit introduced
alloc_domdata because there was the need to allocate the per-scheduler
domain data, without immediately assigning it to sched_priv.

I guess something like this that Andrew is doing could have been done
at that point. It just was not. :-)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel