All of lore.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	James Simmons <jsimmons@infradead.org>,
	Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [PATCH 03/17] staging: lustre: statahead: remove incorrect test on agl_list_empty()
Date: Fri, 02 Mar 2018 10:31:25 +1100	[thread overview]
Message-ID: <151994708514.7628.7094184804431206060.stgit@noble> (raw)
In-Reply-To: <151994679573.7628.1024109499321778846.stgit@noble>

Including agl_list_empty() in the wait_event_idle() condition
is pointless as the body of the loop doesn't do anything
about the agl list.
So if the list wasn't empty, the while loop would spin
indefinitely.

The test was removed in the lustre-release commit
672ab0e00d61 ("LU-3270 statahead: small fixes and cleanup"),
but not in the Linux commit 5231f7651c55 ("staging: lustre:
statahead: small fixes and cleanup").

Fixes: 5231f7651c55 ("staging: lustre: statahead: small fixes and cleanup")
Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/staging/lustre/lustre/llite/statahead.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/statahead.c b/drivers/staging/lustre/lustre/llite/statahead.c
index 6052bfd7ff05..ba00881a5745 100644
--- a/drivers/staging/lustre/lustre/llite/statahead.c
+++ b/drivers/staging/lustre/lustre/llite/statahead.c
@@ -1124,7 +1124,6 @@ static int ll_statahead_thread(void *arg)
 	while (thread_is_running(sa_thread)) {
 		wait_event_idle(sa_thread->t_ctl_waitq,
 				sa_has_callback(sai) ||
-				!agl_list_empty(sai) ||
 				!thread_is_running(sa_thread));
 
 		sa_handle_callback(sai);

WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neilb@suse.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	James Simmons <jsimmons@infradead.org>,
	Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH 03/17] staging: lustre: statahead: remove incorrect test on agl_list_empty()
Date: Fri, 02 Mar 2018 10:31:25 +1100	[thread overview]
Message-ID: <151994708514.7628.7094184804431206060.stgit@noble> (raw)
In-Reply-To: <151994679573.7628.1024109499321778846.stgit@noble>

Including agl_list_empty() in the wait_event_idle() condition
is pointless as the body of the loop doesn't do anything
about the agl list.
So if the list wasn't empty, the while loop would spin
indefinitely.

The test was removed in the lustre-release commit
672ab0e00d61 ("LU-3270 statahead: small fixes and cleanup"),
but not in the Linux commit 5231f7651c55 ("staging: lustre:
statahead: small fixes and cleanup").

Fixes: 5231f7651c55 ("staging: lustre: statahead: small fixes and cleanup")
Signed-off-by: NeilBrown <neilb@suse.com>
---
 drivers/staging/lustre/lustre/llite/statahead.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/statahead.c b/drivers/staging/lustre/lustre/llite/statahead.c
index 6052bfd7ff05..ba00881a5745 100644
--- a/drivers/staging/lustre/lustre/llite/statahead.c
+++ b/drivers/staging/lustre/lustre/llite/statahead.c
@@ -1124,7 +1124,6 @@ static int ll_statahead_thread(void *arg)
 	while (thread_is_running(sa_thread)) {
 		wait_event_idle(sa_thread->t_ctl_waitq,
 				sa_has_callback(sai) ||
-				!agl_list_empty(sai) ||
 				!thread_is_running(sa_thread));
 
 		sa_handle_callback(sai);

  parent reply	other threads:[~2018-03-01 23:31 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 23:31 [PATCH 00/17] staging: remove requirement that lustre be built as module NeilBrown
2018-03-01 23:31 ` [lustre-devel] " NeilBrown
2018-03-01 23:31 ` [PATCH 06/17] staging: lustre: get entropy from nid when nid set NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08  0:19   ` Dilger, Andreas
2018-03-08  0:19     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 02/17] staging: lustre: fix bug in osc_enter_cache_try NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-07 20:51   ` Dilger, Andreas
2018-03-07 20:51     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` NeilBrown [this message]
2018-03-01 23:31   ` [lustre-devel] [PATCH 03/17] staging: lustre: statahead: remove incorrect test on agl_list_empty() NeilBrown
2018-03-07 21:08   ` Dilger, Andreas
2018-03-07 21:08     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 07/17] staging: lustre: ptlrpc: change GFP_NOFS to GFP_KERNEL NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08  0:20   ` Dilger, Andreas
2018-03-08  0:20     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 17/17] Revert "staging: Disable lustre file system for MIPS, SH, and XTENSA" NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-09  0:37   ` Dilger, Andreas
2018-03-09  0:37     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 13/17] staging: lustre: remove 'ptlrpc_thread usage' for sai_agl_thread NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-09  0:12   ` Dilger, Andreas
2018-03-09  0:12     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 14/17] staging: lustre: change sai_thread to sai_task NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-09  0:20   ` Dilger, Andreas
2018-03-09  0:20     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 05/17] staging: lustre: lnet: keep ln_nportals consistent NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-07 21:24   ` Dilger, Andreas
2018-03-07 21:24     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 08/17] staging: lustre: obdclass: use workqueue for zombie management NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08  0:27   ` Dilger, Andreas
2018-03-08  0:27     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 12/17] staging: lustre: remove unused flag from ptlrpc_thread NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08 23:54   ` Dilger, Andreas
2018-03-08 23:54     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 01/17] staging: lustre: obd_mount: use correct niduuid suffix NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-07 20:49   ` Dilger, Andreas
2018-03-07 20:49     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 16/17] staging: lustre: allow monolithic builds NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-09  0:32   ` Dilger, Andreas
2018-03-09  0:32     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 09/17] staging: lustre: ldlm: use delayed_work for pools_recalc NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08 19:22   ` Dilger, Andreas
2018-03-08 19:22     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 04/17] staging: lustre: obdclass: don't require lct_owner to be non-NULL NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-07 21:10   ` Dilger, Andreas
2018-03-07 21:10     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 11/17] staging: lustre: ptlrpc: use workqueue for pinger NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08 23:53   ` Dilger, Andreas
2018-03-08 23:53     ` [lustre-devel] " Dilger, Andreas
2018-03-11 21:37     ` NeilBrown
2018-03-11 21:37       ` [lustre-devel] " NeilBrown
2018-03-01 23:31 ` [PATCH 15/17] staging: lustre: ptlrpc: move thread creation out of module initialization NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-09  0:31   ` Dilger, Andreas
2018-03-09  0:31     ` [lustre-devel] " Dilger, Andreas
2018-03-01 23:31 ` [PATCH 10/17] staging: lustre: ptlrpc: use delayed_work in sec_gc NeilBrown
2018-03-01 23:31   ` [lustre-devel] " NeilBrown
2018-03-08 19:23   ` Dilger, Andreas
2018-03-08 19:23     ` [lustre-devel] " Dilger, Andreas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151994708514.7628.7094184804431206060.stgit@noble \
    --to=neilb@suse.com \
    --cc=andreas.dilger@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.