All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs
@ 2018-03-02  1:55 Roopa Prabhu
  2018-03-02  2:14 ` David Miller
  2018-03-02  2:18 ` Eric Dumazet
  0 siblings, 2 replies; 3+ messages in thread
From: Roopa Prabhu @ 2018-03-02  1:55 UTC (permalink / raw)
  To: davem, netdev; +Cc: eric.dumazet

From: Roopa Prabhu <roopa@cumulusnetworks.com>

Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
 include/net/fib_rules.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
index 6dd0a00..1c9e17c 100644
--- a/include/net/fib_rules.h
+++ b/include/net/fib_rules.h
@@ -112,7 +112,11 @@ struct fib_rule_notifier_info {
 	[FRA_GOTO]	= { .type = NLA_U32 }, \
 	[FRA_L3MDEV]	= { .type = NLA_U8 }, \
 	[FRA_UID_RANGE]	= { .len = sizeof(struct fib_rule_uid_range) }, \
-	[FRA_PROTOCOL]  = { .type = NLA_U8 }
+	[FRA_PROTOCOL]  = { .type = NLA_U8 }, \
+	[FRA_IP_PROTO]  = { .type = NLA_U8 }, \
+	[FRA_SPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }, \
+	[FRA_DPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }
+
 
 static inline void fib_rule_get(struct fib_rule *rule)
 {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs
  2018-03-02  1:55 [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs Roopa Prabhu
@ 2018-03-02  2:14 ` David Miller
  2018-03-02  2:18 ` Eric Dumazet
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-02  2:14 UTC (permalink / raw)
  To: roopa; +Cc: netdev, eric.dumazet

From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Thu,  1 Mar 2018 17:55:37 -0800

> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Applied, thanks Roopa.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs
  2018-03-02  1:55 [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs Roopa Prabhu
  2018-03-02  2:14 ` David Miller
@ 2018-03-02  2:18 ` Eric Dumazet
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-03-02  2:18 UTC (permalink / raw)
  To: Roopa Prabhu, davem, netdev

On Thu, 2018-03-01 at 17:55 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
>  include/net/fib_rules.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
> index 6dd0a00..1c9e17c 100644
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -112,7 +112,11 @@ struct fib_rule_notifier_info {
>  	[FRA_GOTO]	= { .type = NLA_U32 }, \
>  	[FRA_L3MDEV]	= { .type = NLA_U8 }, \
>  	[FRA_UID_RANGE]	= { .len = sizeof(struct fib_rule_uid_range) }, \
> -	[FRA_PROTOCOL]  = { .type = NLA_U8 }
> +	[FRA_PROTOCOL]  = { .type = NLA_U8 }, \
> +	[FRA_IP_PROTO]  = { .type = NLA_U8 }, \
> +	[FRA_SPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }, \
> +	[FRA_DPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }
> +

Thanks Roopa !

Reviewed-by: Eric Dumazet <edumazet@google.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-02  2:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-02  1:55 [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs Roopa Prabhu
2018-03-02  2:14 ` David Miller
2018-03-02  2:18 ` Eric Dumazet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.