[Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

[Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

[Julia Suvorova]

g_path_get_* do the same as g_strdup(basename/dirname(...)) but
without modifying the argument.

Signed-off-by: Julia Suvorova <jusual@mail.ru>
---
 scripts/checkpatch.pl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1b4b812..a88af61 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2584,6 +2584,11 @@ sub process {
 			ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
 		}
 
+# recommend g_path_get_* over g_strdup(basename/dirname(...))
+		if ($line =~ /\bg_strdup\s*\(\s*(basename|dirname)\s*\(/) {
+			WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n" . $herecurr);
+		}
+
 # recommend qemu_strto* over strto* for numeric conversions
 		if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
 			ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr);
-- 
2.1.4

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1519987399-19160-1-git-send-email-jusual@mail.ru
Subject: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   0dc8ae5e8e..427cbc7e41  master     -> master
 * [new tag]               patchew/1519987399-19160-1-git-send-email-jusual@mail.ru -> patchew/1519987399-19160-1-git-send-email-jusual@mail.ru
Switched to a new branch 'test'
c1be5c3854 checkpatch: add a warning for basename/dirname

=== OUTPUT BEGIN ===
Checking PATCH 1/1: checkpatch: add a warning for basename/dirname...
ERROR: line over 90 characters
#22: FILE: scripts/checkpatch.pl:2589:
+			WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n" . $herecurr);

total: 1 errors, 0 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

On Fri, Mar 02, 2018 at 01:43:19PM +0300, Julia Suvorova wrote:
> g_path_get_* do the same as g_strdup(basename/dirname(...)) but
> without modifying the argument.
> 
> Signed-off-by: Julia Suvorova <jusual@mail.ru>
> ---
>  scripts/checkpatch.pl | 5 +++++
>  1 file changed, 5 insertions(+)

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH v2] checkpatch: add a warning for basename/dirname

[Paolo Bonzini]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On 06/03/2018 15:31, Stefan Hajnoczi wrote:
> On Fri, Mar 02, 2018 at 01:43:19PM +0300, Julia Suvorova wrote:
>> g_path_get_* do the same as g_strdup(basename/dirname(...)) but
>> without modifying the argument.
>>
>> Signed-off-by: Julia Suvorova <jusual@mail.ru>
>> ---
>>  scripts/checkpatch.pl | 5 +++++
>>  1 file changed, 5 insertions(+)
> 
> Thanks, applied to my block-next tree:
> https://github.com/stefanha/qemu/commits/block-next

It's already in qemu.git :) (commit fb8446d94e).

Paolo


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]