[Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

[Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

[dcb]

Public bug reported:

qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
can't be negative so it is unnecessary to test it.

Source code is


    while (num_idx >= 0) {

but

    size_t num_idx = 1; /* account for NUL */

So there is no escape from the while loop.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1753437

Title:
  qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

Status in QEMU:
  New

Bug description:
  qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
  can't be negative so it is unnecessary to test it.

  Source code is

  
      while (num_idx >= 0) {

  but

      size_t num_idx = 1; /* account for NUL */

  So there is no escape from the while loop.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1753437/+subscriptions

Re: [Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

[Christian Borntraeger]

Adding qemu-s390x.

On 03/05/2018 11:31 AM, dcb wrote:
> Public bug reported:
> 
> qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
> can't be negative so it is unnecessary to test it.
> 
> Source code is
> 
> 
>     while (num_idx >= 0) {
> 
> but
> 
>     size_t num_idx = 1; /* account for NUL */
> 
> So there is no escape from the while loop.
> 
> ** Affects: qemu
>      Importance: Undecided
>          Status: New
> 

Re: [Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

[Thomas Huth]

On 05.03.2018 12:22, Christian Borntraeger wrote:
> Adding qemu-s390x.
> 
> On 03/05/2018 11:31 AM, dcb wrote:
>> Public bug reported:
>>
>> qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
>> can't be negative so it is unnecessary to test it.
>>
>> Source code is
>>
>>
>>     while (num_idx >= 0) {
>>
>> but
>>
>>     size_t num_idx = 1; /* account for NUL */
>>
>> So there is no escape from the while loop.

Actually we're defining size_t like this in the s390-ccw bios:

typedef long               size_t;

So the while loop is not endless.

But yes, this is ugly, we should fix the function and re-define size_t
to be unsigned instead...

 Thomas

Re: [Qemu-devel] [qemu-s390x] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

[Collin L. Walling]

On 03/05/2018 09:53 AM, Thomas Huth wrote:
> On 05.03.2018 12:22, Christian Borntraeger wrote:
>> Adding qemu-s390x.
>>
>> On 03/05/2018 11:31 AM, dcb wrote:
>>> Public bug reported:
>>>
>>> qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
>>> can't be negative so it is unnecessary to test it.
>>>
>>> Source code is
>>>
>>>
>>>      while (num_idx >= 0) {
>>>
>>> but
>>>
>>>      size_t num_idx = 1; /* account for NUL */
>>>
>>> So there is no escape from the while loop.
> Actually we're defining size_t like this in the s390-ccw bios:
>
> typedef long               size_t;
>
> So the while loop is not endless.
>
> But yes, this is ugly, we should fix the function and re-define size_t
> to be unsigned instead...
>
>   Thomas
>
Agreed.

-- 
- Collin L Walling

[Qemu-devel] [Bug 1753437] Re: qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

[Thomas Huth]

Looks like the mailing list <-> launchpad bridge again ignored mails to the corresponding mailing list thread. It's not a real bug, see here for details:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01142.html
I'll try to remember to clean this up the next time we update the s390-ccw bios.

** Changed in: qemu
     Assignee: (unassigned) => Thomas Huth (th-huth)

** Changed in: qemu
   Importance: Undecided => Low

** Changed in: qemu
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1753437

Title:
  qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

Status in QEMU:
  Confirmed

Bug description:
  qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
  can't be negative so it is unnecessary to test it.

  Source code is

  
      while (num_idx >= 0) {

  but

      size_t num_idx = 1; /* account for NUL */

  So there is no escape from the while loop.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1753437/+subscriptions

[Qemu-devel] [Bug 1753437] Re: pc-bios/s390-ccw/libc: size_t should be unsigned

[Thomas Huth]

** Summary changed:

- qemu/pc-bios/s390-ccw/libc.c:82: bad test ?
+ pc-bios/s390-ccw/libc: size_t should be unsigned

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1753437

Title:
  pc-bios/s390-ccw/libc: size_t should be unsigned

Status in QEMU:
  Confirmed

Bug description:
  qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
  can't be negative so it is unnecessary to test it.

  Source code is

  
      while (num_idx >= 0) {

  but

      size_t num_idx = 1; /* account for NUL */

  So there is no escape from the while loop.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1753437/+subscriptions

[Qemu-devel] [Bug 1753437] Re: pc-bios/s390-ccw/libc: size_t should be unsigned

[Thomas Huth]

Fix has been committed:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e4f869621203955761c

** Changed in: qemu
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1753437

Title:
  pc-bios/s390-ccw/libc: size_t should be unsigned

Status in QEMU:
  Fix Committed

Bug description:
  qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
  can't be negative so it is unnecessary to test it.

  Source code is

  
      while (num_idx >= 0) {

  but

      size_t num_idx = 1; /* account for NUL */

  So there is no escape from the while loop.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1753437/+subscriptions

[Qemu-devel] [Bug 1753437] Re: pc-bios/s390-ccw/libc: size_t should be unsigned

[Thomas Huth]

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1753437

Title:
  pc-bios/s390-ccw/libc: size_t should be unsigned

Status in QEMU:
  Fix Released

Bug description:
  qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
  can't be negative so it is unnecessary to test it.

  Source code is

  
      while (num_idx >= 0) {

  but

      size_t num_idx = 1; /* account for NUL */

  So there is no escape from the while loop.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1753437/+subscriptions