All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com, jbeulich@suse.com
Subject: Re: [PATCH v2 0/6] xen/x86: various XPTI speedups
Date: Mon, 05 Mar 2018 17:20:14 +0100	[thread overview]
Message-ID: <1520266814.9145.102.camel@suse.com> (raw)
In-Reply-To: <20180302081403.16953-1-jgross@suse.com>


[-- Attachment #1.1: Type: text/plain, Size: 29330 bytes --]

On Fri, 2018-03-02 at 09:13 +0100, Juergen Gross wrote:
> The complete series has been verified to still mitigate against
> Meltdown attacks. A simple performance test (make -j 4 in the Xen
> hypervisor directory) showed significant improvements compared to the
> state without this series (so with Jan's and Wei's series applied),
> the percentage after the numbers is always related to XPTI off:
> 
>        XPTI off     Jan+Wei, XPTI on    +this series, XPTI on
> real   1m21.169s    1m52.149s (+38%)    1m25.692s (+6%)
> user   2m47.652s    2m50.054s (+1%)     2m46.428s (-1%)
> sys    1m11.949s    2m21.767s (+97%)    1m23.053s (+15%)
> 
> A git branch of that series (+ Jan's and Wei's patches) is available:
> 
> https://github.com/jgross1/xen.git xpti
> 
I've run some more benchmarks, and here there are the results:

https://openbenchmarking.org/result/1803039-DARI-180303217
http://openbenchmarking.org/result/1803039-DARI-180303217&obr_nor=y&obr_hgv=Jan%2BWei%2C+XPTI+on

(I also include a textual recap at the bottom of this email.)

These numbers shows that Juergen's series is quite effective at
improving performance in pretty much all workloads that I've tested.

The only exception is schbench, but I don't think that's very relevant,
because of how the benchmark is configured in the PhoronixTestSuite (I
just recently discovered that).

The in-guest context-switching heavy workloads are the ones where this
series makes the most (positive) difference.

Note that on Stream and on Stress-ng:MemoryCopy, XPTI=on+this series
does even *better* than XPTI=off. This is most likely due to the fact
that Juergen, for now, takes advantage of PCID only for the XPTI=on
case. However, although it is indeed a bit of an unfair comparison, I
think it does prove the point that we want to have (something like)
this series.

Regards,
Dario

AIO-Stress 0.21
Test: Random Write
    MB/s > Higher Is Better
    XPTI off ............... 1926.57 |=============================================================================================================================================================================
    +this series, XPTI on .. 1931.44 |=============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 1807.30 |==================================================================================================================================================================

Stream 2013-01-17
Type: Copy
    MB/s > Higher Is Better
    XPTI off ............... 15738.48 |==============================================================================================================================================
    +this series, XPTI on .. 19011.66 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 15381.94 |===========================================================================================================================================

Stream 2013-01-17
Type: Scale
    MB/s > Higher Is Better
    XPTI off ............... 10849.14 |=================================================================================================================================================
    +this series, XPTI on .. 12833.84 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 10696.66 |===============================================================================================================================================

Stream 2013-01-17
Type: Triad
    MB/s > Higher Is Better
    XPTI off ............... 12268.20 |======================================================================================================================================================
    +this series, XPTI on .. 14085.56 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 12120.56 |====================================================================================================================================================

Stream 2013-01-17
Type: Add
    MB/s > Higher Is Better
    XPTI off ............... 12323.60 |=====================================================================================================================================
    +this series, XPTI on .. 15881.14 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 12085.76 |===================================================================================================================================

t-test1 2017-01-13
Threads: 1
    Seconds < Lower Is Better
    XPTI off ............... 75.20  |====================================================================================================
    +this series, XPTI on .. 111.12 |====================================================================================================================================================
    Jan+Wei, XPTI on ....... 130.34 |==============================================================================================================================================================================

t-test1 2017-01-13
Threads: 2
    Seconds < Lower Is Better
    XPTI off ............... 24.13 |===========================================================================================================
    +this series, XPTI on .. 34.12 |=======================================================================================================================================================
    Jan+Wei, XPTI on ....... 39.62 |===============================================================================================================================================================================

CacheBench 
Test: Read
    MB/s > Higher Is Better
    XPTI off ............... 2026.19 |=============================================================================================================================================================================
    +this series, XPTI on .. 2024.43 |=============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 2023.90 |=============================================================================================================================================================================

CacheBench 
Test: Write
    MB/s > Higher Is Better
    XPTI off ............... 9741.40 |=============================================================================================================================================================================
    +this series, XPTI on .. 9734.24 |=============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 9727.98 |=============================================================================================================================================================================

CacheBench 
Test: Read / Modify / Write
    MB/s > Higher Is Better
    XPTI off ............... 13253.33 |============================================================================================================================================================================
    +this series, XPTI on .. 13247.78 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 13239.67 |============================================================================================================================================================================

Timed Linux Kernel Compilation 4.13
Time To Compile
    Seconds < Lower Is Better
    XPTI off ............... 155.54 |=======================================================================================================================================================
    +this series, XPTI on .. 169.21 |=====================================================================================================================================================================
    Jan+Wei, XPTI on ....... 178.70 |==============================================================================================================================================================================

Timed MPlayer Compilation 1.0-rc3
Time To Compile
    Seconds < Lower Is Better
    XPTI off ............... 46.12 |=================================================================================================================================================================
    +this series, XPTI on .. 47.70 |=======================================================================================================================================================================
    Jan+Wei, XPTI on ....... 50.02 |===============================================================================================================================================================================

Timed PHP Compilation 7.1.9
Time To Compile
    Seconds < Lower Is Better
    XPTI off ............... 119.46 |==========================================================================================================================================================
    +this series, XPTI on .. 128.66 |======================================================================================================================================================================
    Jan+Wei, XPTI on ....... 135.01 |==============================================================================================================================================================================

Parallel BZIP2 Compression 1.1.12
256MB File Compression
    Seconds < Lower Is Better
    XPTI off ............... 8.96 |===================================================================================================================================================================
    +this series, XPTI on .. 8.47 |==========================================================================================================================================================
    Jan+Wei, XPTI on ....... 9.67 |================================================================================================================================================================================

Hackbench 
Count: 1 - Type: Thread
    Seconds < Lower Is Better
    XPTI off ............... 11.45 |================================================================================================================
    +this series, XPTI on .. 15.48 |=======================================================================================================================================================
    Jan+Wei, XPTI on ....... 17.91 |===============================================================================================================================================================================

Hackbench 
Count: 4 - Type: Thread
    Seconds < Lower Is Better
    XPTI off ............... 38.43 |=========================================================================================================
    +this series, XPTI on .. 53.90 |====================================================================================================================================================
    Jan+Wei, XPTI on ....... 63.83 |===============================================================================================================================================================================

Hackbench 
Count: 16 - Type: Thread
    Seconds < Lower Is Better
    XPTI off ............... 140.91 |====================================================================================================
    +this series, XPTI on .. 203.78 |=================================================================================================================================================
    Jan+Wei, XPTI on ....... 244.98 |==============================================================================================================================================================================

Stress-NG 0.07.26
Test: Crypto
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 689.36 |==============================================================================================================================================================================
    +this series, XPTI on .. 688.78 |==============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 688.35 |==============================================================================================================================================================================

Stress-NG 0.07.26
Test: Bsearch
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 3941.30 |=============================================================================================================================================================================
    +this series, XPTI on .. 3902.20 |===========================================================================================================================================================================
    Jan+Wei, XPTI on ....... 3909.30 |============================================================================================================================================================================

Stress-NG 0.07.26
Test: Forking
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 6208.40 |=============================================================================================================================================================================
    +this series, XPTI on .. 5589.59 |============================================================================================================================================================
    Jan+Wei, XPTI on ....... 4601.54 |================================================================================================================================

Stress-NG 0.07.26
Test: Hsearch
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 26380.63 |============================================================================================================================================================================
    +this series, XPTI on .. 26389.66 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 26246.49 |===========================================================================================================================================================================

Stress-NG 0.07.26
Test: Lsearch
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 60.27 |===============================================================================================================================================================================
    +this series, XPTI on .. 60.27 |===============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 55.76 |==================================================================================================================================================================

Stress-NG 0.07.26
Test: Tsearch
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 125.72 |==============================================================================================================================================================================
    +this series, XPTI on .. 125.02 |=============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 124.12 |============================================================================================================================================================================

Stress-NG 0.07.26
Test: CPU Stress
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 1706.72 |=====================================================================================================================================================================
    +this series, XPTI on .. 1733.77 |========================================================================================================================================================================
    Jan+Wei, XPTI on ....... 1787.12 |=============================================================================================================================================================================

Stress-NG 0.07.26
Test: Semaphores
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 2262689.37 |==========================================================================================================================================================================
    +this series, XPTI on .. 2109096.56 |==============================================================================================================================================================
    Jan+Wei, XPTI on ....... 2041884.08 |=========================================================================================================================================================

Stress-NG 0.07.26
Test: Matrix Math
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 20287.24 |============================================================================================================================================================================
    +this series, XPTI on .. 20259.78 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 20263.31 |============================================================================================================================================================================

Stress-NG 0.07.26
Test: Vector Math
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 10516.51 |============================================================================================================================================================================
    +this series, XPTI on .. 10507.48 |============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 10497.54 |============================================================================================================================================================================

Stress-NG 0.07.26
Test: Memory Copying
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 978.38  |================================================================================================================================================================
    +this series, XPTI on .. 1058.67 |=============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 983.75  |=================================================================================================================================================================

Stress-NG 0.07.26
Test: Socket Activity
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 1568.00 |=============================================================================================================================================================================
    +this series, XPTI on .. 1170.07 |=================================================================================================================================
    Jan+Wei, XPTI on ....... 923.73  |======================================================================================================

Stress-NG 0.07.26
Test: Context Switching
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 822072.29 |===========================================================================================================================================================================
    +this series, XPTI on .. 366599.11 |============================================================================
    Jan+Wei, XPTI on ....... 261709.75 |======================================================

Stress-NG 0.07.26
Test: Glibc C String Functions
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 269733.97 |===========================================================================================================================================================================
    +this series, XPTI on .. 263300.54 |=======================================================================================================================================================================
    Jan+Wei, XPTI on ....... 262641.54 |=======================================================================================================================================================================

Stress-NG 0.07.26
Test: Glibc Qsort Data Sorting
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 58.00 |===============================================================================================================================================================================
    +this series, XPTI on .. 56.32 |==========================================================================================================================================================================
    Jan+Wei, XPTI on ....... 57.99 |===============================================================================================================================================================================

Stress-NG 0.07.26
Test: System V Message Passing
    Bogo Ops/s > Higher Is Better
    XPTI off ............... 3737187.66 |==========================================================================================================================================================================
    +this series, XPTI on .. 2018958.18 |============================================================================================
    Jan+Wei, XPTI on ....... 1413159.24 |================================================================

PyBench 2018-02-16
Total For Average Test Times
    Milliseconds < Lower Is Better
    XPTI off ............... 2988 |===============================================================================================================================================================================
    +this series, XPTI on .. 2999 |================================================================================================================================================================================
    Jan+Wei, XPTI on ....... 3004 |================================================================================================================================================================================

Schbench 
Message Threads: 2 - Workers Per Message Thread: 16
    usec, 99.9th Latency Percentile < Lower Is Better
    XPTI off ............... 17696 |=======================================================================================================================================================
    +this series, XPTI on .. 18368 |=============================================================================================================================================================
    Jan+Wei, XPTI on ....... 20523 |===============================================================================================================================================================================

Schbench 
Message Threads: 4 - Workers Per Message Thread: 16
    usec, 99.9th Latency Percentile < Lower Is Better
    XPTI off ............... 86144 |=============================================================================================================================================================================
    +this series, XPTI on .. 87168 |===============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 85717 |============================================================================================================================================================================

Schbench 
Message Threads: 6 - Workers Per Message Thread: 16
    usec, 99.9th Latency Percentile < Lower Is Better
    XPTI off ............... 130219 |==============================================================================================================================================================================
    +this series, XPTI on .. 130389 |==============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 130219 |==============================================================================================================================================================================

Schbench 
Message Threads: 8 - Workers Per Message Thread: 16
    usec, 99.9th Latency Percentile < Lower Is Better
    XPTI off ............... 173141 |===========================================================================================================================================================================
    +this series, XPTI on .. 176555 |==============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 172459 |==========================================================================================================================================================================

Schbench 
Message Threads: 16 - Workers Per Message Thread: 16
    usec, 99.9th Latency Percentile < Lower Is Better
    XPTI off ............... 338773 |=============================================================================================================================================================================
    +this series, XPTI on .. 339797 |==============================================================================================================================================================================
    Jan+Wei, XPTI on ....... 329557 |=========================================================================================================================================================================

Schbench 
Message Threads: 32 - Workers Per Message Thread: 16
    usec, 99.9th Latency Percentile < Lower Is Better
    XPTI off ............... 636587 |==============================================================================================================================================================================
    +this series, XPTI on .. 624981 |===========================================================================================================================================================================
    Jan+Wei, XPTI on ....... 635904 |==============================================================================================================================================================================

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      parent reply	other threads:[~2018-03-05 16:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02  8:13 [PATCH v2 0/6] xen/x86: various XPTI speedups Juergen Gross
2018-03-02  8:13 ` [PATCH v2 1/6] x86/xpti: avoid copying L4 page table contents when possible Juergen Gross
2018-03-05 16:43   ` Jan Beulich
2018-03-08 11:59     ` Juergen Gross
2018-03-08 12:47       ` Jan Beulich
     [not found]       ` <5AA13EEA02000078001AFCAF@suse.com>
2018-03-08 13:03         ` Juergen Gross
     [not found]   ` <5A9D81DC02000078001AEB68@suse.com>
2018-03-06  7:01     ` Juergen Gross
2018-03-06  7:58       ` Jan Beulich
     [not found]       ` <5A9E583002000078001AED3A@suse.com>
2018-03-06  8:06         ` Juergen Gross
2018-03-06  8:17           ` Jan Beulich
2018-03-02  8:13 ` [PATCH v2 2/6] x86/xpti: don't flush TLB twice when switching to 64-bit pv context Juergen Gross
2018-03-05 16:49   ` Jan Beulich
     [not found]   ` <5A9D831F02000078001AEB7E@suse.com>
2018-03-06  7:02     ` Juergen Gross
2018-03-02  8:14 ` [PATCH v2 3/6] xen/x86: support per-domain flag for xpti Juergen Gross
2018-03-08 10:17   ` Jan Beulich
     [not found]   ` <5AA11BDE02000078001AFB92@suse.com>
2018-03-08 11:30     ` Juergen Gross
2018-03-08 12:49       ` Jan Beulich
     [not found]       ` <5AA13F7D02000078001AFCB3@suse.com>
2018-03-08 13:13         ` Juergen Gross
2018-03-02  8:14 ` [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active Juergen Gross
2018-03-02 11:03   ` Wei Liu
2018-03-02 11:30     ` Juergen Gross
2018-03-08 13:38   ` Jan Beulich
2018-03-09  3:01     ` Tian, Kevin
2018-03-09  5:23     ` Tian, Kevin
2018-03-09  8:34       ` Jan Beulich
     [not found]       ` <5AA2551002000078001B0116@suse.com>
2018-03-09  8:42         ` Juergen Gross
     [not found]   ` <5AA14AF302000078001AFD30@suse.com>
2018-03-08 14:05     ` Juergen Gross
2018-03-08 14:33       ` Jan Beulich
     [not found]       ` <5AA157E002000078001AFDA4@suse.com>
2018-03-08 14:39         ` Juergen Gross
2018-03-08 15:06   ` Jan Beulich
2018-03-09 14:40     ` Juergen Gross
2018-03-09 15:30       ` Jan Beulich
2018-03-02  8:14 ` [PATCH v2 5/6] xen/x86: use flag byte for decision whether xen_cr3 is valid Juergen Gross
2018-03-08 14:24   ` Jan Beulich
     [not found]   ` <5AA155BE02000078001AFD89@suse.com>
2018-03-08 14:28     ` Juergen Gross
2018-03-02  8:14 ` [PATCH v2 6/6] xen/x86: use PCID feature for XPTI Juergen Gross
2018-03-08 15:27   ` Jan Beulich
2018-03-05 16:20 ` Dario Faggioli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520266814.9145.102.camel@suse.com \
    --to=dfaggioli@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.