All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix partial warnings of checkpatch.pl for ipx_route.c
@ 2018-03-05 19:19 ` Horatiu Vultur
  0 siblings, 0 replies; 3+ messages in thread
From: Horatiu Vultur @ 2018-03-05 19:19 UTC (permalink / raw)
  To: netdev, devel, linux-kernel; +Cc: Horatiu Vultur

Fix partial warnings of checkpatch.pl for ipx_route.c

Signed-off-by: Horatiu Vultur <hvultur@gmail.com>
---
 drivers/staging/ipx/ipx_route.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ipx/ipx_route.c b/drivers/staging/ipx/ipx_route.c
index 3cf93aa9..bd26fbb 100644
--- a/drivers/staging/ipx/ipx_route.c
+++ b/drivers/staging/ipx/ipx_route.c
@@ -71,8 +71,8 @@ int ipxrtr_add_route(__be32 network, struct ipx_interface *intrfc,
 			goto out_put;
 	}
 
-	rt->ir_net 	= network;
-	rt->ir_intrfc 	= intrfc;
+	rt->ir_net	= network;
+	rt->ir_intrfc	= intrfc;
 	if (!node) {
 		memset(rt->ir_router_node, '\0', IPX_NODE_LEN);
 		rt->ir_routed = 0;
@@ -207,7 +207,7 @@ int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx,
 	ipx = ipx_hdr(skb);
 	ipx->ipx_pktsize = htons(len + sizeof(struct ipxhdr));
 	IPX_SKB_CB(skb)->ipx_tctrl = 0;
-	ipx->ipx_type 	 = usipx->sipx_type;
+	ipx->ipx_type	 = usipx->sipx_type;
 
 	IPX_SKB_CB(skb)->last_hop.index = -1;
 #ifdef CONFIG_IPX_INTERN
@@ -280,6 +280,7 @@ int ipxrtr_ioctl(unsigned int cmd, void __user *arg)
 		break;
 	case SIOCADDRT: {
 		struct ipx_route_definition f;
+
 		f.ipx_network		= st->sipx_network;
 		f.ipx_router_network	= sg->sipx_network;
 		memcpy(f.ipx_router_node, sg->sipx_node, IPX_NODE_LEN);
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] Fix partial warnings of checkpatch.pl for ipx_route.c
@ 2018-03-05 19:19 ` Horatiu Vultur
  0 siblings, 0 replies; 3+ messages in thread
From: Horatiu Vultur @ 2018-03-05 19:19 UTC (permalink / raw)
  To: netdev, devel, linux-kernel; +Cc: Horatiu Vultur

Fix partial warnings of checkpatch.pl for ipx_route.c

Signed-off-by: Horatiu Vultur <hvultur@gmail.com>
---
 drivers/staging/ipx/ipx_route.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ipx/ipx_route.c b/drivers/staging/ipx/ipx_route.c
index 3cf93aa9..bd26fbb 100644
--- a/drivers/staging/ipx/ipx_route.c
+++ b/drivers/staging/ipx/ipx_route.c
@@ -71,8 +71,8 @@ int ipxrtr_add_route(__be32 network, struct ipx_interface *intrfc,
 			goto out_put;
 	}
 
-	rt->ir_net 	= network;
-	rt->ir_intrfc 	= intrfc;
+	rt->ir_net	= network;
+	rt->ir_intrfc	= intrfc;
 	if (!node) {
 		memset(rt->ir_router_node, '\0', IPX_NODE_LEN);
 		rt->ir_routed = 0;
@@ -207,7 +207,7 @@ int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx,
 	ipx = ipx_hdr(skb);
 	ipx->ipx_pktsize = htons(len + sizeof(struct ipxhdr));
 	IPX_SKB_CB(skb)->ipx_tctrl = 0;
-	ipx->ipx_type 	 = usipx->sipx_type;
+	ipx->ipx_type	 = usipx->sipx_type;
 
 	IPX_SKB_CB(skb)->last_hop.index = -1;
 #ifdef CONFIG_IPX_INTERN
@@ -280,6 +280,7 @@ int ipxrtr_ioctl(unsigned int cmd, void __user *arg)
 		break;
 	case SIOCADDRT: {
 		struct ipx_route_definition f;
+
 		f.ipx_network		= st->sipx_network;
 		f.ipx_router_network	= sg->sipx_network;
 		memcpy(f.ipx_router_node, sg->sipx_node, IPX_NODE_LEN);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] Fix partial warnings of checkpatch.pl for ipx_route.c
  2018-03-05 19:19 ` Horatiu Vultur
  (?)
@ 2018-03-05 19:23 ` Eric Dumazet
  -1 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-03-05 19:23 UTC (permalink / raw)
  To: Horatiu Vultur, netdev, devel, linux-kernel

On Mon, 2018-03-05 at 20:19 +0100, Horatiu Vultur wrote:
> Fix partial warnings of checkpatch.pl for ipx_route.c
> 
> Signed-off-by: Horatiu Vultur <hvultur@gmail.com>
> ---
>  drivers/staging/ipx/ipx_route.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 

Please take a look at drivers/staging/ipx/TODO


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-05 19:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-05 19:19 [PATCH] Fix partial warnings of checkpatch.pl for ipx_route.c Horatiu Vultur
2018-03-05 19:19 ` Horatiu Vultur
2018-03-05 19:23 ` Eric Dumazet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.