* [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
@ 2018-03-06 9:24 Marta Lofstedt
2018-03-06 9:32 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Marta Lofstedt @ 2018-03-06 9:24 UTC (permalink / raw)
To: igt-dev
If FBC has been disabled in the system due to previous
malfuction, we would save time on CI if we bail out early.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
tests/kms_frontbuffer_tracking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 43384801..9cddc4f6 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1593,7 +1593,7 @@ static bool fbc_supported_on_chipset(void)
char buf[128];
debugfs_read("i915_fbc_status", buf);
- if (*buf == '\0')
+ if (*buf == '\0' || strstr(buf, "FBC disabled: "))
return false;
return !strstr(buf, "FBC unsupported on this chipset\n");
--
2.11.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 9:24 [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled Marta Lofstedt
@ 2018-03-06 9:32 ` Chris Wilson
2018-03-06 10:39 ` Lofstedt, Marta
2018-03-06 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-06 13:34 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2018-03-06 9:32 UTC (permalink / raw)
To: Marta Lofstedt, igt-dev
Quoting Marta Lofstedt (2018-03-06 09:24:57)
> If FBC has been disabled in the system due to previous
> malfuction, we would save time on CI if we bail out early.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
Hmm, FBC starts inactive on a system, so we would need to ensure that we
enabled FBC and did a proper modeset first and wait for FBC to be
enabled first.
Otherwise, it seems very reasonable that in this test we assume that FBC
works before we begin. We should have other tests that check that FBC
works under various different configurations, here we are checking that
the invalidate/flush do their jobs.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 9:24 [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled Marta Lofstedt
2018-03-06 9:32 ` Chris Wilson
@ 2018-03-06 10:27 ` Patchwork
2018-03-06 13:34 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-03-06 10:27 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: igt-dev
== Series Details ==
Series: igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
URL : https://patchwork.freedesktop.org/series/39432/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
68fb7595bc16a9672ea20e86431763f833cf47a7 lib/sysfs: s/kick_fbcon/bind_fbcon/
with latest DRM-Tip kernel build CI_DRM_3879
a994c52e8617 drm-tip: 2018y-03m-06d-09h-35m-22s UTC integration manifest
No testlist changes.
---- Known issues:
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> DMESG-WARN (fi-cnl-y3) fdo#103191
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-ilk-650) fdo#104008
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:424s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:427s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:506s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s
fi-bxt-dsi total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:492s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:483s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:474s
fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:411s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:577s
fi-cnl-y3 total:288 pass:261 dwarn:1 dfail:0 fail:0 skip:26 time:592s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:423s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:288s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:517s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:397s
fi-ilk-650 total:288 pass:227 dwarn:0 dfail:0 fail:1 skip:60 time:417s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:468s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:420s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:471s
fi-kbl-7560u total:108 pass:104 dwarn:0 dfail:0 fail:0 skip:3
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:461s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:514s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:436s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:521s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:536s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:499s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:481s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:420s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:439s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:513s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:400s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1065/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 9:32 ` Chris Wilson
@ 2018-03-06 10:39 ` Lofstedt, Marta
2018-03-06 10:44 ` Jani Nikula
2018-03-06 10:45 ` Chris Wilson
0 siblings, 2 replies; 11+ messages in thread
From: Lofstedt, Marta @ 2018-03-06 10:39 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: Nikula, Jani, Lankhorst, Maarten
> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Tuesday, March 6, 2018 11:32 AM
> To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
> FBC was disabled
>
> Quoting Marta Lofstedt (2018-03-06 09:24:57)
> > If FBC has been disabled in the system due to previous malfuction, we
> > would save time on CI if we bail out early.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
>
> Hmm, FBC starts inactive on a system, so we would need to ensure that we
> enabled FBC and did a proper modeset first and wait for FBC to be enabled
> first.
On the SKL NUCi5 system I have been running this on, the FBC disabled sysfs, isn't re-set after a modeset. Maybe this is a driver error that should not be hidden by me suggesting to skip the tests.
On the other hand, the kms_frontbuffer_tracking test should give different results if FBC is disabled compared to timeout in the fbc_wait_until_enabled() which up until some time ago was the most common way to fail this test.
>
> Otherwise, it seems very reasonable that in this test we assume that FBC
> works before we begin. We should have other tests that check that FBC
> works under various different configurations, here we are checking that the
> invalidate/flush do their jobs.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 10:39 ` Lofstedt, Marta
@ 2018-03-06 10:44 ` Jani Nikula
2018-03-06 10:45 ` Chris Wilson
1 sibling, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2018-03-06 10:44 UTC (permalink / raw)
To: Lofstedt, Marta, Chris Wilson, igt-dev; +Cc: Lankhorst, Maarten
On Tue, 06 Mar 2018, "Lofstedt, Marta" <marta.lofstedt@intel.com> wrote:
>> -----Original Message-----
>> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
>> Sent: Tuesday, March 6, 2018 11:32 AM
>> To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
>> dev@lists.freedesktop.org
>> Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
>> FBC was disabled
>>
>> Quoting Marta Lofstedt (2018-03-06 09:24:57)
>> > If FBC has been disabled in the system due to previous malfuction, we
>> > would save time on CI if we bail out early.
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
>> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
>>
>> Hmm, FBC starts inactive on a system, so we would need to ensure that we
>> enabled FBC and did a proper modeset first and wait for FBC to be enabled
>> first.
>
> On the SKL NUCi5 system I have been running this on, the FBC disabled
> sysfs, isn't re-set after a modeset. Maybe this is a driver error that
> should not be hidden by me suggesting to skip the tests.
That's what bugs me here. When should fbc be re-enabled after failure?
Who should be responsible for ensure it gets re-enabled in igt?
BR,
Jani.
>
> On the other hand, the kms_frontbuffer_tracking test should give
> different results if FBC is disabled compared to timeout in the
> fbc_wait_until_enabled() which up until some time ago was the most
> common way to fail this test.
>
>>
>> Otherwise, it seems very reasonable that in this test we assume that FBC
>> works before we begin. We should have other tests that check that FBC
>> works under various different configurations, here we are checking that the
>> invalidate/flush do their jobs.
>> -Chris
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 10:39 ` Lofstedt, Marta
2018-03-06 10:44 ` Jani Nikula
@ 2018-03-06 10:45 ` Chris Wilson
2018-03-06 10:55 ` Jani Nikula
1 sibling, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2018-03-06 10:45 UTC (permalink / raw)
To: Lofstedt, Marta, igt-dev; +Cc: Nikula, Jani, Lankhorst, Maarten
Quoting Lofstedt, Marta (2018-03-06 10:39:04)
>
>
> > -----Original Message-----
> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > Sent: Tuesday, March 6, 2018 11:32 AM
> > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> > dev@lists.freedesktop.org
> > Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
> > FBC was disabled
> >
> > Quoting Marta Lofstedt (2018-03-06 09:24:57)
> > > If FBC has been disabled in the system due to previous malfuction, we
> > > would save time on CI if we bail out early.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
> > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> >
> > Hmm, FBC starts inactive on a system, so we would need to ensure that we
> > enabled FBC and did a proper modeset first and wait for FBC to be enabled
> > first.
>
> On the SKL NUCi5 system I have been running this on, the FBC disabled sysfs, isn't re-set after a modeset. Maybe this is a driver error that should not be hidden by me suggesting to skip the tests.
It may just be that we see the same error. Some errors like underruns
permanently disable FBC (afaik).
> On the other hand, the kms_frontbuffer_tracking test should give different results if FBC is disabled compared to timeout in the fbc_wait_until_enabled() which up until some time ago was the most common way to fail this test.
I agree. It's just the test has to assume it is starting from scratch,
so needs to put the system into a known state before it can deduce what
is supported. So I think if we set the test mode inside setup_modeset(),
we can then test whether FBC is supported on that mode.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 10:45 ` Chris Wilson
@ 2018-03-06 10:55 ` Jani Nikula
2018-03-06 11:03 ` Chris Wilson
0 siblings, 1 reply; 11+ messages in thread
From: Jani Nikula @ 2018-03-06 10:55 UTC (permalink / raw)
To: Chris Wilson, Lofstedt, Marta, igt-dev; +Cc: Lankhorst, Maarten
On Tue, 06 Mar 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Lofstedt, Marta (2018-03-06 10:39:04)
>>
>>
>> > -----Original Message-----
>> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
>> > Sent: Tuesday, March 6, 2018 11:32 AM
>> > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
>> > dev@lists.freedesktop.org
>> > Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
>> > FBC was disabled
>> >
>> > Quoting Marta Lofstedt (2018-03-06 09:24:57)
>> > > If FBC has been disabled in the system due to previous malfuction, we
>> > > would save time on CI if we bail out early.
>> > >
>> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
>> > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
>> >
>> > Hmm, FBC starts inactive on a system, so we would need to ensure that we
>> > enabled FBC and did a proper modeset first and wait for FBC to be enabled
>> > first.
>>
>> On the SKL NUCi5 system I have been running this on, the FBC disabled sysfs, isn't re-set after a modeset. Maybe this is a driver error that should not be hidden by me suggesting to skip the tests.
>
> It may just be that we see the same error. Some errors like underruns
> permanently disable FBC (afaik).
Could we add a way to manually force enable FBC in that case? debugfs?
BR,
Jani.
>
>> On the other hand, the kms_frontbuffer_tracking test should give different results if FBC is disabled compared to timeout in the fbc_wait_until_enabled() which up until some time ago was the most common way to fail this test.
>
> I agree. It's just the test has to assume it is starting from scratch,
> so needs to put the system into a known state before it can deduce what
> is supported. So I think if we set the test mode inside setup_modeset(),
> we can then test whether FBC is supported on that mode.
> -Chris
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 10:55 ` Jani Nikula
@ 2018-03-06 11:03 ` Chris Wilson
2018-03-06 11:32 ` Lofstedt, Marta
0 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2018-03-06 11:03 UTC (permalink / raw)
To: Jani Nikula, Lofstedt, Marta, igt-dev; +Cc: Lankhorst, Maarten
Quoting Jani Nikula (2018-03-06 10:55:02)
> On Tue, 06 Mar 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Lofstedt, Marta (2018-03-06 10:39:04)
> >>
> >>
> >> > -----Original Message-----
> >> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> >> > Sent: Tuesday, March 6, 2018 11:32 AM
> >> > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> >> > dev@lists.freedesktop.org
> >> > Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
> >> > FBC was disabled
> >> >
> >> > Quoting Marta Lofstedt (2018-03-06 09:24:57)
> >> > > If FBC has been disabled in the system due to previous malfuction, we
> >> > > would save time on CI if we bail out early.
> >> > >
> >> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
> >> > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> >> >
> >> > Hmm, FBC starts inactive on a system, so we would need to ensure that we
> >> > enabled FBC and did a proper modeset first and wait for FBC to be enabled
> >> > first.
> >>
> >> On the SKL NUCi5 system I have been running this on, the FBC disabled sysfs, isn't re-set after a modeset. Maybe this is a driver error that should not be hidden by me suggesting to skip the tests.
> >
> > It may just be that we see the same error. Some errors like underruns
> > permanently disable FBC (afaik).
>
> Could we add a way to manually force enable FBC in that case? debugfs?
Or a (CRTC?) property, userspace sets it to desired, kernel updates to off/on?
(Now that is a very old dream.)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 11:03 ` Chris Wilson
@ 2018-03-06 11:32 ` Lofstedt, Marta
2018-03-06 11:40 ` Chris Wilson
0 siblings, 1 reply; 11+ messages in thread
From: Lofstedt, Marta @ 2018-03-06 11:32 UTC (permalink / raw)
To: Chris Wilson, Nikula, Jani, igt-dev; +Cc: Lankhorst, Maarten
> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Tuesday, March 6, 2018 1:03 PM
> To: Nikula, Jani <jani.nikula@intel.com>; Lofstedt, Marta
> <marta.lofstedt@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Zanoni, Paulo R <paulo.r.zanoni@intel.com>; Lankhorst, Maarten
> <maarten.lankhorst@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
> FBC was disabled
>
> Quoting Jani Nikula (2018-03-06 10:55:02)
> > On Tue, 06 Mar 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > Quoting Lofstedt, Marta (2018-03-06 10:39:04)
> > >>
> > >>
> > >> > -----Original Message-----
> > >> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > >> > Sent: Tuesday, March 6, 2018 11:32 AM
> > >> > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> > >> > dev@lists.freedesktop.org
> > >> > Subject: Re: [igt-dev] [PATCH i-g-t]
> > >> > igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
> > >> >
> > >> > Quoting Marta Lofstedt (2018-03-06 09:24:57)
> > >> > > If FBC has been disabled in the system due to previous
> > >> > > malfuction, we would save time on CI if we bail out early.
> > >> > >
> > >> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
> > >> > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > >> >
> > >> > Hmm, FBC starts inactive on a system, so we would need to ensure
> > >> > that we enabled FBC and did a proper modeset first and wait for
> > >> > FBC to be enabled first.
> > >>
> > >> On the SKL NUCi5 system I have been running this on, the FBC disabled
> sysfs, isn't re-set after a modeset. Maybe this is a driver error that should not
> be hidden by me suggesting to skip the tests.
> > >
> > > It may just be that we see the same error. Some errors like
> > > underruns permanently disable FBC (afaik).
Is, one underrun and forever no FBC is how we want it in the driver?
> >
> > Could we add a way to manually force enable FBC in that case? debugfs?
>
> Or a (CRTC?) property, userspace sets it to desired, kernel updates to
> off/on?
> (Now that is a very old dream.)
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 11:32 ` Lofstedt, Marta
@ 2018-03-06 11:40 ` Chris Wilson
0 siblings, 0 replies; 11+ messages in thread
From: Chris Wilson @ 2018-03-06 11:40 UTC (permalink / raw)
To: Lofstedt, Marta, Nikula, Jani, igt-dev; +Cc: Lankhorst, Maarten
Quoting Lofstedt, Marta (2018-03-06 11:32:56)
>
>
> > -----Original Message-----
> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > Sent: Tuesday, March 6, 2018 1:03 PM
> > To: Nikula, Jani <jani.nikula@intel.com>; Lofstedt, Marta
> > <marta.lofstedt@intel.com>; igt-dev@lists.freedesktop.org
> > Cc: Zanoni, Paulo R <paulo.r.zanoni@intel.com>; Lankhorst, Maarten
> > <maarten.lankhorst@intel.com>
> > Subject: RE: [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if
> > FBC was disabled
> >
> > Quoting Jani Nikula (2018-03-06 10:55:02)
> > > On Tue, 06 Mar 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > > Quoting Lofstedt, Marta (2018-03-06 10:39:04)
> > > >>
> > > >>
> > > >> > -----Original Message-----
> > > >> > From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> > > >> > Sent: Tuesday, March 6, 2018 11:32 AM
> > > >> > To: Lofstedt, Marta <marta.lofstedt@intel.com>; igt-
> > > >> > dev@lists.freedesktop.org
> > > >> > Subject: Re: [igt-dev] [PATCH i-g-t]
> > > >> > igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
> > > >> >
> > > >> > Quoting Marta Lofstedt (2018-03-06 09:24:57)
> > > >> > > If FBC has been disabled in the system due to previous
> > > >> > > malfuction, we would save time on CI if we bail out early.
> > > >> > >
> > > >> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105359
> > > >> > > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> > > >> >
> > > >> > Hmm, FBC starts inactive on a system, so we would need to ensure
> > > >> > that we enabled FBC and did a proper modeset first and wait for
> > > >> > FBC to be enabled first.
> > > >>
> > > >> On the SKL NUCi5 system I have been running this on, the FBC disabled
> > sysfs, isn't re-set after a modeset. Maybe this is a driver error that should not
> > be hidden by me suggesting to skip the tests.
> > > >
> > > > It may just be that we see the same error. Some errors like
> > > > underruns permanently disable FBC (afaik).
>
> Is, one underrun and forever no FBC is how we want it in the driver?
More or less, yes. Underruns == screen blinking == irate users. (Or
worse, dead machine.) FBC is a usual suspect in these matters.
Now, I would much rather put this under control of userspace; signal the
loss of FBC and let it decide whether to reprogram with a different mode
or give up. Just as for PSR, let userspace detect if FBC/PSR/whatever is
supported at this mode, and if not and userspace is power conscious, let
it try a reduced mode. (One of the purposes of the atomic modesetting API
was to allow userspace to make such global decisions.)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: warning for igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
2018-03-06 9:24 [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled Marta Lofstedt
2018-03-06 9:32 ` Chris Wilson
2018-03-06 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-06 13:34 ` Patchwork
2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-03-06 13:34 UTC (permalink / raw)
To: Lofstedt, Marta; +Cc: igt-dev
== Series Details ==
Series: igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled
URL : https://patchwork.freedesktop.org/series/39432/
State : warning
== Summary ==
---- Possible new issues:
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-1p-primscrn-spr-indfb-draw-pwrite:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-1p-primscrn-spr-indfb-onoff:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-2p-indfb-fliptrack:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-pri-indfb-multidraw:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-move:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-cur-indfb-onoff:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-indfb-msflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-indfb-pgflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-indfb-plflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-indfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-indfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-shrfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-shrfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-shrfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-pri-shrfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-shrfb-msflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-shrfb-pgflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-shrfb-plflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-fullscreen:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-move:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-primscrn-spr-indfb-onoff:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-rte:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-cur-indfb-onoff:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-indfb-msflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-indfb-pgflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-indfb-plflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-indfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-shrfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-shrfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-pri-shrfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-shrfb-msflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-shrfb-pgflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-shrfb-plflip-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-draw-blt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-fullscreen:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-move:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-scndscrn-spr-indfb-onoff:
pass -> SKIP (shard-hsw)
Subgroup fbc-2p-shrfb-fliptrack:
pass -> SKIP (shard-hsw)
Subgroup fbc-indfb-scaledprimary:
pass -> SKIP (shard-apl)
Subgroup fbc-rgb101010-draw-blt:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-rgb101010-draw-mmap-gtt:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-rgb101010-draw-pwrite:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
Subgroup fbc-rgb101010-draw-render:
pass -> SKIP (shard-apl)
pass -> SKIP (shard-hsw)
pass -> SKIP (shard-snb)
---- Known issues:
Test kms_chv_cursor_fail:
Subgroup pipe-b-128x128-bottom-edge:
pass -> DMESG-WARN (shard-snb) fdo#105185 +2
Test kms_cursor_crc:
Subgroup cursor-128x128-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103540 +1
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887 +1
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
pass -> SKIP (shard-apl) fdo#105128
Subgroup fbc-1p-primscrn-pri-indfb-draw-mmap-wc:
pass -> SKIP (shard-snb) fdo#103167 +75
Subgroup fbc-rgb565-draw-mmap-cpu:
pass -> SKIP (shard-snb) fdo#101623 +105
Test kms_rotation_crc:
Subgroup primary-rotation-180:
fail -> PASS (shard-snb) fdo#103925
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3468 pass:1756 dwarn:1 dfail:0 fail:7 skip:1703 time:12084s
shard-hsw total:3431 pass:1612 dwarn:1 dfail:0 fail:2 skip:1814 time:10831s
shard-snb total:3468 pass:1295 dwarn:3 dfail:0 fail:1 skip:2169 time:6804s
Blacklisted hosts:
shard-kbl total:3388 pass:1838 dwarn:2 dfail:0 fail:7 skip:1539 time:8736s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1065/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-03-06 13:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 9:24 [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Skip tests if FBC was disabled Marta Lofstedt
2018-03-06 9:32 ` Chris Wilson
2018-03-06 10:39 ` Lofstedt, Marta
2018-03-06 10:44 ` Jani Nikula
2018-03-06 10:45 ` Chris Wilson
2018-03-06 10:55 ` Jani Nikula
2018-03-06 11:03 ` Chris Wilson
2018-03-06 11:32 ` Lofstedt, Marta
2018-03-06 11:40 ` Chris Wilson
2018-03-06 10:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-06 13:34 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.